1691 Commits

Author SHA1 Message Date
Scott Goodson
678c201dbc [ASLayout] Add additional validation step to intercept incorrect values in production and safely zero them out.
These conditions already had assertions, but at runtime, an insufficiently tested and incorrect ASLayoutSpec could
generate values that cause UIKit to enter an infinite loop (e.g. inside of UICollectionView layout validation).
2016-04-10 16:42:22 -07:00
Michael Schneider
ed0ed74b72 Add switch to enable / disable layout option properties 2016-04-10 15:04:49 -07:00
Michael Schneider
3c66013088 Remove logging message 2016-04-10 14:23:33 -07:00
appleguy
14fc30aab0 Merge pull request #1504 from hannahmbanana/hitTestDebug
[ASControlNode] Improved hitTestDebug to account for limiting display area by parent .clipsToBounds
2016-04-10 12:52:47 -07:00
Scott Goodson
974d8c8817 [ASEnvironmentState] Don't upward-propagate sizeRange or layoutPosition (this behavior, if ultimately desirable, requires additional limiting conditions). 2016-04-10 01:31:32 -07:00
Hannah Troisi
4bd48505af [ASControlNode] hitTestDebug name refactoring 2016-04-10 01:15:15 -07:00
Hannah Troisi
a6f779a7fe [ASControlNode] hitTestDebug tool refactoring + comments:wq 2016-04-10 00:51:36 -07:00
Hannah Troisi
7fa810c77f [ASControlNode] modified hitTestDebug tool vizualize clipping of .clipsToBounds & fixed bug
- added orange overlay edge highlighting if tapable area clipped by .clipsToBounds of any parent in the hierarchy
- fixed bug in comparison of child / parent rect edges
2016-04-10 00:19:00 -07:00
Hannah Troisi
f633f6fff0 [ASControlNode] modify hitTestDebug tool to highlight edges clipped by one or more superviewsw 2016-04-09 21:36:57 -07:00
appleguy
7c4db3fbc1 Merge pull request #1477 from maicki/SmallContentBatchFetch
[ASBatchContext] Fix fetch call won't occur for content smaller than bounds unless user scrolls
2016-04-09 19:15:06 -07:00
Michael Schneider
6a147021bc Move setting of accessibilityFrame into accessibleElements
- Calculate accessibilityFrame for accessibleElements already in accessibleElements method
- Remove asyncdisplaykit_node associated object as it's not needed anymore
2016-04-09 17:03:35 -07:00
Michael Schneider
1b7db082dd Improve _ASDisplayViewAccessibility
- Add class method to create a UIAccessibilityElement from a ASDisplayNode
- Add function to iterate through a ASDisplayNode tree in bfs fashion
- Add assert for _accessibleElements in accessibilityElementAtIndex:
2016-04-09 16:07:30 -07:00
Michael Schneider
14ca529911 Moving accessibility related code to _ASDisplayViewAccessibility 2016-04-09 11:23:25 -07:00
Michael Schneider
a6f287a8fd Address pull request comment regarding ASDisplayNode properties 2016-04-09 11:23:25 -07:00
Michael Schneider
3b91c22fdf Recreate the accessibleElements if accessed 2016-04-09 11:23:25 -07:00
Michael Schneider
39950e74b2 Remove NS_AVAILABLE_IOS(8_0); 2016-04-09 11:23:25 -07:00
Michael Schneider
28c4fede57 Add support for newly added a11y properties in iOS 8 / 9 and tvOS
New a11y properties:
- accessibilityNavigationStyle
- accessibilityHeaderElements
- accessibilityActivationPoint
- accessibilityPath
2016-04-09 11:23:25 -07:00
Michael Schneider
34df512eeb Remove ASNodeValidForAccessibility 2016-04-09 11:23:25 -07:00
Michael Schneider
f3303c1fb8 Add properties for accessibilty to ASDisplayNode to support layer backed nodes 2016-04-09 11:23:25 -07:00
Michael Schneider
ef31c3abf0 Copy accessibilityIdentifier to UIAccessibilityElement if a node is assigned 2016-04-09 11:23:25 -07:00
Michael Schneider
4056bf9ef3 Return NO if node i not valid for accessibility 2016-04-09 11:23:25 -07:00
Michael Schneider
03a7c55d59 Add accessibility support for shouldRasterizeDescendants and layerBacked nodese 2016-04-09 11:23:25 -07:00
Michael Schneider
9c29d0efa8 Initial commit for improved accessibility support 2016-04-09 11:23:25 -07:00
Michael Schneider
e9fe92444f Small comment fix 2016-04-09 10:55:52 -07:00
Michael Schneider
be26f0c2e5 Revert back to use UIKit version to prevent animations 2016-04-09 10:55:52 -07:00
Michael Schneider
c19c2da2ee Remove horizontal scrolling behavior detection for ASTableView 2016-04-09 10:55:52 -07:00
Michael Schneider
18fe728230 Remove deprecation of completeBatchFetching: 2016-04-09 10:55:52 -07:00
Michael Schneider
bb110ca6e8 Readd ASDisplayShouldFetchBatchForContext 2016-04-09 10:55:52 -07:00
Michael Schneider
24ca09ee6c Move most of the batch fetching logic to a central place for ASTableView and ASCollectionView usage 2016-04-09 10:55:52 -07:00
Michael Schneider
40fe1f3ac7 Schedule _checkForBatchFetching call in animation block 2016-04-09 10:55:52 -07:00
Michael Schneider
ab8928c140 Consolidate methods for batch fetching in ASTableView 2016-04-09 10:55:52 -07:00
Michael Schneider
f92e7d5a29 Move completeBatchFetching: to deprecated location in header 2016-04-09 10:55:52 -07:00
Michael Schneider
c25a252e1c Fix fetch call won't occur for content smaller than bounds unless user scrolls 2016-04-09 10:55:52 -07:00
appleguy
0fbc77dd25 Merge pull request #1495 from maicki/FixASTableViewUpdateRangeCrash
[ASTableView] Fix crash if called updateCurrentRangeWithMode: on an ASTableNode
2016-04-08 21:14:59 -07:00
Levi McCallum
6f41d28dd0 Fix issue where zero was returned on idential object array lookup
Reviewers: scottg, schneider, garrett

Reviewed By: garrett

Subscribers: jenkins

Differential Revision: https://phabricator.pinadmin.com/D84131
2016-04-08 16:35:40 -07:00
Michael Schneider
2a8a58ec84 Expose the rangeController in ASTableView 2016-04-08 11:13:02 -07:00
appleguy
5e3091551e Merge pull request #1494 from levi/update-asdk
[ASDisplayNode] Provide a nil check and better typing for node in layout find methods
2016-04-08 10:58:21 -07:00
Levi McCallum
2cb6969c79 Use unsigned integers for findNodes vectors
Summary: Also refector logic and naming to be simpler and more descriptive

Reviewers: schneider, chris, scottg

Reviewed By: schneider, chris, scottg

Subscribers: chris, jenkins

Differential Revision: https://phabricator.pinadmin.com/D83911
2016-04-08 10:41:49 -07:00
Scott Goodson
ccddb36ed9 [ASDisplayNode] Ensure that Visible interfaceState is cleared on removal from hierarchy for rasterized elements. 2016-04-07 14:10:34 -07:00
Scott Goodson
a9b02e8632 [ASDataController] Handle incorrect client code that returns a nil ASCellNode (assert, but use zero-size cell in production). 2016-04-06 21:34:06 -07:00
Levi McCallum
25096117e7 Prevent ASInsetLayoutSpec from creating a computed layout when child is nil
Reviewers: scottg, schneider, ricky, garrett

Reviewed By: garrett

Subscribers: garrett, jenkins

Differential Revision: https://phabricator.pinadmin.com/D83683

JIRA Issue(s): BRIO-4729
2016-04-06 17:05:49 -07:00
appleguy
b3d6b545f8 Merge pull request #1478 from lappp9/muting-video-nodes
[ASVideoNode] Ensure mute property is passed onto the internal player
2016-04-05 22:10:43 -07:00
appleguy
26c8b0437e Merge pull request #1474 from Adlai-Holler/AHFilterInvalidMapSnapshotDimensions
[ASMapNode] Never Provide Invalid Snapshot Dimensions to MapKit
2016-04-05 22:03:31 -07:00
Adlai Holler
9e56cb553f [ASControlNode] Squash duplicated target-action-event tuples, fix assertion failure removing nil target 2016-04-05 15:51:53 -07:00
Michael Schneider
27cc2bec82 Add merging ASEnvironmentStateExtensions on upward propegation 2016-04-05 14:22:32 -07:00
Michael Schneider
41eb1917e4 Fix setting ASEnvironmentStateExtensions values 2016-04-05 14:22:32 -07:00
Michael Schneider
5ba756eac7 Fix comments about maximum number of extended values in ASLayoutableExtensibility 2016-04-05 07:44:28 -07:00
Luke Parham
be463c0a17 muting the video node mutes the player 2016-04-05 02:37:07 -05:00
Adlai Holler
fd159aa196 [ASMapNode] Never set invalid snapshot dimensions into MapKit 2016-04-04 16:42:51 -07:00
Hannah Troisi
dbad1c38e5 [ASEnvironment - Layout] Fixes to upward propagation of ASLayoutable properties. 2016-04-02 15:03:43 -07:00