rcancro
8dbc8b7df4
reordered conditionals, moved beta things to beta header file
2016-02-24 08:06:10 -08:00
rcancro
878fedd8f3
Stopped trying to cache the currentScaleFactor
...
Was running into issues where the scale factor would get cleared when setting a new atributedString on a textNode.
I was clearing out the currentScaleFactor when setting an attributedString into a textNode. It appears that `_calculateSize` isn't always called when setting a new string into a ASTextNode. It can be the case that only `drawInContext:bounds:` is called. With _currentScaleFactor cleared out the renderer that calls`drawInContext...` was being called with a scaleFactor of 0.
It could be the case that the fix could be to remove the clearing of `currentScaleFactor` from `setAttributedString`, but this seems like a safer fix to me. It does, however, require an extra run through the font adjuster when enabled.
2016-02-23 16:51:10 -08:00
Garrett Moon
359d19da29
ASNetworkImageNode should support a nil cache.
2016-02-22 21:58:45 -08:00
appleguy
3abde9348d
Merge pull request #1256 from Adlai-Holler/AHAffinityRevisions
...
[ASDisplayNode] Post-Review Refinements of Recent No-Affinity UIKit/CA Property Bridging
2016-02-22 20:41:59 -08:00
appleguy
3eb0d4e877
Merge pull request #1258 from rcancro/textKitBlocks
...
[ASTextNode] Add block to customize NSLayoutManager and NSTextStorage (subclass, initialization)
2016-02-22 19:44:34 -08:00
appleguy
75f620aa91
Merge pull request #1257 from Adlai-Holler/FixImageNodeLockingIssue
...
[ASImageNode:displayDidFinish] Unlock _imageLock Correctly
2016-02-22 19:40:13 -08:00
Adlai Holler
fd5723379f
[ASImageNode] Lock & unlock directly instead of using stack objects.
2016-02-22 18:48:31 -08:00
appleguy
79389ba66e
Merge pull request #1251 from ekurutepe/fix-umbrella-header
...
[AsyncDisplayKit] Adjust Umbrella header to ensure Carthage build succeeds.
2016-02-22 18:32:34 -08:00
Adlai Holler
767bff2e1a
[ASInternalHelpers] Use ASDisplayNodeThreadIsMain, reduce block allocations
2016-02-22 15:12:13 -08:00
Adlai Holler
977a509bd4
[ASCellNode] If viewControllerBlock returns an ASViewController, use its node directly instead of wrapping
2016-02-22 15:11:27 -08:00
Adlai Holler
afc70b90ab
[ASCellNode] Improve documentation, remove unused ivar
2016-02-22 15:10:02 -08:00
rcancro
00b0968bf7
Add ability to customize NSLayoutManager and NSTextStorage when created in the ASTextKitContext
2016-02-22 13:00:02 -08:00
Adlai Holler
57ca0c73bf
[ASImageNode] Correctly unlock _imageLock
2016-02-22 09:12:58 -08:00
Adlai Holler
f4e4c501f1
[ASDisplayNode] Remove misplaced comment that has been replaced
2016-02-22 09:06:36 -08:00
Adlai Holler
03d2b57991
[ASImageNode] Unlock immediately after updating _image
2016-02-22 09:04:23 -08:00
Adlai Holler
deccef1d94
[ASDisplayNode] Lock during constrainedSizeForCalculatedLayout
2016-02-22 09:04:01 -08:00
Adlai Holler
015c024b7a
[ASPendingState] Give local variables default values
2016-02-22 08:54:58 -08:00
Adlai Holler
100d0a1302
[_ASPendingState] Deduplicate logic for applying setNeedsDisplay and applying frame/bounds/position
2016-02-22 08:52:26 -08:00
appleguy
896f0adcaf
Merge pull request #1255 from garrettmoon/fixRelativeSizeResolve
...
[ASRelativeSize] Fix function prototype with a different name in header than in implementation.
2016-02-21 12:02:22 -08:00
Adlai Holler
b8d2941093
[ASPendingStateController] Unite -flush and -flushNow methods, cleanup
2016-02-21 11:27:36 -08:00
Adlai Holler
ff59401b05
[ASInternalHelpers] Improve spacing
2016-02-21 11:23:54 -08:00
Adlai Holler
5eca1e6c68
[ASDisplayNode:UIViewBridge] Clean up setNeedsDisplay/setNeedsLayout
2016-02-21 11:23:28 -08:00
Adlai Holler
d9d4d40997
[ASDisplayNode:UIViewBridge:setFrame] Use CALayer directly when possible
2016-02-21 10:52:20 -08:00
Adlai Holler
b1c7f47b02
[ASDisplayNode:UIViewBridge] Refactor setFrame: to simplify logic
2016-02-21 10:42:38 -08:00
Adlai Holler
3ff833c4f5
[ASDisplayNode:UIViewBridge] Reduce calls to -isNodeLoaded
2016-02-21 10:10:04 -08:00
Adlai Holler
e1bf0f6a88
[ASDisplayNode:setFrame] Initialize local variable values
2016-02-21 10:08:27 -08:00
Adlai Holler
648dc817ad
[ASDisplayNode] Use a C function to lazily create pending view state
2016-02-21 10:03:06 -08:00
appleguy
29726fbe38
Merge pull request #1048 from Adlai-Holler/ThreadSafeViewLayerProperties
...
[ASDisplayNode] Eliminate Thread Affinity for Writing in Background - UIKit / CA Bridged Properties
2016-02-21 01:07:20 -08:00
Scott Goodson
4637bf6a37
[ASStackLayoutSpec] Micro-optimizations to ultrahot codepaths, reducing both locking overhead and method calls.
2016-02-20 17:50:19 -08:00
Garrett Moon
6d9720bd18
Wrong name in header
2016-02-20 17:33:29 -08:00
Adlai Holler
e244b10e1e
Add a note about order of operations issue with frame/bounds/position
2016-02-20 15:43:00 -08:00
Adlai Holler
b929bfdd33
I am not a smart man
2016-02-20 15:43:00 -08:00
Adlai Holler
edf6ee59e8
[ASDisplayNode] Remove RespectThreadAffinityOfNode function
2016-02-20 15:43:00 -08:00
Adlai Holler
b47c2d5ecf
[ASTextNode] Remove more thread affinity dispatches
2016-02-20 15:43:00 -08:00
Adlai Holler
2a94d88b4b
[ASImageNode] Remove thread affinity dispatches
2016-02-20 15:43:00 -08:00
Adlai Holler
d9fc11f0f2
[ASDisplayNode] Remove thread affinity assertion in -shouldRasterizeDescendants
2016-02-20 15:43:00 -08:00
Adlai Holler
12d5c73325
[ASTextNode] Remove thread affinity dispatch
2016-02-20 15:43:00 -08:00
Adlai Holler
e9712cdfa1
Make the tests sturdier, improve setNeedsLayout/setNeedsDisplay bridging
2016-02-20 15:43:00 -08:00
Adlai Holler
636c8c04f3
Improve bridging of frame property
2016-02-20 15:43:00 -08:00
Adlai Holler
563d0893a3
Beef up the properties, beef up the demo app
2016-02-20 15:43:00 -08:00
Adlai Holler
7a6006e627
Apply same fix on opaqueness
2016-02-20 15:40:47 -08:00
Adlai Holler
b0cbd2dd59
Fix background color issue
2016-02-20 15:40:47 -08:00
Adlai Holler
71edc810d3
Revert unnecessary change to [ASDisplayNode setOpaque:]
2016-02-20 15:40:47 -08:00
Adlai Holler
a46bd8e29b
More tests, all but 1 passing
2016-02-20 15:40:47 -08:00
Adlai Holler
1514cef36d
Beef up the unit tests and make em pass
2016-02-20 15:40:47 -08:00
Adlai Holler
07b4addf1a
Document re-entrancy hazard in ASPendingStateController
2016-02-20 15:40:47 -08:00
Adlai Holler
9136ecc77b
The node is used now
2016-02-20 15:40:47 -08:00
Adlai Holler
55e3f1ee00
Fix a stupid type mismatch in ASWeakSet
2016-02-20 15:40:47 -08:00
Adlai Holler
70bc80a304
Fix map table type in ASWeakSet
2016-02-20 15:40:47 -08:00
Adlai Holler
0c6ad25f46
Add some documentation
2016-02-20 15:40:47 -08:00
