155 Commits

Author SHA1 Message Date
James Ide
b5d999ab55 Fix ASRangeController's delegate method invocations
"did" should be "will" in a couple of places
2015-01-21 17:07:53 -08:00
Ryan Nystrom
afb21bf8dd Default proxy object for ASTableView and ASCollectionView
fixes #231 #233
2015-01-20 13:15:39 -08:00
Nadine Salter
7542f7ca17 Fix build-break. 2015-01-20 12:16:30 -08:00
Nadine Salter
978cf85ae1 Merge pull request #211 from facebook/batch_animation
Batch animation
2015-01-20 11:51:31 -08:00
Ryan Nystrom
d9a3bac05d Suppress build warning with designated initializer 2015-01-14 15:43:28 -08:00
Ryan Nystrom
efaaa25017 ASMultiplexImageNode designated initializer
fixes #220
2015-01-14 15:02:15 -08:00
Łukasz Jerciński
ff260f58e1 Removed unintentional conversion. 2015-01-14 22:15:41 +01:00
Nadine Salter
dd50dd63a0 Merge pull request #215 from facebook/one-placeholder
Actual place holding
2015-01-12 12:34:12 -08:00
Ryan Nystrom
51210d7b06 Only show a placeholder if there is a place that needs holding 2015-01-12 12:26:13 -08:00
Nadine Salter
9b8a2dcd12 Merge pull request #206 from facebook/download-images-inrange
Only download images when multiplex node is displayed
2015-01-09 14:47:55 -08:00
Nadine Salter
e02cae8f2e Tidy some warnings. 2015-01-09 13:56:00 -08:00
Li Tan
90cb725b39 Fix Collection View 2015-01-08 16:27:57 -08:00
Li Tan
1068fdc413 Fix table view 2015-01-08 16:22:53 -08:00
Li Tan
00e2f46c8d Add batch animation 2015-01-08 16:09:27 -08:00
Nadine Salter
7b37563cdc Merge pull request #209 from facebook/mt-dispatch-once
Dispatch main screen scale to main once and only once
2015-01-08 14:35:09 -08:00
Ryan Nystrom
e60b51bbbf Dispatch main screen scale to main once and only once
fixes #183
2015-01-08 14:24:34 -08:00
Nadine Salter
3e851e253a Merge pull request #208 from facebook/add_flowlayout_safety_check
Add safety check to avoid crash in ASFlowLayoutController
2015-01-08 11:53:26 -08:00
Li Tan
123cab757a Add safety check to avoid crash in ASFlowLayoutController 2015-01-08 11:49:31 -08:00
Ryan Nystrom
ae1349eb16 Start downloading images when multiplex node is displayed
fixes #178
2015-01-07 17:18:00 -08:00
Ryan Nystrom
ebe614b8c9 Dispatch lazy image downloaders to another thread
fixes #148
2015-01-07 16:22:39 -08:00
Nadine Salter
bacfcbd24d Merge pull request #202 from facebook/batch_insertion
Batch insertion for reload #200
2015-01-07 14:53:15 -08:00
Li Tan
b9c6f3de03 Fix crash in Flow Controller 2015-01-06 18:04:42 -08:00
Li Tan
3adb0b1b93 Batch insertion for reload 2015-01-06 17:43:16 -08:00
Ryan Nystrom
7b86303f20 Forward touch events to either the node or super
`_ASDisplayView` now forwards touch events to either super or it's node, depending on whether or not the node implements the methods.

fixes #199
2015-01-06 16:06:59 -08:00
Nadine Salter
146a83568f Merge pull request #194 from facebook/table-selection
Call touch methods on _ASDisplayView super
2015-01-05 17:39:16 -08:00
Nadine Salter
da9ba9f7ba Merge pull request #195 from facebook/text-context-passing
Safe calls in ASTextNodeRenderer
2015-01-05 17:29:04 -08:00
Ryan Nystrom
7e30b10f13 Safe calls in ASTextNodeRenderer
fixes #190
2014-12-30 11:22:49 -08:00
Ryan Nystrom
f3be4ee041 Call touch methods on _ASDisplayView super
Currently we miss calling `-[super touches*]` on `_ASDisplayView` touch events. We delegate handling to the node which then forwards all touch events to the *superview*, skipping the current view. This seems to have some side effects with `UITableView` and it's cells/content views.

fixes #188
2014-12-30 09:47:05 -08:00
Ryan Nystrom
0473ed0a44 Consistent curlies on methods 2014-12-29 14:18:35 -08:00
Li Tan
13c57020c1 Fix typo in reloadRowsAtIndexPaths 2014-12-26 08:59:01 -08:00
Li Tan
3c0d4b2c42 Remove bachUpdate and begin/endUpdate 2014-12-19 08:48:10 -08:00
Li Tan
9367ccc19c Remove bachUpdate and begin/endUpdate 2014-12-18 20:35:27 -08:00
Li Tan
0d97d754ef fix deletion 2014-12-18 18:35:20 -08:00
Li Tan
fee3892f95 use asyncDisplayNodePerformOnMainThread 2014-12-18 18:13:01 -08:00
Li Tan
77113c6698 make reloadData thread safe 2014-12-18 16:52:09 -08:00
Ryan Nystrom
7d065adce3 Merge pull request #180 from facebook/issue-179
Only create a placeholder with a valid size
2014-12-18 14:49:59 -08:00
Ryan Nystrom
118cb32e23 Only create a placeholder with a valid size
fixes #179
2014-12-18 14:45:01 -08:00
Nadine Salter
0053a96bd5 Merge pull request #177 from facebook/fix_insert_section
Fix insert section
2014-12-18 14:18:58 -08:00
Li Tan
e799ed9ea4 fix 2014-12-18 14:00:19 -08:00
Li Tan
3e6436245d fix inserting sections bug 2014-12-18 13:07:43 -08:00
Ryan Nystrom
912bc9d460 Fade out placeholders
Added an API to fade out a node's placeholder when it is finished rendering.

fixes #156
2014-12-18 12:53:15 -08:00
Nadine Salter
4886d3d1ad Merge pull request #168 from facebook/editing
Fix crash while deleting in multiple sections
2014-12-17 13:34:47 -08:00
Ryan Nystrom
6064d3c60f Skip creating placeholder if there is no size
fixes #158
2014-12-17 10:49:52 -08:00
Li Tan
a22c4a2761 Another case for deletion 2014-12-16 20:11:31 -08:00
Li Tan
ac86cd9523 Fix crash while deleting multiple sections 2014-12-16 20:04:20 -08:00
Nadine Salter
89a0a25347 Remove CATransaction hack.
ASRangeController previously enqueued display of individual nodes by
adding their views to the hierarchy, wrapping each `-addSubview:` call
in an explicit CATransaction to force displays to occur in order.  This
hack is no longer necessary -- kill it.
2014-12-16 14:10:04 -08:00
Nadine Salter
e754cc2024 Add ASCellNode type assertions (closes #161). 2014-12-16 13:15:28 -08:00
Li Tan
62248ee0eb Fix crash in reloadData 2014-12-15 22:36:57 -08:00
Ryan Nystrom
d27c8859c7 Node placeholder API
ASDisplayNodes now have an overidable method -placeholderImage that lets you provide a custom UIImage to display while a node is displaying asyncronously. The default implementation of this method returns nil and thus does nothing. A provided example project also demonstrates using the placeholder API.
2014-12-15 17:23:52 -08:00
Li Tan
8b303710b6 fix unncessary change in editing 2014-12-15 15:57:11 -08:00