15805 Commits

Author SHA1 Message Date
Andreas Linde
e6e9685779 Fix german localization for feedback username 2015-02-18 17:25:46 +01:00
Andreas Linde
b9f149b33e Fix landscape screenshot issues in iOS 8 2015-02-18 15:08:15 +01:00
Nadine Salter
236888784d Merge pull request #311 from facebook/add_indexpath_assertion
Add assertion to avoid inserting elements that is out of range
2015-02-17 14:09:11 -08:00
Li Tan
ad88da8b56 fix typo 2015-02-13 09:41:22 -08:00
Li Tan
ae5ee2926d Add assertion to avoid inserting elements that is out of range 2015-02-12 14:10:18 -08:00
Andreas Linde
bc475061f2 Fix issues in feedback compose UI
- "Add image" button not reappearing when deleting the 3rd attachment
- Attachment scrollview not being always scrollable when it should be
- Support for rotating and correctly adjusting the attachment scrollview
2015-02-12 21:27:46 +01:00
Andreas Linde
62482b1721 Fix a crash when deleting a feedback attachment 2015-02-12 21:10:48 +01:00
Andreas Linde
7331eff2d6 Fix a warning
Fix a compiler warning when only building for simulator
2015-02-12 15:30:15 +01:00
Li Tan
831aa47ae0 Address comments 2015-02-11 19:15:08 -08:00
Nadine Salter
cd3a859f8c Merge pull request #308 from facebook/issue-262
Allow touches and long press on ASTextNode
2015-02-11 18:12:55 -08:00
Ryan Nystrom
478b4c7bab Allow touches and long press on ASTextNode
fixes #262
2015-02-11 18:04:22 -08:00
Nadine Salter
b4a5e657c5 Merge pull request #307 from facebook/issue-305
Allow all gestures through ASControlNode
2015-02-11 17:58:39 -08:00
Li Tan
6a2c472910 Add asyncDataFetchingEnabled as parameter of initializer of ASTableView & ASCollectionView
Conflicts:
	AsyncDisplayKit/ASCollectionView.mm
	AsyncDisplayKit/Details/ASDataController.mm
2015-02-11 17:24:49 -08:00
Li Tan
2f88ce56a2 Move ASTableView & ASCollectionView data fetching to background thread
Conflicts:
	AsyncDisplayKit/ASCollectionView.mm
	AsyncDisplayKit/Details/ASDataController.mm

Conflicts:
	AsyncDisplayKit/ASCollectionView.mm
	AsyncDisplayKit/Details/ASDataController.mm
2015-02-11 17:22:43 -08:00
Ryan Nystrom
52cbbd3d3c Allow all gestures through ASControlNode
fixes #305
2015-02-11 17:00:44 -08:00
Nadine Salter
e08975cbfa Merge pull request #304 from facebook/issue-286
ASImageNode not opaque by default
2015-02-11 15:54:16 -08:00
Nadine Salter
0dcb122629 Merge pull request #295 from facebook/fix_batch_update
Fix group updates/animation
2015-02-11 15:52:59 -08:00
Li Tan
dcb30b359c rename _batchUpdateFlag to _performingBatchUpdates 2015-02-11 15:22:24 -08:00
Ryan Nystrom
2a75f2bcd4 ASImageNode not opaque by default
fixes #298
2015-02-11 12:58:35 -08:00
Andreas Linde
06f73f10d3 Fix Xcode 6.3 Beta compiler warnings 2015-02-10 14:47:37 +01:00
Nadine Salter
0d0983e8f2 Merge pull request #302 from facebook/revert-228-wip/ASMultiplexImageNode-skip-failed-identifiers
Revert "Let ASMultiplexImageNode skip failed image identifiers"
2015-02-09 17:03:04 -08:00
Nadine Salter
3b8f275a2a Revert "Let ASMultiplexImageNode skip failed image identifiers" 2015-02-09 16:35:38 -08:00
Andreas Linde
afc644b0fb Don't hardcode to use mainBundle for resources 2015-02-09 17:20:54 +01:00
Peter
1dee908167 Refactoring 2015-02-09 16:34:05 +03:00
Peter
6dd75181a6 Refactoring 2015-02-06 23:04:51 +03:00
Li Tan
25bdd0d84d remove program 2015-02-06 11:44:40 -08:00
Andreas Linde
c92f1dbf61 Use NSLog instead of alertview with keychain issue
When the authentication mechanism couldn't save the auth token to the keychain, now only show a message in the console. The user will have to login on the next app start anyway until the developer fixes the keychain signing or entitlements issue.
2015-02-05 20:40:34 +01:00
Nadine Salter
8848c0db92 Merge pull request #293 from andyscott/adjust-delegate-param-types
Use specific types for Collection/TableView async delegate params
2015-02-05 10:56:31 -08:00
andyscott
cc819a7d49 Use more specific types for Collection/TableView async delegate params 2015-02-05 10:35:07 -08:00
Peter
b14f28c089 SQueue updates 2015-02-05 18:24:35 +03:00
Peter
8a90fe2db6 Tests, SCompositeDisposable refatoring 2015-02-05 16:24:13 +03:00
Peter
262b413f8f Block disposable fix 2015-02-05 15:37:52 +03:00
Nadine Salter
e6d7985ac2 Merge pull request #286 from facebook/image-aspect-fit
Respect opacity of ASImageNode
2015-02-04 18:34:36 -08:00
Nadine Salter
f8037d435e Merge pull request #289 from facebook/fix_group_animation
Fix end update in group animation
2015-02-04 13:25:05 -08:00
Li Tan
08bb0b5d70 remove throw umimplemented exception 2015-02-04 11:55:38 -08:00
Li Tan
b5245f7cd4 Fix group update 2015-02-04 11:49:39 -08:00
Ryan Nystrom
1752c724fe Respect opacity of ASImageNode
fixes #284
2015-02-03 19:54:11 -08:00
Nadine Salter
3b8de5cf52 Merge pull request #283 from andyscott/feature-template-image-mod-block
Add image modification block to render template images w/ tint.
2015-02-03 14:13:57 -08:00
andyscott
4bd9ef2927 Add image modification block to render template images w/ tint. 2015-02-03 12:54:41 -08:00
Nadine Salter
6246f077fc Update comment in Kittens example project. 2015-02-03 08:27:21 -08:00
Nadine Salter
bfc828d6e0 Use default placeholder colour in Multiplex demo. 2015-02-03 08:25:07 -08:00
Nadine Salter
6819816bd3 Restore artificial delay in Multiplex demo.
The change to ASBasicImageDownloader regressed the artificial network
delay in the original demo code.  Revert it.
2015-02-03 08:18:57 -08:00
Nadine Salter
685263a58a Merge pull request #280 from facebook/miscellanea
Miscellanea
2015-02-02 20:13:28 -08:00
Nadine Salter
f085f06ff3 -[UIView addSubnode:], -[CALayer addSubnode:].
Bring back this convenience API -- it disappeared somewhere along the
line while we were building Paper.  This is totally trivial, but
conveniently won't break if you layer-back a leaf node.

Closes #278.
2015-02-02 19:59:30 -08:00
Nadine Salter
c6a04ef8bd Switch ASScrollNode to block initialiser syntax. 2015-02-02 19:41:30 -08:00
Nadine Salter
44f2f8bad0 Merge pull request #279 from bdaz/master
Fix ASControlNode Event Dispatch Table Memory Semantics
2015-02-02 18:50:46 -08:00
Brian Amerige
b3e9b7845f Fix ASControlNode Event Dispatch Table Memory Semantics
Summary: `weakToStrong` where the keys are NSNumbers that aren't strongly held by anyone means the events in the table get removed almost immediately. Derp.

Test Plan: Confirm that events are not dropped from the table after they're added. Confirm that the "Search" button actually works in the Share Sheet.

Reviewers: suv, zsh, nyn531, kimon, bcunning, sma, grp, nadi, b3ll

Reviewed By: b3ll

Differential Revision: https://phabricator.fb.com/D1819759

Tasks: 6137402

Signature: t1:1819759:1422918745:bf25bc2662f767fec3a78fc0c7702c591ed17064
2015-02-02 17:30:27 -08:00
Nadine Salter
d9e7e5d931 Merge pull request #250 from facebook/ASScrollNode
Simple UIScrollView wrapper node.
2015-02-02 11:03:21 -08:00
Peter
cd0d3c8aa4 no message 2015-01-31 02:39:38 +03:00
Peter
34a7d245da Added .gitignore 2015-01-31 00:20:06 +03:00