14914 Commits

Author SHA1 Message Date
Scott Goodson
e005a83a2b Revert "Switch to use only layers for offscreen working range window."
There is an unsolved issue with this optimization that may cause crashes
in certain cases.  Reverting until it's properly resolved.  It doesn't
appear to be possible to cause the issue in the test apps used to develop it.

This reverts commit 3f982b5c9a7e4a557c102268f11f71b58085ffef.
2015-08-22 17:09:57 -07:00
Ethan Nagel
f7e94f42ed Node init performance: Use share instances of UIColor and NSAttributedString for defaults. 2015-08-22 17:09:57 -07:00
Sal
15975a67e8 use attributedString.length instead of attributedString.string.length to check for empty strings 2015-08-22 17:09:57 -07:00
Sal
8028364be4 Add test coverage for ASTextNodeRenderer to validate nil and empty strings produce CGSizeZero 2015-08-22 17:09:57 -07:00
Sal
df730d6771 Return CGSizeZero if ASTextNode's text length or attributed string is nil 2015-08-22 17:09:57 -07:00
Huy Nguyen
f7f20ca8b7 preferredFrameSize should be used even if neither -layoutSpecThatFits: nor -calculateSizeThatFits: is overridden by subclassses. 2015-08-22 17:09:57 -07:00
Huy Nguyen
2ea7c541a6 When a new preferredFrameSize is set, previously calculated layout should be invalidated so that the size will be picked up in the next layout pass. 2015-08-22 17:09:57 -07:00
Huy Nguyen
b93faab7f5 Improve relayout when constrained size of all nodes is changed:
- In -layoutSubviews of table and collection views, detect changes that cause a different constrained size for nodes, and trigger relayout immediately.
- Orientation change can be handled by this solution. So, no need to observe to its events.
- Update Kittens example to support iPad (easier to catch bugs on these devices) and add a title to navigation bar (looks a bit nicer).
2015-08-22 17:09:57 -07:00
rcancro
680305704a addressed comments and fixed tests 2015-08-21 21:03:40 -07:00
appleguy
80bbf79046 Merge pull request #620 from nguyenhuy/617_relayout_loading_nodes
Fix new constrained size is not applied to loading nodes
2015-08-21 21:03:30 -07:00
appleguy
80d8015240 Merge pull request #618 from garrettmoon/fixStaticLayoutWithCollectionView
Static layout doesn't properly set a height for collection view cells
2015-08-21 21:02:38 -07:00
rcancro
c06a6be188 ASLayoutSpec are temporarily mutable and have a more obj-c interface 2015-08-21 16:02:36 -07:00
rcancro
608f62d487 fixed copyright 2015-08-21 10:08:15 -07:00
ricky cancro
023ad89815 Renamed ASStackText... to ASBaselineStack... 2015-08-21 08:54:28 -07:00
Huy Nguyen
641929c4e5 By default, cell nodes in table view should fill its width. So the min constrained width is updated to enforce this behaviour. 2015-08-21 17:43:40 +03:00
Andreas Linde
d18dc57ff5 Fix unknown warning option in debug builds 2015-08-21 11:53:08 +02:00
Andreas Linde
4b30bac9f4 Update travis to use Xcode 6.4 2015-08-21 11:49:50 +02:00
Andreas Linde
16de50d959 Use bitcode on iOS9* only and assert fix
- Properly disable assertions in the build settings instead of using an Other_CFlag
- Add bitcode only when using iOS 9 or later as Base SDK which allows building without issues using older Xcode versions
2015-08-21 11:44:05 +02:00
rcancro
0a398301b0 fixed bug for baseline last 2015-08-20 20:43:18 -07:00
rcancro
ff8a7015a5 Merge branch 'baseline' of github.com:rcancro/AsyncDisplayKit into baseline 2015-08-20 20:24:17 -07:00
Huy Nguyen
97f323a8d9 Fix relayoutAllRows to trigger measurement (with the new constrained size) on all nodes, including loading ones. 2015-08-21 01:02:19 +03:00
Huy Nguyen
3e5d5c44cb Test relayout caused by a different constrained size for each and every node. All nodes, including loading ones, must be re-measured. 2015-08-21 00:59:21 +03:00
Ethan Nagel
36bac93a53 ensure class is not nil 2015-08-20 10:55:15 -07:00
Garrett Moon
6624b84c4c Static layout doesn't properly set a height for collection view cells
because their size.width / size.height isn't nan, but FLT_MAX.
2015-08-20 10:40:00 -07:00
ricky cancro
f404231b35 moved baseline alignment to a layout spec. 2015-08-20 10:38:54 -07:00
Andreas Linde
554cdfc2f3 Add OTHER_CFLAG to add bitcode
Without this change bitcode is only actually added when archiving. See http://stackoverflow.com/a/31486233/474794
2015-08-20 16:10:37 +02:00
Andreas Linde
19a6d43571 Add PLCR build with actual bitcode 2015-08-20 16:09:45 +02:00
Andreas Linde
2bff969755 Merge branch 'develop' into feature/iOS9-Updates
Conflicts:
	Support/buildnumber.xcconfig
2015-08-20 15:51:48 +02:00
Andreas Linde
0443e7095c Increase build number 2015-08-20 15:46:24 +02:00
Andreas Linde
7805b8dc0a Merge branch 'release/3.7.2' 2015-08-20 15:31:40 +02:00
Andreas Linde
6f638eda28 Merge tag '3.7.2' into develop
Version 3.7.2
2015-08-20 15:31:40 +02:00
Andreas Linde
b326798969 3.7.2 release and documentation updates 2015-08-20 15:31:25 +02:00
Andreas Linde
dde39be0e6 Fix iTunes Connect error reg. resource bundle
Xcode 7 shows an error when uploading an app to iTunes Connect due to a bug in the Info.plist of the resource bundle. The info.plist shouldn't contain a `CFBundleExecutable` value and the `CFBundlePackageType` should be `BNDL`.

Also removed other non needed entries.
2015-08-20 15:28:38 +02:00
rcancro
e7ffe67e3c new stack layout spec for text 2015-08-19 22:03:02 -07:00
ricky cancro
774d91653b flailing 2015-08-19 16:59:23 -07:00
Andreas Linde
9f8f5146c0 Update readme with extension specific build 2015-08-18 14:39:10 +02:00
Andreas Linde
2ece11d58d Add extension lib to podspec 2015-08-18 14:38:56 +02:00
Andreas Linde
45ec496174 PLCR update
- Update to commit 356901d7f3ca3d46fbc8640f469304e2b755e461 which fixes an issue in iOS 9 Beta on iPad Air 2
- Build with bitcode enabled
- Build with App-Extension-Safe API enabled
2015-08-18 10:52:01 +02:00
Andreas Linde
68f2a66f11 Merge branch 'develop' into feature/iOS9-Updates 2015-08-18 10:40:11 +02:00
Andreas Linde
b791b7640b PLCR update
Update to commit 356901d7f3ca3d46fbc8640f469304e2b755e461 which fixes an issue in iOS 9 Beta on iPad Air 2
2015-08-18 10:39:29 +02:00
Scott Goodson
60cf43766b Revert "Switch to use only layers for offscreen working range window."
There is an unsolved issue with this optimization that may cause crashes
in certain cases.  Reverting until it's properly resolved.  It doesn't
appear to be possible to cause the issue in the test apps used to develop it.

This reverts commit 3f982b5c9a7e4a557c102268f11f71b58085ffef.
2015-08-17 17:19:51 -07:00
appleguy
bd9c9030d9 Merge pull request #610 from SRandazzo/606_sizezero_nil_text
Return CGSizeZero when computing the size of zero-length strings in ASTextNode.
2015-08-17 17:06:54 -07:00
appleguy
977c17b019 Merge pull request #614 from eanagel/reduce-UIColor-AttributedString-calls
Node init performance: Use shares UIColor/NSAttributedString instances
2015-08-17 17:03:11 -07:00
Ethan Nagel
f7fb6dc4e7 Node init performance: Use share instances of UIColor and NSAttributedString for defaults. 2015-08-17 12:23:25 -07:00
Ethan Nagel
5dabd20b54 Merge branch 'master' into ASDisplayNode-init-perf
Conflicts:
	AsyncDisplayKit/ASDisplayNode.mm
2015-08-17 11:46:29 -07:00
Sal
05cb1d734d use attributedString.length instead of attributedString.string.length to check for empty strings 2015-08-16 18:24:20 -04:00
appleguy
3983bf2289 Merge pull request #603 from nguyenhuy/improved_external_relayout
Improve relayout when constrained size of all nodes is changed
2015-08-15 22:07:50 -07:00
appleguy
33912dfc49 Merge pull request #608 from nguyenhuy/preferredFrameSize_bugs
Fix small bugs related to preferredFrameSize
2015-08-15 22:00:54 -07:00
ricky cancro
11896904a2 fixed vertical spacing bug and typo 2015-08-15 09:45:14 -07:00
ricky cancro
d7564e18e5 Added baseline spacing for vertical stack views. 2015-08-15 08:17:43 -07:00