Adlai Holler
fcbbea51a6
Fix the Initialization Hierarchy ( #3207 )
...
* Fix the initializers setup
* Update Swift example
* Remove incorrect comment
* Add one to ASTableNode
2017-03-28 11:48:20 -07:00
Michael Schneider
1f042e960d
[ASNetworkImageNode] Improve locking ( #3187 )
...
* Locking improvements for ASNetworkImageNode
* Fix typo
* Address comments
* Address comments
* Change comment to kick build
2017-03-28 10:42:59 +01:00
Michael Schneider
bc05227631
Check in layout transition if the supernode is still the node that is executing the transition ( #3181 )
...
We have to check in this case if the supernode of the subnode is indeed the _node that executes a layout transition. It can happen that a node already did a layout transition and added this subnode, in this case the subnode would would be removed from the new node instead of _node.
2017-03-15 13:20:01 -07:00
Michael Schneider
e6ee24debc
[ASDisplayNode] Improve locking in ASDisplayNode ( #3172 )
...
* Improve locking in ASDisplayNode
* Address first bunch of comments
* Changed `view` and `layer` methods for locking
* Adress comments
2017-03-14 07:27:34 -07:00
Huy Nguyen
74b9b56632
flexShrinkAdjustment lambda must always return CGFloat ( #3166 )
2017-03-11 06:58:04 -08:00
Adlai Holler
bfe35fc0b1
Add production workaround for missing elements ( #3158 )
2017-03-10 14:35:20 +00:00
Adlai Holler
a0e67a8b15
ASMultidimensionalArrayUtils -> ASTwoDimensionalArrayUtils ( #3157 )
...
* Requery subarray count less in ASMultidimensionalArrayUtils
* Simplify (gut) ASMultidimensionalArrayUtils
* Remove weird change
* Add bounds-checking for graceful failure
2017-03-10 14:33:30 +00:00
Huy Nguyen
18c906aa5c
Some bug fixes for ASStackLayoutSpec: ( #3153 )
...
- Avoid returning a NaN flexShrinkAdjustment.
- Bail early (instead of assert) if a line has a positive `flexFactorSum` but then no flexible item can be found via flex adjustments, for example because the flexible items have zero size.
- Continue flexing other lines when one line is inflexible.
- Add unit test for the first 2 fixes.
2017-03-09 13:35:17 -08:00
Adlai Holler
7ec293d590
Add Validation to ASElementMap to Avoid Crashes in Production ( #3156 )
...
* Add validation to ASElementMap to avoid production crashes
* Only assert sometimes
2017-03-09 12:19:28 -08:00
Huy Nguyen
dd8cac4414
Add a concurrent flag to ASStackLayoutSpec that is off by default ( #3148 )
2017-03-08 16:33:50 +00:00
Adlai Holler
d59ea3902d
Initial Work for Range Controller to Support Supplementary Elements ( #3140 )
...
* Initial work supporting supplementaries in range controller
* Rename indexPathForElementIfItem
2017-03-06 10:11:00 -08:00
Adlai Holler
f5951d906e
Use fast enumeration for ASElementMap enumerating ( #3137 )
2017-03-04 15:18:41 -08:00
Adlai Holler
0de270fdfb
Revert "Improve designated initializer usage ( #3132 )"
...
This reverts commit eaa875c7f2e08afa8b597c653be6b7c45cfff66d.
2017-03-03 15:31:28 -08:00
Michael Schneider
eaa875c7f2
Improve designated initializer usage ( #3132 )
...
* Improve designated initializer usage
* Some more changes
* Add some whitespace
* Fix some warning
2017-03-03 14:49:34 -08:00
Michael Schneider
62d7e14ce1
Improve measurement code for cell nodes ( #3119 )
2017-03-03 09:24:04 -08:00
Adlai Holler
93809bd4e7
Add a Convenience Property to Get Owning View Controller ( #3076 )
...
* Add a convenience property -closestViewController
* Address comments
2017-03-02 11:51:16 -08:00
Huy Nguyen
415005b6fc
ASStackLayoutSpec utilizes multiple threads if it runs on main ( #3116 )
2017-03-02 10:12:53 -08:00
Michael Schneider
67baa44fb5
Fix -Wdocumentation warnings ( #3113 )
2017-03-01 11:25:37 -08:00
Michael Schneider
973630adc6
[ASCellNode] New way to measure ASCellNode's if layout was invalidated ( #3099 )
...
* New way to informing interaction delegate if ASCellNode get’s a setNeedsLayout call
* Remove nodeDidGetNeedsLayout as optional and better check if cell updates need to happen
* Differentiate between letting a normal display node and a cell node know that the size could have changed
* Check for _interactionDelegate is nil
* Add nullability to out pointer
* Adress comments and some renaming
2017-02-27 17:19:01 -08:00
Adlai Holler
25bc97c5c8
Fix Issues Repopulating Supplementary Elements ( #3098 )
...
* Fix issues repopulating supplementary elements
* Remove unrelated change
* Update comments
2017-02-27 16:06:06 -08:00
Huy Nguyen
dc23aca30d
Fix crashes in ASElementMap and ASMutableElementMap ( #3090 )
...
* Fix crashes in ASElementMap and ASMutableElementMap
* testInitialRangeBounds to have a 10% maximum difference
2017-02-27 09:07:23 -08:00
Adlai Holler
73ca6ab514
Shuffle & Cleanup Stuff ( #3080 )
2017-02-26 18:14:13 -08:00
