25 Commits

Author SHA1 Message Date
Hannah Troisi
c857e809f4 Clean up header comments (for consistent Facebook licensing info) (#1741)
[Licensing] Clean up header comments (for consistent Facebook licensing info)
2016-06-11 23:31:39 -07:00
Hannah Troisi
37d4c5e475 Fixing a bug in both debug tools (image scaling, tappable area) in which I don't check that the overlay exists before creating it. 2016-05-15 23:28:39 -07:00
Hannah Troisi
a18ffc64ab [AsyncDisplayKit+Debug.h] Moving hitTestDebug tool code out of ASControlNode and into debug file
- unifying ASControlNode, ASImageNode debugging categories into debug file to simplify base classes
2016-05-15 23:18:46 -07:00
Aaron Schubert
e2fa2f8192 [tvOS] Address comments on previous PR. 2016-04-21 09:23:47 +01:00
Aaron Schubert
06d4573b14 [tvOS] Branch out tvOS specific code into it's own categories 2016-04-21 08:59:14 +01:00
Aaron Schubert
21abe8f899 Fix merge conflicts 2016-04-19 09:02:07 +01:00
Eric Jensen
527397ba7e Replace id with instancetype in initializers 2016-04-13 11:20:05 -07:00
Hannah Troisi
4bd48505af [ASControlNode] hitTestDebug name refactoring 2016-04-10 01:15:15 -07:00
Hannah Troisi
a6f779a7fe [ASControlNode] hitTestDebug tool refactoring + comments:wq 2016-04-10 00:51:36 -07:00
Hannah Troisi
7fa810c77f [ASControlNode] modified hitTestDebug tool vizualize clipping of .clipsToBounds & fixed bug
- added orange overlay edge highlighting if tapable area clipped by .clipsToBounds of any parent in the hierarchy
- fixed bug in comparison of child / parent rect edges
2016-04-10 00:19:00 -07:00
Hannah Troisi
f633f6fff0 [ASControlNode] modify hitTestDebug tool to highlight edges clipped by one or more superviewsw 2016-04-09 21:36:57 -07:00
Adlai Holler
9e56cb553f [ASControlNode] Squash duplicated target-action-event tuples, fix assertion failure removing nil target 2016-04-05 15:51:53 -07:00
Scott Goodson
096df7b385 [ASDisplayNode] Remove #if gating of ASDisplayNode hitTest: (I'd misread this as _ASDisplayView's implementation, and both are needed). 2016-03-28 07:49:14 -07:00
Scott Goodson
cd493358cc [ASControlNode] Upgrades to +setEnableHitTestDebug: to intersect hitTestSlop with parents' bounds+slop, to accurately predict and visualize UIKit event delivery edge cases. 2016-03-27 22:02:13 -07:00
Rahul Malik
4eb3356615 Basic a11y support for ASButtonNode 2016-03-20 19:22:53 -07:00
Eric Jensen
33fda7ab49 - Use modern Objective-C syntax.
-  Simplify comparisons.
-  Remove dead stores.
2016-03-15 22:34:29 -07:00
Scott Goodson
cdd1bd1e39 [ASRangeController] Ensure that visibilityDidChange: is always called on app launch for all initial cells. 2016-03-11 17:18:32 -08:00
Hannah Troisi
9d5fed280d A debug feature on ASControlNode to visualize tap-able areas (by adding a highlight overlay ASDisplayNode as a subnode) when addTarget:action:ControlEvent: is called. Uses hitTestSlop to get ASControlNode's UIEdgeInset and set the highlight overlay's frame to be the ASControlNode frame + edge insets. Disables clip to bounds on ASControlNode. Enabled by calling +[ASControlNode setEnableHitTestDebug:YES]; 2016-03-05 16:08:55 -08:00
Aaron Schubert
3b6ed98e5f Revert unnecessary spacing changes. Improve gating based on feedback. 2016-03-04 08:30:24 +00:00
Aaron Schubert
88e4ec4130 [tvOS] Optimize shadow methods to use local variable. 2016-02-26 09:40:14 +00:00
Aaron Schubert
f9bf402047 [tvOS] Clean up and document parts of code. 2016-02-25 09:06:11 +00:00
Aaron Schubert
d9cde1f08c [tvOS] Added a default touch down animation for ASControlNode 2016-02-23 12:18:33 +00:00
Aaron Schubert
4ad6d91a10 Add default focus response to ASControlNode 2016-02-23 11:16:07 +00:00
Aaron Schubert
5d367328d9 Make ASControlNode the default focusable view. This is so that we can receive touch events that will manipulate the view. 2016-02-23 10:39:32 +00:00
Michael Schneider
ef95394bac Add locking to ASControlNode 2016-02-07 17:18:24 -08:00