54 Commits

Author SHA1 Message Date
Max Gu
13fc13fb56 Removing an unnecessary assertion in ASVideoNode 2016-04-21 15:20:08 -07:00
appleguy
dd4853bf3a Merge pull request #1273 from aaronschubert0/tvOS
[tvOS] Add default focus states to ASControlNode & ASImageNode.
2016-04-20 13:29:31 -07:00
appleguy
966c579d31 Merge pull request #1557 from ejensen/video-player-item-replace
[ASVideoNode] Reuse existing AVPlayer when available
2016-04-19 16:40:03 -07:00
Eric Jensen
4a010337f6 Limit resuming of buffering videos to those that are visible 2016-04-19 13:21:06 -07:00
Eric Jensen
f01ceab3e7 Reuse the existing AVPlayer when it's available in fetchData 2016-04-19 13:04:35 -07:00
Aaron Schubert
21abe8f899 Fix merge conflicts 2016-04-19 09:02:07 +01:00
Eric Jensen
a49d620771 Replace dispatch_async(dispatch_get_main_queue... with ASPerformBlockOnMainThread 2016-04-18 23:08:57 -07:00
Eric Jensen
6a4bc3fd5b Rename setPlaceholderImage to setVideoPlaceholderImage in order to prevent super class setter conflict 2016-04-18 22:30:32 -07:00
Eric Jensen
a2b03d6e90 Change ASContentModeFromVideoGravity's default to UIViewContentModeScaleAspectFit 2016-04-18 22:13:49 -07:00
Eric Jensen
b5c3b15069 Observe playbackLikelyToKeepUp in order to handle player buffer filling and emptying 2016-04-18 22:13:49 -07:00
Eric Jensen
e65d63a502 Simplified and improved video node's handling of state changes:
- Simplified visibility state change handling.
- Placeholder image is now updated after switching assets.
- Improves memory usage by clearing the placeholder image in clearFetchedData.
2016-04-18 22:13:49 -07:00
appleguy
33e36de5dc Merge pull request #1552 from chourobin/feature/hls
[ASVideoNode] Re-enables HLS support
2016-04-18 22:09:43 -07:00
Robin Chou
bdd4baf933 Re-enables HLS support (can't use AVAsset for HTTP live stream media). 2016-04-18 22:38:47 -04:00
Eric Jensen
c1c1358baf Fix video stalling by pausing the video after backgrounding the application 2016-04-18 13:53:43 -07:00
Eric Jensen
983c2f1f49 Replacing ASVideoNode's playButton now cleans-up the previous button's state 2016-04-18 13:53:43 -07:00
Eric Jensen
cdb926c0a1 Correct mismatch between video gravity and placeholder image content mode 2016-04-18 13:53:43 -07:00
Scott Goodson
11744b7f31 [ASVideoNode] Cleanup from recent diffs, standardizing on .asset rather than .url. 2016-04-17 20:12:37 -07:00
Gareth Reese
9e28e07925 ASVideoNode updates based on review comments in https://github.com/facebook/AsyncDisplayKit/pull/1323 2016-04-07 14:08:45 +01:00
Gareth Reese
c8a414be9b Merged branch 'master' into AVPlayerItem-construction 2016-04-06 15:22:10 +01:00
Luke Parham
be463c0a17 muting the video node mutes the player 2016-04-05 02:37:07 -05:00
Eric Jensen
33fda7ab49 - Use modern Objective-C syntax.
-  Simplify comparisons.
-  Remove dead stores.
2016-03-15 22:34:29 -07:00
Gareth Reese
a95300e145 Merged master into AVPlayerItem-construction 2016-03-14 13:21:42 +00:00
Scott Goodson
cdd1bd1e39 [ASRangeController] Ensure that visibilityDidChange: is always called on app launch for all initial cells. 2016-03-11 17:18:32 -08:00
Eric Jensen
7119dc3d59 Correct ASVideoNode's currentItem getter method 2016-03-09 18:54:31 -08:00
Gareth Reese
f7ff8b4173 Updated tests to cover the new API and repeated all of the test logic for URL initialisation to ensure that the functionality is the same 2016-03-08 08:30:13 +00:00
Gareth Reese
fb1c5e8ee6 Fixed an issue where the preview image could appear twice 2016-03-04 16:50:39 +00:00
Gareth Reese
f1ae1cad42 Added some logging for AVPlayerItem error conditions 2016-03-03 14:52:02 +00:00
Gareth Reese
57844cb94d Fixed an issue where the preview image wasn't resizing correctly when the video was playing 2016-03-03 13:39:47 +00:00
Gareth Reese
7c20ba0cdf HLS videos now repeat at the end fine 2016-03-03 13:34:38 +00:00
Gareth Reese
1eebe4d31a Fixed an issue where the preview image doesn't seem to scale with the video layout when you click on the item 2016-03-03 09:46:58 +00:00
Gareth Reese
2e53770d0e Didn't need the relayout 2016-03-02 14:00:25 +00:00
Gareth Reese
4060f40d32 Added preview images for single file URLs. Unfortunately doesn't seem possible for HLS video. 2016-03-02 13:53:19 +00:00
Gareth Reese
6318db45c8 Updated the Videos sample app to cover the API changes 2016-03-01 13:06:29 +00:00
Gareth Reese
f9c8c043a1 First working version for HLS streams 2016-03-01 12:08:09 +00:00
Gareth Reese
75f615b223 Rearranged the method order to put the construction in one place and moved construction of the playerNode to -constructPlayerNode for DRY 2016-03-01 10:25:45 +00:00
Eric Jensen
cb1579e8af Check the AVAsset's type before casting to an AVURLAsset 2016-02-26 11:00:27 -08:00
Aaron Schubert
106b5f5d4a Update 2016-02-23 10:20:06 +00:00
Scott Goodson
0cf972d7ac [ASVideoNode] Remove beta warning in preparation for 1.9.7 launch. 2016-02-17 22:28:12 -08:00
Michael Schneider
545b3e7e5f Rename lock instance variable to be consistent with ASControlNode and ASImageNode lock variable naming 2016-02-07 19:12:02 -08:00
Aaron Schubert
2588721cf0 Gate ASVideoNode for the time being 2016-02-05 14:37:51 +00:00
Luke Parham
2d1499ab4f added muting property and delegate callback to override video tapping 2016-01-29 09:27:48 -08:00
Luke Parham
3b38559c4d added ASDefaultPlayButton, but need to make drawing dynamic so its always a centered circle, also fixed video player preview layer stuff 2016-01-28 01:09:01 -08:00
Luke Parham
526b2ab0cf removed beta range controller 2016-01-24 23:51:34 -06:00
Luke Parham
41721aa42a merged with master 2016-01-24 23:14:43 -06:00
Luke Parham
98fb2e46d4 wip but currently adding first frame as placeholder until it should play and removed extraneous 'pause' 2016-01-24 23:13:17 -06:00
Scott Goodson
2c5db2e335 Podfile bump to 1.9.6; minor preparations for release. 2016-01-23 13:05:27 -08:00
Luke Parham
d9559111a0 renamed nic cage sample, added redundancy for loading player in case its nil when visible, added video tests, disabled assert for new range controller 2016-01-14 02:39:36 -06:00
Luke Parham
6dc15ffd44 added delegate method for video did finish, moved layer creation to after view displays, rearranged spinner logic, added tests 2015-12-22 15:34:11 -06:00
Luke Parham
4602e4e9eb wip fixing pr comments 2015-12-22 02:15:25 -06:00
Luke Parham
901a8fbd98 fixed video tests 2015-12-18 04:47:26 -06:00