2043 Commits

Author SHA1 Message Date
Adlai Holler
99b674c346 Lay some foundation for our new pending state controller 2016-02-20 15:40:47 -08:00
Scott Goodson
d899f12f70 [ASCellNode] Layout delegate should not be public as it must not be reset externally.
Do not call layout delegate method before the cell node is loaded.  This can happen if
application code calls -setNeedsLayout on the cell manually, and can confuse UIKit state
because we submit an empty batch update call on the next runloop.
2016-02-20 15:24:44 -08:00
Scott Goodson
ca8357a364 [AS*ImageNode] dispatch to the background before scheduling image download request (perf). 2016-02-20 13:01:03 -08:00
Scott Goodson
cd6ca2885e [ASButtonNode] lazily initialize label, image, and backgroundImage (skip if never needed). 2016-02-20 13:00:01 -08:00
appleguy
c635ceb9db Merge pull request #1253 from facebook/revert-1249-revert-1247-revert-1171-ASDataController-reload
[ASDataController] Revert the reloadData optimizations again - need to fix apps relying on prior behavior.
2016-02-19 23:28:01 -08:00
appleguy
b75d6627bb Revert "Revert "Revert "[ASCollectionView / ASTableView] Optimize reloadData and reloadSection: methods.""" 2016-02-19 23:26:29 -08:00
appleguy
579965c824 Merge pull request #1252 from facebook/revert-1250-ASDataController-fix
Revert "fix scheduling issue that causes collectionView to not animate"
2016-02-19 23:26:22 -08:00
appleguy
2b10d84a2b Revert "fix scheduling issue that causes collectionView to not animate" 2016-02-19 23:26:12 -08:00
appleguy
f3300ded68 Merge pull request #1246 from Xinchi/master
[ASCellNode] Support monitoring scrollViewDidScroll events / visible amount of self
2016-02-19 22:25:10 -08:00
Max Gu
67c8cd5ccf Removing underscore 2016-02-19 22:21:07 -08:00
Max Gu
548b600504 Removing 2 unnecessary checks 2016-02-19 22:18:08 -08:00
Max Gu
115fc2b3da Adding visibility monitoring for ASTableVieww 2016-02-19 22:15:44 -08:00
Scott Goodson
747447b11d Merge branch 'master' of https://github.com/facebook/AsyncDisplayKit 2016-02-19 21:33:56 -08:00
Scott Goodson
a1061301e0 [ASDataController] Revert the reloadData optimizations again - need to fix apps relying on prior behavior.
The optimization seems correct now, but apps like Pinterest have some core code relying on edit operation
order that is actually not permitted by UIKit (and this diff) but were tolerated previously.  We will
re-land this once we have time to adapt the code.
2016-02-19 21:31:39 -08:00
Max Gu
382509fac8 Letting ASCellNode and its subclasses handle didScroll 2016-02-19 21:30:36 -08:00
Max Gu
53cbd643de Removing ASCellNode+Internal 2016-02-19 14:56:02 -08:00
Max Gu
a834382bcb Update for visibility monitoring 2016-02-19 14:27:22 -08:00
appleguy
3c4ef523a2 Merge pull request #1250 from lkzhao/ASDataController-fix
[ASDataController] fix scheduling issue that causes collectionView to not animate
2016-02-19 13:47:44 -08:00
Max Gu
274029a5e0 Removing an unnecessary property 2016-02-19 13:02:02 -08:00
Max Gu
fa4fc2b6ae Merge remote-tracking branch 'upstream/master' 2016-02-19 12:59:00 -08:00
Max Gu
650b500f92 Merge branch 'master' of https://github.com/Xinchi/AsyncDisplayKit 2016-02-19 12:52:03 -08:00
Max Gu
03446d97e1 Adding scroll visibility 2016-02-19 12:46:12 -08:00
Luke Zhao
6f3d570f13 appleguy's comment 2016-02-19 12:45:43 -08:00
Luke Zhao
e2da2532ce fix tests 2016-02-19 12:12:56 -08:00
Engin Kurutepe
d1793d50c8 fix umbrella header 2016-02-19 14:32:04 +01:00
Luke Zhao
7f57e8cbf4 fix scheduling issue that causes collectionView to not animate 2016-02-19 00:09:21 -08:00
appleguy
df71e04bc9 Merge pull request #1249 from facebook/revert-1247-revert-1171-ASDataController-reload
Revert "Revert "[ASCollectionView / ASTableView] Optimize reloadData and reloadSection: methods.""
2016-02-18 23:06:52 -08:00
appleguy
58a3ba5e8f Revert "Revert "[ASCollectionView / ASTableView] Optimize reloadData and reloadSection: methods."" 2016-02-18 23:06:14 -08:00
appleguy
e44987f293 Merge pull request #1248 from rcancro/currentScaleFactor
[ASTextNode] Properly set and clear the currentScaleFactor
2016-02-18 20:05:10 -08:00
rcancro
a62de38670 currentScaleFactor management 2016-02-18 20:01:23 -08:00
appleguy
73091bcc80 Merge pull request #1247 from facebook/revert-1171-ASDataController-reload
Revert "[ASCollectionView / ASTableView] Optimize reloadData and reloadSection: methods."
2016-02-18 19:50:18 -08:00
appleguy
32aa333c21 Revert "[ASCollectionView / ASTableView] Optimize reloadData and reloadSection: methods." 2016-02-18 19:50:06 -08:00
Max Gu
75eab1db07 Adding scroll visibility 2016-02-18 18:00:37 -08:00
appleguy
33d4c8693d Merge pull request #1171 from lkzhao/ASDataController-reload
[ASCollectionView / ASTableView] Optimize reloadData and reloadSection: methods.
2016-02-18 17:36:14 -08:00
appleguy
9422f92586 Merge pull request #1244 from Adlai-Holler/AHCollectionSectionSideInsets
[ASCollectionView] Always Honor Layout's sectionInset in Both Dimensions
2016-02-18 17:35:41 -08:00
appleguy
7ef1c2989d Merge pull request #1236 from ngleanh/master
[ASMultiplexImageNode] Check loadedImageIdentifer before sending it to delegate
2016-02-18 17:34:52 -08:00
appleguy
3f0b5b5d4e Merge pull request #1245 from rcancro/exposeCurrentScale
Exposing currentScaleFactor
2016-02-18 16:46:08 -08:00
rcancro
2adc30440f Exposing currentScaleFactor 2016-02-18 16:41:58 -08:00
Luke Zhao
cefc985171 reset tests 2016-02-18 16:28:03 -08:00
Luke Zhao
40791dd859 optimize reload data, reload sections, & move nodes performance & logic 2016-02-18 14:44:16 -08:00
Scott Goodson
eeb81a54de [ASDisplayNode+Beta] Expose helper functions, ASPerformBlockOnMainThread & ASPerformBlockOnBackgroundThread. 2016-02-18 13:59:20 -08:00
Adlai Holler
76708c47cf [ASCollectionView] Always honor sectionInset in both dimensions 2016-02-18 09:54:48 -08:00
appleguy
e272dcc21a Merge pull request #1223 from rcancro/fontAdjuster
[ASTextNode] Add support for adjusting font size to make text fit within constrained size without truncating.
2016-02-17 22:55:24 -08:00
appleguy
c526fcdff4 Merge pull request #1239 from rahul-malik/rmalik-concurrent-alloc
[ASDataController] Concurrent allocation of ASCellNodes
2016-02-17 22:53:35 -08:00
Rahul Malik
19cc368d15 In addition to allocating nodes in the background, perform that operation concurrently in ASDataController 2016-02-17 22:30:58 -08:00
Scott Goodson
0cf972d7ac [ASVideoNode] Remove beta warning in preparation for 1.9.7 launch. 2016-02-17 22:28:12 -08:00
Scott Goodson
4a37b0882e [ASCollectionView] iOS 7-only issue where willDisplayCell: is not called, fixed for only that OS version.
This includes some method moves to make sure related methods are in closer proximitiy.
2016-02-17 22:21:46 -08:00
rcancro
070982a50b fixed tests??? (it did locally anyway) 2016-02-17 13:08:16 -08:00
Anh Nguyen
8d603bf5e6 Check loadedImageIdentifer before sending it to delegate 2016-02-17 16:49:15 +07:00
appleguy
205feef58c Merge pull request #1235 from Adlai-Holler/AHSynchronousImageLoadingPath
[ASNetworkImageNode] Provide Synchronous Loading Path on Cache Hits
2016-02-16 23:47:02 -08:00