2043 Commits

Author SHA1 Message Date
Ethan Nagel
baf91b4a45 validate that _pendingVisibleIndexPath is contiguous with visibleIndexPaths before appending it. Also, always return a sorted array of NSIndexPaths 2015-06-24 13:18:12 -07:00
Ethan Nagel
0e37bff7c1 Revert to using a single NSIndexPath for the pending visible item 2015-06-24 13:13:43 -07:00
Victor Mayorov
a299a5b550 Implemented UIAccessibilityIdentification for ASDisplayNode 2015-06-24 11:03:51 -07:00
Victor Mayorov
1a7723d0c6 Merge remote-tracking branch 'AsyncDisplayKit/master'
Conflicts:
	AsyncDisplayKit/Details/ASRangeController.mm
	AsyncDisplayKitTests/ASTableViewTests.m
2015-06-24 10:19:41 -07:00
Sebastian Rehnby
c215356eb3 Include missing files in iOS Framework target 2015-06-24 15:55:50 +02:00
Paul Young
8fa6667d93 Remove old and add new framework target. 2015-06-23 23:24:55 -07:00
appleguy
8bdcbe1be0 Merge pull request #504 from RCacheaux/CollectionViewLayoutSupport
Custom layouts now allowed for ASCollectionView. Removes FlowLayout requirement.
2015-06-23 13:22:26 -07:00
Rene Cacheaux
0b8f10e488 Removes UICollectionViewFlowLayout requirement. This allows custom collection view layouts. 2015-06-23 13:39:12 -05:00
appleguy
e5f2f820c4 Merge pull request #449 from nrcmedia/master
Added iOS framework target for Carthage support
2015-06-23 10:51:23 -07:00
appleguy
247f960c44 Merge pull request #503 from RCacheaux/CollectionViewLayoutSupport
Create ASCollectionViewLayoutController capable of handling any type of UICollectionViewLayout.
2015-06-23 10:30:19 -07:00
Rene Cacheaux
60e676a38a Adds ASCollectionViewLayoutController and convenience CGRect/ASScrollDirection functions. Fixes default collection view range tuning parameters for Preload and Render ranges; values were flipped. 2015-06-23 07:30:13 -05:00
appleguy
179d8601e0 Merge pull request #497 from RCacheaux/CollectionViewLayoutSupport
Adds abstract ASLayoutController, consolidating shared behaviors
2015-06-22 21:50:52 -07:00
Rene Cacheaux
4aa796d894 Merge branch 'master' into CollectionViewLayoutSupport 2015-06-21 23:17:41 -05:00
appleguy
607367aacf Merge pull request #496 from facebook/DataControllerCrash
Improvements to thread safety during closely spaced edit events.
2015-06-21 21:16:05 -07:00
appleguy
edb6090ab0 Merge pull request #494 from RCacheaux/CollectionViewLayoutSupport
ASCollectionView scrollDirection and scrollableDirections
2015-06-21 21:10:14 -07:00
Scott Goodson
c700618862 Improvements to thread safety during closely spaced edit events.
This applies primarily when beginUpdates / endUpdates is not used.
Due to user interaction-driven edits, like reloads or adding content
at the bottom, sometimes this is unavoidable in app design and thus
critical.

I have a diff in flight to make ASDataController / ASRangeController
robust against very aggressive thrash testing, which will be added
both to the unit test suite and this new example project.
2015-06-21 21:04:09 -07:00
appleguy
84c81c289e Merge pull request #495 from hannahmbanana/KittenComments
Cleaned up Kittens sample app and added comments for clarity.
2015-06-21 17:32:31 -07:00
Rene Cacheaux
777b48cc33 Adds layout controller for collection views. This new layout controller leverages UICollectionViewLayout's layoutAttributesForElementsInRect in order to calculate index paths for items in AsyncDisplayKit ranges. Flow layout is still a requirement in order to test the waters. 2015-06-21 18:37:00 -05:00
Hannah Troisi
710c51593e Cleaned up Kittens sample app and added comments for clarity.
In particular, the NSValue-boxed CGSize array used as a data model for the kittens
is generated with random sizes, for unclear reasons.  It turns out this is a workaround
to convince PlaceKitten to send us unique images.
2015-06-21 11:36:19 -07:00
Rene Cacheaux
0adac6851a Adds abstract ASLayoutController implementation in preparation for custom layout ASLayoutController implementation. 2015-06-21 13:24:24 -05:00
Rene Cacheaux
33118df73b Merge branch 'master' into CollectionViewLayoutSupport 2015-06-21 11:45:56 -05:00
Rene Cacheaux
e46c13edc5 Exposes ASCollectionView's ability to determine scroll direction. Scroll direction detection can now support 2-axis collection view layouts. ASCollectionView can now determine scrollable axes. 2015-06-21 11:45:25 -05:00
appleguy
ed4ccfcc7f Merge pull request #491 from RCacheaux/CollectionViewLayoutSupport
Custom Collection view layout prep PR
2015-06-20 20:18:54 -07:00
appleguy
c12cbdd21a Merge pull request #493 from facebook/LayerDrivenLayout
Remove -[_ASDisplayView layoutSubviews] and use only -[_ASDisplayLayer layoutSublayers]
2015-06-20 20:16:13 -07:00
Scott Goodson
904905189c Remove -[_ASDisplayView layoutSubviews] and use only -[_ASDisplayLayer layoutSublayers].
This helps us support special cases such as ASScrollNode correctly driving the -layout
method for subclasses even though it is based on UIScrollView & can't use _ASDisplayView.

I suspect this will be useful for ASCollectionNode and ASTableNode as well, which would
allow nesting those classes inside of other collections / tables (e.g. horizontal
unit within a vertical unit).
2015-06-20 19:40:01 -07:00
Rene Cacheaux
a7f7620b8c Turns ASScrollDirection into Option set in preparation for supporting 2-axis collection view layouts. Clears test host target warnings. 2015-06-20 18:25:48 -05:00
appleguy
c271462b16 Merge pull request #488 from facebook/CleanupFrameSetter
Clean up logic in setFrame: for clarity and compactness
2015-06-19 17:36:17 -07:00
Victor Mayorov
b94640a59d Merge remote-tracking branch 'AsyncDisplayKit/master' 2015-06-19 12:38:01 +03:00
Victor Mayorov
503b16fd62 Fixed crash on multiple -[ASTableView reloadData]. Implemented test. 2015-06-19 12:37:38 +03:00
Scott Goodson
b4aaf50953 Clean up login in setFrame: for clarity and compactness 2015-06-18 13:16:35 -07:00
appleguy
590063f421 Merge pull request #485 from victormayorov/master
Fixed bounds in ASDisplayNode
2015-06-18 13:05:24 -07:00
Victor Mayorov
0c7b1051d6 Fixed bounds 2015-06-15 18:35:32 +03:00
Victor Mayorov
e94699ae31 Fixed bounds in ASDisplayNode. Bounds.origin shouldn't be affected by -[ASDisplayNode setFrame:] method. 2015-06-15 18:30:44 +03:00
appleguy
66e241162f Merge pull request #483 from facebook/podfileUpdates
Update .podspec to refer to 1.2.1 release tag.
2015-06-14 20:09:57 -07:00
Scott Goodson
d8fcfce840 Update .podspec to refer to 1.2.1 release tag. 2015-06-14 20:08:54 -07:00
appleguy
80cc0e64d0 Merge pull request #482 from facebook/DisableAsyncDataFetching
Disable asyncDataFetching in ASTableView and ASCollectionView init
2015-06-14 20:01:56 -07:00
Scott Goodson
ba5a6e15c0 Disable asyncDataFetching in ASTableView and ASCollectionView init methods.
It's currently unreliable for some use cases that issue editing calls while
content is displayed or being interacted with.  The performance gain is not
sufficient to sacrifice correctness for the clients that hit this issue,
so it will remain off until fully resolved.
2015-06-14 19:59:39 -07:00
appleguy
a4a03fdcf4 Merge pull request #481 from facebook/PrecompositingOpacity
Support transparent (e.g. clearColor) background for precomposited trees.
2015-06-14 17:32:09 -07:00
Scott Goodson
c50f3b9cad Support transparent (e.g. clearColor) background for precomposited trees. 2015-06-14 17:30:42 -07:00
appleguy
2a7f45ed40 Merge pull request #479 from joostvandijk/rasterized-node-offset
Fix offset issue for rasterized nodes
2015-06-13 17:35:55 -07:00
Joost van Dijk
bd7941507b Use a zero origin for root container node frame during rasterization 2015-06-13 20:51:58 +02:00
appleguy
4ddd1f4ace Merge pull request #478 from victormayorov/master
Fixed crash in ASNetworkImageNode.
2015-06-13 11:13:24 -07:00
VictorM
645b3c1e4a Added tests to project file 2015-06-11 10:47:13 +03:00
VictorM
2c74904368 Fixed crash with deallocated CGImageRef 2015-06-11 10:42:28 +03:00
appleguy
c1f3ce2ba9 Merge pull request #476 from victormayorov/master
Fixed ASBasicImageDownloader to handle multiple requests with the same…
2015-06-10 16:52:16 -07:00
Victor Mayorov
9c20edb310 Added checking that sessionTask hasn't been added during creation of previous one 2015-06-10 17:58:35 +03:00
Victor Mayorov
7359e2255d Added synchronisation for sessionTask property 2015-06-10 17:50:21 +03:00
Victor Mayorov
1f5813b835 Fixed typo 2015-06-10 16:19:54 +03:00
Victor Mayorov
7167e4a589 Fixed ASBasicImageDownloader to handle multiple request with the same URL 2015-06-10 15:38:51 +03:00
Niels van Hoorn
b8f60e126a Added iOS framework target for Carthage support 2015-06-09 09:16:06 -07:00