Kevin
4c370a899c
[Updated Snapshots] Don't add extraneous truncation token during kCTLineTruncationMiddle ( #1375 )
...
* Don't add extraneous truncation token during kCTLineTruncationMiddle
* Expand these comments a little.
* Update snapshot tests with beautiful correct behavior
2019-03-07 07:20:06 -08:00
Kevin
9428fd4b9c
Add some snapshot tests for ASTextNode2 truncation modes. ( #1296 )
...
* Add some snapshot tests for ASTextNode2 truncation modes
* Allow some tolerance in snapshots
* Express tolerance percentage correctly
* Code review comments: Move class methods up, combine declaration&initializaiton lines
* Give png files clearer names
* Oops
2019-01-16 18:26:05 -08:00
Eric Jensen
5f912d1cd1
Remove double scaling of lineHeightMultiple & paragraphSpacing attributes in ASTextKitFontSizeAdjuster ( #1056 )
2018-08-15 11:08:32 -07:00
Michael Schneider
9e2947e7fb
Revert "Optimize drawing code + add examples how to round corners ( #996 )" ( #1055 )
...
This reverts commit eb4c21c54540d2c1c0b63a6b0665a77fea810e6c.
2018-07-31 04:40:18 -07:00
Michael Schneider
eb4c21c545
Optimize drawing code + add examples how to round corners ( #996 )
...
* Use CoreGraphics for drawing and cropping of node content
* Smaller fixes
2018-07-26 09:44:10 -07:00
Max Wang
9fe2f476a1
add ASTextNode2 snapshot test ( #935 )
...
* fix SIMULATE_WEB_RESPONSE not imported #449
* Fix to make rangeMode update in right time
* remove uncessary assert
* textnode2-snapshot-test
* add change log
* fix image recording
* disable recording
* renaming test method
* reset experiment in teardown
2018-06-02 09:01:01 -07:00
Adlai Holler
6f1d2d1f1d
[ASTextNode] Fix locking, add test for issue #trivial ( #825 )
...
* A few small fixes plus a failing test for ASTextNode
* Change the approach
* Update changelog
* Eh screw null_resettable
* No need for changelog now
2018-03-09 14:23:27 -08:00
huang-kun
e4b2c05c21
[ASCornerLayoutSpec] New layout spec class for declarative corner element layout. ( #657 )
...
* Add new layout spec class with snapshot testing. Update examples and CHANGELOG.md
* Code review updates.
* Open curly bracket in a new line.
2017-11-24 13:45:59 +00:00
Huy Nguyen
421a896713
Clean up snapshot test cases ( #3091 )
...
* Clean up snapshot test cases:
- Drop 32bit snapshots
- Update iOS 9 snapshots and move some others to the correct directory
- Remove `setUp` overrides in subclasses of `ASLayoutSpecSnapshotTestCase` that set `recordMode` flag. Doing so in multiple places make it difficult to enable/dis
able the flag for all layout spec test cases. It can always be overridden locally if need
to.
- Fix BUCK build
* Fix testThatOnDidLoadThrowsIfCalledOnLoadedOffMain of ASDisplayNodeTests
2017-02-27 09:14:40 -08:00
Adlai Holler
73ca6ab514
Shuffle & Cleanup Stuff ( #3080 )
2017-02-26 18:14:13 -08:00
