Huy Nguyen
7a11c4b32b
Fix recursive description of ASDisplayNode ( #3186 )
...
- Before this commit:
- Bridged properties are accessed to construct a recursive description without considering thread affinity.
- We have multiple methods that does the same thing: generates a debug description.
- After this commit:
- Bridged properties are accessed without triggering thread affinity assertions.
- We have only one method that provides debug description of a node. It is then used to construct a recursive description.
2017-03-15 18:20:19 +00:00
Michael Schneider
ef2ed54d0b
[ASDisplayNode] Add locking to view and layer in ASDisplayNode ( #3179 )
...
* Add locking to view and layer in ASDisplayNode
* Another approach
* Some more
* Address comments
2017-03-15 09:05:38 -07:00
Peter
7617b9a9f3
Merge commit 'e6ee24debcae89bd0066061b42ad1a6a73da9486'
...
# Conflicts:
# Source/ASDisplayNode.mm
# Source/ASImageNode.mm
# Source/Details/ASCollectionViewLayoutController.mm
2017-03-15 13:31:39 +03:00
Michael Schneider
e6ee24debc
[ASDisplayNode] Improve locking in ASDisplayNode ( #3172 )
...
* Improve locking in ASDisplayNode
* Address first bunch of comments
* Changed `view` and `layer` methods for locking
* Adress comments
2017-03-14 07:27:34 -07:00
Huy Nguyen
21953c97ef
-actionForLayer:forKey: of ASDisplayNode should return nil to avoid the node being animated by CA when it's being moved from one supernode to another ( #3146 )
...
This reverts commit 1d21c0bd5545741f284e553d7ed003c69fa6897c introduced in #3063 .
2017-03-08 14:02:12 +00:00
Michael Schneider
cbd8714260
Fix crashes while subclassing ASDisplayNode and subclasses in Swift ( #3143 )
2017-03-07 07:36:08 -08:00
Peter
bb8cf51d7a
no message
2017-03-06 02:08:37 +03:00
Adlai Holler
0de270fdfb
Revert "Improve designated initializer usage ( #3132 )"
...
This reverts commit eaa875c7f2e08afa8b597c653be6b7c45cfff66d.
2017-03-03 15:31:28 -08:00
Michael Schneider
eaa875c7f2
Improve designated initializer usage ( #3132 )
...
* Improve designated initializer usage
* Some more changes
* Add some whitespace
* Fix some warning
2017-03-03 14:49:34 -08:00
Michael Schneider
62d7e14ce1
Improve measurement code for cell nodes ( #3119 )
2017-03-03 09:24:04 -08:00
Michael Schneider
62c5138676
[ASDisplayNode] Fix node is showing up as black box if wrapping an UIActivityIndicatorView ( #3121 )
...
* Set the node to not opaque if it’s wrapping an UIActivityIndicatorView
* Add check for subclass of UIVisualEffectView to see if the node needs to be opaque
2017-03-02 08:57:17 -08:00
Michael Schneider
67baa44fb5
Fix -Wdocumentation warnings ( #3113 )
2017-03-01 11:25:37 -08:00
Garrett Moon
06b0cba68d
It doesn't appear that this method needs to be protected by thread affinity? It has locking and is backed by an ivar, not UIKit. ( #3107 )
2017-03-01 10:57:18 -08:00
Peter
d1ab6976b5
Merge commit 'a08d9dc7328bef8cfc1b50b36cc05edb09af25a3'
...
# Conflicts:
# AsyncDisplayKit.xcodeproj/project.pbxproj
# AsyncDisplayKit/ASPagerFlowLayout.m
# AsyncDisplayKit/AsyncDisplayKit.modulemap
# AsyncDisplayKit/Details/ASCollectionDataController.h
# AsyncDisplayKit/Details/ASCollectionDataController.mm
# AsyncDisplayKit/Details/ASDataController.mm
# AsyncDisplayKit/Private/ASDataController+Subclasses.h
# AsyncDisplayKit/module.modulemap
# Source/Debug/AsyncDisplayKit+Debug.h
# Source/Details/ASCollectionElement.mm
# Source/module.modulemap
2017-03-01 15:57:40 +04:00
Michael Schneider
973630adc6
[ASCellNode] New way to measure ASCellNode's if layout was invalidated ( #3099 )
...
* New way to informing interaction delegate if ASCellNode get’s a setNeedsLayout call
* Remove nodeDidGetNeedsLayout as optional and better check if cell updates need to happen
* Differentiate between letting a normal display node and a cell node know that the size could have changed
* Check for _interactionDelegate is nil
* Add nullability to out pointer
* Adress comments and some renaming
2017-02-27 17:19:01 -08:00
Adlai Holler
73ca6ab514
Shuffle & Cleanup Stuff ( #3080 )
2017-02-26 18:14:13 -08:00
