1777 Commits

Author SHA1 Message Date
Garrett Moon
5c2690e7e9 set reformed progress block to nil if progress block is nil 2016-02-09 14:24:05 -08:00
Garrett Moon
48fc4810cd Addressing comments 2016-02-09 14:06:41 -08:00
appleguy
cae47e23e1 Merge pull request #1201 from maicki/ASRangeControllerCleanup
[ASRangeController] Remove deprecated range controller implementation that is no longer used.
2016-02-09 12:23:44 -08:00
Garrett Moon
820390e496 Fix build and podfile 2016-02-09 10:31:10 -08:00
appleguy
914d6e7dc9 Merge pull request #1200 from maicki/ASVideoNodeLockRename
[ASVideoNode] Rename lock instance variable
2016-02-08 23:47:09 -08:00
appleguy
c1c9981408 Merge pull request #1199 from maicki/ASControlNodeLocking
[ASControlNode] Add locking for event dispatch table.
2016-02-08 22:29:43 -08:00
Garrett Moon
0be51c1ca2 Leave ASBasicImageDownloader alone. 2016-02-08 16:30:34 -08:00
Garrett Moon
5a4e4dcac4 Add default PINRemoteImageDownloader 2016-02-08 16:00:19 -08:00
Michael Schneider
28207c678d Remove ASRangeHandler protocol with all classes that implement it
With the move to the new ASRangeController we don't need the ASRangeHandler protocol anymore
2016-02-08 12:57:05 -08:00
Huy Nguyen
8dc576fed7 Remove .ASVideoNode.mm.un~ 2016-02-08 10:13:18 -08:00
Michael Schneider
545b3e7e5f Rename lock instance variable to be consistent with ASControlNode and ASImageNode lock variable naming 2016-02-07 19:12:02 -08:00
Michael Schneider
ef95394bac Add locking to ASControlNode 2016-02-07 17:18:24 -08:00
Michael Schneider
fa2a058585 Rename ASCollectionViewLayoutControllerBeta to ASCollectionViewLayoutController 2016-02-07 15:27:45 -08:00
Michael Schneider
e49a5d992c Remove unused ASCollectionViewLayoutController import 2016-02-07 15:27:15 -08:00
Michael Schneider
03536ddefd Remove shouldUpdateForVisibleIndexPaths
This method can be removed as ASRangeControllerBeta is the main ASRangeController now
2016-02-07 15:03:24 -08:00
Michael Schneider
026761c610 Rename ASRangeControllerBeta to ASRangeController and use exclusively 2016-02-07 15:03:24 -08:00
Michael Schneider
5d474bcb1a Remove ASDisplayNode -shouldUseNewRenderingRange method and ASRangeControllerStable class 2016-02-07 15:03:23 -08:00
appleguy
06bdcd0049 Merge pull request #1192 from garrettmoon/updateASTextNodeDocumentation
[ASTextNode] Indicate that truncation mode is overridden by attributes in attributedString
2016-02-06 17:43:36 -08:00
Scott Goodson
9e87813425 Micro-optimizations in ASDisplayNode that help reduce overhead when recursing large hierarchies. 2016-02-05 21:43:14 -08:00
Rahul Malik
5c86eafe8f Add node-block api to ASPagerNodeProxy 2016-02-05 15:59:07 -08:00
Rahul Malik
6c240a2fce ASPagerNode's api was not updated while addressing comments on the initial
ASCellNode background allocation PR. This change fixes that issue.
2016-02-05 15:09:08 -08:00
Garrett Moon
d6c06ab0bd Indicate that truncation mode is overridden by attributes in attributedString 2016-02-05 14:08:49 -08:00
appleguy
8abda67d1a Merge pull request #1185 from garrettmoon/addContentInsetToButtonNode
[ASButtonNode] Add support for contentInset and make it bit more threadsafe
2016-02-05 11:59:20 -08:00
Connor Montgomery
800aa05c35 Revert "Merge pull request #1162 from maicki/controlnode-init-optimization"
This reverts commit 35a4b268d64e922b3928f247614b664a9413ad3b, reversing
changes made to 4201df5f31077ea31bf014fc01828c065bd31c1c.
2016-02-05 13:49:00 -05:00
Scott Goodson
454d68516b Remove overly-cautious thread affinity assertions for threadsafe properties. 2016-02-04 19:44:44 -08:00
Garrett Moon
64f36d4499 Add support for contentInset and make ASButtonNode a bit more threadsafe 2016-02-04 17:40:16 -08:00
Huy Nguyen
a9d91957b6 Fix ASRangeControllerBeta causing build errors 2016-02-04 17:29:36 -08:00
appleguy
1655d0a0c7 Merge pull request #1178 from nguyenhuy/range_tuning_params_follow_up
More on range mode and range controller
2016-02-04 16:59:42 -08:00
Rahul Malik
c4f489b074 Address comments. 2016-02-04 16:56:29 -08:00
Huy Nguyen
a7df20d120 Update range mode selection logic in ASRangeControllerBeta 2016-02-04 16:54:31 -08:00
Huy Nguyen
79f7450742 ASPagerNode less aggressively pre-renders 2016-02-04 16:53:53 -08:00
Huy Nguyen
e5e34313ed ASRangeController (stable) doesn't handle visible range now because the range is gone 2016-02-04 16:52:33 -08:00
Huy Nguyen
dc93192b87 Address Levi' comment: better method name in ASRangeControllerBeta 2016-02-04 16:52:33 -08:00
Huy Nguyen
8c83e1a78a Avoid asking for interface state multiple times in ASRangeControllerBeta 2016-02-04 16:52:33 -08:00
Huy Nguyen
f09024556b Switch to minimum mode when the node is no longer visible 2016-02-04 16:52:33 -08:00
Huy Nguyen
260879db7d Improve documentation of ASLayoutRangeMode 2016-02-04 16:52:33 -08:00
Huy Nguyen
b3b28b0df9 Reuse visible index paths of when tuning params of a certain range type is zero 2016-02-04 16:52:30 -08:00
Huy Nguyen
175b9da251 Remove visible range type 2016-02-04 15:44:47 -08:00
Huy Nguyen
4cf0e3e380 Update range tunining params for ASPagerNode 2016-02-04 15:44:47 -08:00
Huy Nguyen
fda9efafa6 Add timestamp to notifications of rendering engine and avoid race conditions in ASRangeControllerBeta
- Accurately remove notification observer
2016-02-04 15:44:44 -08:00
Huy Nguyen
3c135788cb Less work when RangeControllerLoggingEnabled is false 2016-02-04 14:15:07 -08:00
Rahul Malik
521c3fa1c1 Move ASCellNode allocation off the main thread by the addition of a node block
API in ASDataController. Move allocations and loaded node layouts to occur
during batch layout phase.
2016-02-04 10:38:59 -08:00
appleguy
35a4b268d6 Merge pull request #1162 from maicki/controlnode-init-optimization
[ASControlNode] Optimize init method - avoid creating ASPendingState if possible (subclassed by button, text, image nodes)
2016-02-03 22:38:23 -08:00
Levi McCallum
cd94df1106 Wrap implicit hierarchy management behind beta feature flag 2016-02-03 20:08:30 -08:00
appleguy
6d11df735b Merge pull request #1163 from nguyenhuy/range_tuning_params
Range controller automatically extends to full mode
2016-02-03 19:09:32 -08:00
Michael Schneider
597aa02c8e Remove target added state and and instead check _controlEventDispatchTable if a target was added 2016-02-03 18:53:20 -08:00
Garrett Moon
1b08114eca Allow prevention of downscaling 2016-02-02 19:10:12 -08:00
Huy Nguyen
19335d8c9e Add rangeMode APIs 2016-02-02 11:58:18 -08:00
Michael Schneider
12e2b535db Use instance variable for tracking if a target was added to ASControlNode 2016-02-02 08:30:52 -08:00
Huy Nguyen
69e674c1c8 Range controller registers to rendering engine and extern to full range if needed 2016-02-02 01:23:04 -08:00