appleguy
30463db034
Merge pull request #1326 from maicki/ASViewControllerFixContentInset
...
[ASViewController] Trigger measurement pass at viewWillAppear: to ensure implicit hierarchy operations complete in time for UIKit inset configuration.
2016-03-04 19:24:37 -08:00
Michael Schneider
15a789c719
Fix content inset problems if ASViewControllers root node has usesImplicitHierarchyManagement set to YES
...
There are content inset problems if a ASViewController is initialized with a root node (e.g a ASCollectionNode subclass) that has usesImplicitHierarchyManagement set to YES. The reason for that is that the subviews (e.g. the UICollectionView) of the ASViewController root node get's added to the view hierarchy in measureWithSizeRange: in ASDisplayNode. measureWithSizeRange: of the root node is called in -viewWillLayoutSubviews in ASViewController. That is too late, so UIKit does not apply the automatic content inset to the UICollectionView anymore.
2016-03-04 19:22:09 -08:00
appleguy
0a76c7b5d2
Merge pull request #1301 from lkzhao/collectionView-sectionInset-fix
...
Remove cell constrainedSize adjustment with section insets in constrainedSizeForNode
2016-03-04 14:26:55 -08:00
appleguy
17078bc208
Merge pull request #1316 from levi/patch-7
...
Add direct implementation of endUpdatesAnimated to ASCollectionNode
2016-03-04 14:26:30 -08:00
appleguy
28e505e9bd
Merge pull request #1324 from maicki/ASCollectionNodeInitializeWithFrame
...
Initialize the ASCollectionView with a given frame and not with CGRectZero by default
2016-03-04 14:25:50 -08:00
Michael Schneider
d19a55f94c
Initialize the ASCollectionView with a given frame and not with CGRectZero by default
2016-03-04 14:21:33 -08:00
Luke Zhao
aa180c6f3b
completely remove cell constrainedSize adjustment from section inset
2016-03-04 13:14:16 -08:00
appleguy
b45d34a96d
Merge pull request #1320 from facebook/ASVCFrame
...
[ASViewController] Call -[super loadView] in order to harvest frame v alue and apply it to node's view.
2016-03-03 18:09:39 -08:00
Scott Goodson
23cd4c2b1f
Merge remote-tracking branch 'origin/ASVCFrame' into ASVCFrame
...
Conflicts:
AsyncDisplayKit/ASViewController.m
2016-03-03 18:08:44 -08:00
Scott Goodson
2a5464356f
[ASViewController] Call -[super loadView] in order to harvest frame value and apply it to node's view.
2016-03-03 18:07:47 -08:00
Scott Goodson
5687c651bc
[ASViewController] Call -[super loadView] in order to harvest frame value and apply it to node's view.
2016-03-03 18:04:05 -08:00
appleguy
39786f0691
Merge pull request #1319 from nguyenhuy/async_layout_transition_fixes
...
Fix threadSafeBounds
2016-03-03 16:24:47 -08:00
Huy Nguyen
caddd1d287
Fix threadSafeBounds
...
- Bounds change set directly to _ASDisplayLayer should also be saved to threadSafeBounds
- Remove overkill _usesDisplayView flag
2016-03-03 16:18:07 -08:00
appleguy
3b4118cc6e
Merge pull request #1318 from nguyenhuy/async_layout_transition_fixes
...
Fix race conditions during async layout transition
2016-03-03 15:49:26 -08:00
Huy Nguyen
3b0b7fa888
More locks
2016-03-03 15:05:17 -08:00
Levi McCallum
79d593f344
Update header file
2016-03-03 15:00:29 -08:00
Levi McCallum
66133f7e98
Add direct implementation of endUpdatesAnimated to ASCollectionNode
2016-03-03 14:56:36 -08:00
appleguy
0d2fbdf19f
Merge pull request #1313 from levi/patch-6
...
[ASDisplayNode] Transition API - Preserve usesImplicitHierarchyManagement when doing animations
2016-03-03 12:17:14 -08:00
appleguy
00719fbaf8
Merge pull request #1314 from nguyenhuy/async_layout_transition
...
Finish replacing bounds with threadSafeBounds in ASTextNode
2016-03-03 09:24:43 -08:00
Huy Nguyen
5154573ae7
Finish replacing bounds with threadSafeBounds in ASTextNode
2016-03-03 08:51:44 -08:00
Levi McCallum
4601cd5d1e
Preserve usesImplicitHierarchyManagement when doing animations
...
Currently the flag was being reset to NO in all cases. It should ignore turning off the hierarchy management when the user has already enabled it.
2016-03-03 08:40:08 -08:00
appleguy
f27ea719da
Merge pull request #1312 from nguyenhuy/async_layout_transition
...
Follow-up on 1311
2016-03-03 00:35:47 -08:00
Huy Nguyen
b21974e3f4
Address Scott's comment
2016-03-03 00:33:19 -08:00
Huy Nguyen
f59eb98749
Remove threading assumption in ASDisplayNode measureWithSizeRange:"
2016-03-03 00:31:05 -08:00
appleguy
531052157a
Merge pull request #1311 from nguyenhuy/async_layout_transition
...
[ASDisplayNode] Support measureWithSizeRange: on background, and seamless layout spec animation after complete.
2016-03-02 22:57:49 -08:00
Huy Nguyen
5e49cc4382
Layout transition can measure in background
2016-03-02 22:47:04 -08:00
Huy Nguyen
9162d7b2df
Implement thread-safe bounds and use it in ASTextNode
2016-03-02 22:42:53 -08:00
Scott Goodson
cc07d77d68
[ASViewController] Ensure we retain a reference to the UIVC object returned by the initWithViewController: block.
2016-03-02 22:38:56 -08:00
appleguy
edd567a91d
Merge pull request #1310 from maicki/UpdateCommittedAPI
...
[ASCollection/TableView] Add -waitUntilAllUpdatesAreCommitted to wait for concurrent measurement to finish
2016-03-02 20:19:19 -08:00
Michael Schneider
f2f1b25ae4
Rename _batchUpdateCounter to _changeSetBatchUpdateCounter in ASChangeSetDataController
...
Rename variable to prevent confusion between the _batchUpdateCounter variable of ASChangeSetDataController and it's superclass
2016-03-02 19:38:14 -08:00
Michael Schneider
aa2ae87c81
Add -waitUntilAllUpdatesAreCommitted to ASTableView and ASCollectionView
...
The API allows consumer of ASTableView or ASCollectionCiew to block execution of the main thread until all section and row updates are committed.
2016-03-02 19:38:14 -08:00
appleguy
e82d1408d2
Merge pull request #1292 from nguyenhuy/visibility_improvements
...
[ASCellNode] Update visibility API to support new event types for initial visibility & invisibility (caused by VC transitions, etc)
2016-03-02 19:30:31 -08:00
appleguy
a06c67f027
Merge pull request #1306 from facebook/TransactionLockingAndAssertion
...
[_ASAsyncTransaction] Reduce locking overhead by removing C++ stack-allocated MutexLocker objects.
2016-03-02 17:03:57 -08:00
appleguy
6676fc56a2
Merge pull request #1308 from maicki/ShowStatusbarInExamples
...
Show status bar in examples
2016-03-02 14:54:14 -08:00
appleguy
2fbcf53af9
Merge pull request #1307 from maicki/ASMultiplexImageNodeImageDeallocationImprovement
...
[ASMultiplexImageNode] Deallocate image on background thread
2016-03-02 14:53:39 -08:00
Scott Goodson
41a4e6734e
Merge branch 'TransactionLockingAndAssertion' of https://github.com/facebook/AsyncDisplayKit into TransactionLockingAndAssertion
2016-03-02 14:49:25 -08:00
Scott Goodson
ee524f497d
[_ASAsyncTransaction] Reduce locking overhead by removing C++ stack-allocated MutexLocker objects.
...
Support assertion to log specific return value for pthread_mutex_destroy failures.
2016-03-02 14:49:02 -08:00
Michael Schneider
9291372c7f
Show status bar in examples
2016-03-02 06:53:55 -08:00
Michael Schneider
3c32c48be0
Add clear image to ASMultiplexImageNode
2016-03-02 06:14:35 -08:00
Scott Goodson
783c2b03c7
[_ASAsyncTransaction] Reduce locking overhead by removing C++ stack-allocated MutexLocker objects.
...
Support assertion to log specific return value for pthread_mutex_destroy failures.
2016-03-01 22:06:46 -08:00
appleguy
f4925a107c
Merge pull request #1302 from nguyenhuy/fix_collection_data_controller
...
[ASCollectionDataController] Remove unncessary batch layout calls for supplementary nodes.
2016-03-01 18:16:27 -08:00
appleguy
8f0777e7e5
Merge pull request #1305 from garrettmoon/fixRecursivelyEnsureDisplay
...
[ASDisplayNode] recursivelyEnsureDisplay should trigger display even if a stale contents exists (re-display)
2016-03-01 17:43:28 -08:00
Garrett Moon
2cee9bfca8
Just because we have contents, doesn't mean we don't want to display
2016-03-01 17:41:29 -08:00
appleguy
47d2981487
Merge pull request #1304 from garrettmoon/betterSkipClearContents
...
[ASDisplayNode] Coalesce -clearContents onto the next runloop, so it can be skipped if re-added to hierarchy in move operation.
2016-03-01 17:38:36 -08:00
appleguy
130e81fe88
Merge pull request #1303 from maicki/ImageDeallocationPerformanceImprovements
...
[ASNetworkImageNode] Dispatch deallocation of UIImage in clearFetchedData: to background thread
2016-03-01 17:12:37 -08:00
Michael Schneider
6e69c312d6
Dispatch deallocation of UIImage on background thread
...
Destruction of bigger images in ASNetworkImageNode on the main thread can be expensive and can take some time, so we dispatch onto a background queue to actually dealloc.
2016-03-01 17:04:38 -08:00
Garrett Moon
057c431dfb
Thanks @scottg, this is a better more generalized solution.
2016-03-01 16:46:03 -08:00
Garrett Moon
eba6afc36b
Revert "Don't clear contents when moving between nodes"
...
This reverts commit 6d1732fcbd .
2016-03-01 16:45:36 -08:00
Huy Nguyen
1dffc20e4d
Address documentation of ASCellNodeVisibilityEvent
2016-03-01 15:56:08 -08:00
Huy Nguyen
5ecc9b16a9
Remove unncessary batch layout calls in ASCollectionDataController
...
- These calls cause supplementary nodes to be allocated and laid out, but not inserted afterward. So the nodes are thrown away.
- Next time when it is the right time to allocate these nodes, it is the second allocation request and triggers assertion in ASIndexedNodeContext #1296 .
2016-03-01 15:42:53 -08:00