Adlai Holler
92bbfc112f
Generate an iOS 9 reference image for testTextContainerInsetIsIncludedWithSmallerConstrainedSize ( #2880 )
2017-01-09 12:55:31 -08:00
Huy Nguyen
6a8cc50328
Remove Buck abstract target in Podfile ( #2878 )
2017-01-09 12:53:23 -08:00
Huy Nguyen
3761d8b0c3
ASVideoNode should play when its player is ready and if it is expected to play ( #2876 )
...
- When a video node is first visible, it's player is called to play if auto play flag is on. However, the player might not be ready by that time, especially when the video is loaded on a slow network. The player just continues loading its asset.
- When the player is ready, we should check if it is expected to be playing and if true, try to play again.
2017-01-09 12:02:00 -08:00
Brandon Withrow
649b385d2a
Merge pull request #7 from brandon-withrow/btw/lottie/completionblock
...
Updated Completion Block Handling
2017-01-06 15:43:03 -08:00
Brandon Withrow
2df2b364d5
Updated Completion Block Handling
2017-01-06 15:40:46 -08:00
Brandon Withrow
4045ab3abb
Merge pull request #6 from brandon-withrow/btw/lottie/urlload
...
Added LoadFromUrl api
2017-01-06 14:37:46 -08:00
Brandon Withrow
ee2269ba55
Code Cleanup
2017-01-06 14:36:41 -08:00
Brandon Withrow
ae57c41b08
Added LoadFromUrl api
2017-01-06 14:32:46 -08:00
Garrett Moon
202c947be9
[ASNetworkImageNode] Don't lock while calling downloader ( #2864 )
...
* Don't lock while calling downloader
Addresses #2785
To avoid performance issues, we should avoid locking the downloader.
To achieve this we need to do some kinda gross things. Essentially
the cost is the code is more complex and potentially far less performant
in edge cases. In testing, edge cases are nearly never hit, but I'm not
sure how good I feel about the cost in code complexity. This exacerbates
the locking issues in ASNetworkImageNode:
1. There is no convention for which methods lock.
2. There's no indication which vars are only set on init and therefore
safe to access except in the class extension definition.
* Shouldn't have checked in product changes.
* Using ivar instead of local var copied within lock.
2017-01-05 15:22:27 -08:00
Brandon Withrow
bfc0f9d4c4
Merge pull request #5 from brandon-withrow/rename/Lottie
...
Renamed repo
2017-01-05 15:14:07 -08:00
Brandon Withrow
72dd42c7bd
Renamed repo
2017-01-05 15:13:30 -08:00
David Robles
2bc701d23f
Copy ASTextNode’s implementation of placeholderImage into ASImageNode in order to fix the usage of placeholderColor. ( #2866 )
2017-01-05 14:59:11 -08:00
Brandon Withrow
8f07baefcd
Merge pull request #4 from brandon-withrow/btw/JSONVersionUpdate
...
Updates and bug fixes
2017-01-05 14:51:38 -08:00
Brandon Withrow
e7ed222eb7
Updates and bug fixes
2017-01-05 14:50:23 -08:00
overtake
71ae7a03e5
Merge branch 'master' of https://github.com/peter-iakovlev/Postbox
2017-01-05 13:51:11 +03:00
Huy Nguyen
be6faa107a
Support Buck build ( #2849 )
...
* Support Buck build
* Simplify pod_install hook and buck-file dir's structure
* Update PINRemoteImage's BUCK
* Frameworks linking:
- Weak linking Photos and MapKit.
- Revisit //:Tests' list.
2017-01-04 14:11:28 -08:00
Adlai Holler
513b9f4184
Remove unused and unusable implementations of moveItem: and moveSection: ( #2863 )
2017-01-04 14:04:56 -08:00
Adlai Holler
d65fe8b5fa
Disable UICollectionView prefetching to improve scroll performance ( #2861 )
2017-01-04 13:30:23 -08:00
Peter
ed4e8d5e59
no message
2017-01-05 01:15:08 +04:00
Peter
57e6385024
no message
2017-01-05 01:14:49 +04:00
Peter
84c0a86d8f
no message
2017-01-05 01:14:32 +04:00
Peter
a4ea9ca8cf
no message
2017-01-05 01:14:04 +04:00
Huy Nguyen
89d4193757
Open source pi_imageNamed methods ( #2859 )
2017-01-04 10:57:23 -08:00
Adlai Holler
23c81b150d
Disable testThatRootPagerNodeDoesGetTheRightInsetWhilePoppingBack ( #2857 )
2017-01-03 14:55:11 -08:00
Adlai Holler
4a6ba2761b
ASDataController: Correctly Handle Nil IndexPath in nodeForIndexPath: Methods ( #2856 )
...
* ASDataController: Correctly handle fetching node at nil index path (return nil).
* Be more aggressive, in order to avoid needlessly waiting for updates to complete
2017-01-03 14:45:16 -08:00
Huy Nguyen
99c5021be7
Remove duplicated _delegate ivar in ASVideoNode ( #2844 )
2017-01-01 18:42:41 -08:00
Adlai Holler
2f7925544b
Add a failing unit test for the automatic subnode management range issue ( #2826 )
2016-12-28 11:22:43 -06:00
Peter
c6fdc9ab65
no message
2016-12-28 17:05:07 +03:00
Scott Goodson
e264d94dde
[ASScrollNode] Fix a minor error in ASScrollNode sizing.
2016-12-27 13:45:34 -08:00
overtake
af145a1194
channels
2016-12-27 19:39:02 +03:00
overtake
3fe3779f3f
Merge branch 'master' of https://github.com/peter-iakovlev/Postbox
2016-12-27 15:13:41 +03:00
Peter
8fdd767461
no message
2016-12-27 15:13:12 +03:00
Peter
b99e0d71c4
no message
2016-12-27 15:03:01 +03:00
Peter
a833bd5b62
no message
2016-12-27 14:59:23 +03:00
Peter
7f67d67b1b
Merge commit '0f85320dacde3266a9666d6418839e0443e967cb'
...
# Conflicts:
# TelegramCore.xcodeproj/project.pbxproj
# TelegramCore/Account.swift
2016-12-27 14:58:11 +03:00
overtake
0f85320dac
group/channel create
2016-12-27 14:53:35 +03:00
Peter
c2768b07b3
no message
2016-12-27 14:40:30 +03:00
Adlai Holler
a426d99c74
Remove irritating layout attributes assertions ( #2828 )
2016-12-25 11:43:34 -05:00
Hannah Troisi
0a86a6b980
[ASVideoNode] Add missing strong attributes ( #2834 )
...
* fix missing strong attribute
* change strong to copy
2016-12-24 23:35:27 -08:00
Peter
a907fdd030
no message
2016-12-23 20:32:29 +03:00
Peter
e141530d22
Merge commit '36a7940bc0638ca2171b765a14bc8cc328a4f08a'
2016-12-23 18:11:48 +03:00
Adlai Holler
2ea7d4c1c0
By default, capture the current animation enabledness for collection/table updates ( #2827 )
2016-12-23 09:46:49 -05:00
Huy Nguyen
c1157084ca
Clean up ASStackPositionedLayout ( #2817 )
...
- Remove lastChildOffset. It's unncessary after #2627 .
- Remove the version of `stackedLayout()` that takes 1 less param. Isn't worth the complexity.
2016-12-22 16:02:57 -05:00
Adlai Holler
57913b8578
Range Controller Uses Last Scroll Direction, Defaults to Down/Right ( #2808 )
...
* Test that the initial range bounds are what we expect
* Use the user's previous scroll direction in the range controller
* Remove flow layout assertion
2016-12-22 15:48:57 -05:00
overtake
b95fac4112
Merge branch 'master' of https://github.com/peter-iakovlev/TelegramCore
...
Conflicts:
TelegramCore/Account.swift
2016-12-22 13:20:48 +03:00
overtake
5889a68733
typings to core
2016-12-22 13:18:51 +03:00
overtake
42737e6ebd
typings to core
2016-12-22 13:18:50 +03:00
overtake
10240b9eb1
Merge branch 'master' of https://github.com/peter-iakovlev/Postbox
2016-12-22 13:17:15 +03:00
appleguy
30924d976f
[ASDataController] Ensure ASRangeController has an opportunity to update visible nodes before they're deleted by -reloadData path. ( #2815 )
...
This change is specific to the reloadData path, which had the last-known occurrence of "deallocated while marked visible".
https://github.com/facebook/AsyncDisplayKit/issues/2711
2016-12-21 19:23:27 -08:00
Peter
c0b31e7eba
Merge commit '7872cfb5a40c5483c23c810096f69d315d8b54bc'
...
# Conflicts:
# AsyncDisplayKit/ASImageNode.mm
2016-12-22 03:21:26 +03:00
