Commit Graph

25012 Commits

Author SHA1 Message Date
Wendy
4daee3ca76 Update PINRemoteImage 2016-04-26 18:35:03 -07:00
Wendy
fe5c4caf90 Lock properly when setting currentImageQuality 2016-04-26 18:35:03 -07:00
Wendy
0b55df9649 Add the ability for ASNetworkImageNodes to keep track of their progressive image quality 2016-04-26 18:33:59 -07:00
Lukas Spieß
f068280e2c Add warning log if StoreUpdateManager is running in debug env 2016-04-26 22:08:05 +02:00
appleguy
f7985d2d26 Merge pull request #1593 from maicki/FixASCellNodeVisiblityDeallocationAssertion
[ASDisplayNode] Fix assertion on cell deallocation due visibility not being cleared
2016-04-26 12:28:08 -07:00
Michael Schneider
2ab82f5995 Move to fast enumeration for iterating through an array
We move from block based enumeration for the array to fast enumeration as from a benchmark perspective this is faster. For the dictionary we stay with block based enumeration as looking up the value for the key in e.g. fast enumeration would be slower as using the block based API where we get the key and value for passed in
2016-04-26 10:45:35 -07:00
Michael Schneider
32f35d9d54 Use visibleNodeIndexPathsForRangeController: to base on visibleNodes in ASTableView 2016-04-26 10:37:32 -07:00
Michael Schneider
28cfd60900 Fix Assertion on cell deallocation due visibility not being cleared
Further information:
- We mark every node as visible in the ASRangeController which NSIndexPath is returned from visibleNodeIndexPathsForRangeController:
- In visibleNodeIndexPathsForRangeController: we get the visible index path's via a call to UITableView's "indexPathsForVisibleRows" method.
- Unfortunately in this case we cannot use indexPathsForVisibleRows to get all the visible index paths as apparently in a grouped UITableView it would return index paths for cells that are just a bit over the edge of the visible area.
- But this edge cells will never get a call for -tableView:cellForRowAtIndexPath:, but we will mark them as visible in the range controller
- In tableView:cellForRowAtIndexPath: we call -configureContentView:forCellNode
- Because we never get a -configureContentView:forCellNode call for the edge cells, the _ASDisplayView of the nodes will never be added to the window and get a willMoveToWindow and didMoveToWindow call and it's never get's added to the window for now and so the node is NOT marked as "in the hirarchy"
- If the deallocation of the views are happening without the UITableView ever scrolled, the cells don't get a call to __exitHierarchy as they were never added to the window and stay in the interface state "visible" and an exception will be raised within the dealloc method of the ASDisplayNode
2016-04-26 10:37:06 -07:00
appleguy
bf52bc55cc Merge pull request #1591 from garrettmoon/fixAnimatedGIFWarning
Specifies beta of PINRemoteImage
2016-04-25 19:39:19 -07:00
appleguy
8a7fe22c19 Merge pull request #1590 from maicki/FixProgressImageBlockDeadLock
[ASNetworkImage] Fix possible deadlock introduced yesterday in ASNetworkImageNode
2016-04-25 13:27:25 -07:00
Garrett Moon
7f8edb8537 Specifies beta of PINRemoteImage 2016-04-25 13:18:31 -07:00
Michael Schneider
ce6e11c6d2 Fix deadlock in ASNetworkImageNode
Calling _updateProgressImageBlockOnDownloaderIfNeeded should be called without _lock held. We will lock super to read our interface state and it's best to avoid acquiring both locks.
2016-04-25 13:15:11 -07:00
Lukas Spieß
0fda434045 Update version and build numbers to 4.1.0-beta.1 2016-04-25 01:07:30 +02:00
Lukas Spieß
d3d240ddbe Update version and build numbers to 4.0.0 2016-04-25 01:07:07 +02:00
appleguy
2adc616e93 Merge pull request #1526 from Adlai-Holler/ImageNodeImprovements
[ASImageNode] Improvements to progressive decoding and cache accesses.
2016-04-23 23:05:41 -07:00
Scott Goodson
b99910a149 [Examples, Build] Fix project configuration of two example apps that were incompatible with modern Cocoapods. 2016-04-22 23:04:12 -07:00
Scott Goodson
15a4e18844 [Examples] Officially add tvOS to podspec, ensure Podfiles correctly show minimum supported version 7.0 instead of 7.1 2016-04-22 20:29:52 -07:00
appleguy
094f327779 Merge pull request #1585 from maicki/RemoveASLayoutOptionsLocking
Remove ASLayoutOptions locking
2016-04-22 20:25:10 -07:00
Michael Schneider
bcd91f18ce Remove ASLayoutOptions locking 2016-04-22 19:54:40 -07:00
appleguy
77713019d2 Merge pull request #1575 from aaronschubert0/tvOS
[tvOS] Improve tvOS code based upon comments.
2016-04-22 19:47:43 -07:00
appleguy
d968094778 Merge pull request #1583 from maicki/AddLayoutSpecBlockFollowUp
[ASDisplayNode] Add layout spec block follow up
2016-04-22 19:45:00 -07:00
Scott Goodson
8d9107f57e [Examples, Build] Moving some smaller / less useful examples to a separate directory, speeding up builds. 2016-04-22 19:41:43 -07:00
Scott Goodson
613832fc6a [Build] Improve formatting of build script output for Travis. 2016-04-22 19:37:20 -07:00
appleguy
bbdbb3d82d Merge pull request #1577 from Adlai-Holler/CellNodeLayoutDelegateFix
[ASCellNode] Repair Layout Delegate Behavior When Triggered Off-Main
2016-04-22 19:22:16 -07:00
Adlai Holler
05b22531e6 Include necessary header 2016-04-22 19:12:38 -05:00
Lukas Spieß
700cdd32ce Merge branch 'feature/metrics/managed-exception-support' into feature/metrics/develop 2016-04-23 01:43:36 +02:00
Lukas Spieß
9e239ff764 Fix minor string replacement error 2016-04-23 01:43:36 +02:00
Lukas Spieß
7f601c563b Update Xamarin sample to fit the actual crash report 2016-04-23 01:43:36 +02:00
chrwend
9125cbf53b Update tests 2016-04-23 01:43:36 +02:00
chrwend
95707bb8da Remove inner exception delimiter from managed stack 2016-04-23 01:43:36 +02:00
chrwend
92b74840f5 Fix unit test: Update report version of reference crash log 2016-04-23 01:43:36 +02:00
chrwend
70a8c27374 Set ReportVersion to 104-Xamarin if report contains xamarin stack trace 2016-04-23 01:43:36 +02:00
chrwend
04367d7068 Update xamarin log for unit test 2016-04-23 01:43:36 +02:00
chrwend
6be97cf34c Fix unit test (remove unwanted space) 2016-04-23 01:43:36 +02:00
chrwend
de5ead95b7 Remove trailing whitespaces of crash reason and stacktrace 2016-04-23 01:43:36 +02:00
chrwend
426ab49269 Use const for Xamarin stack delimiter 2016-04-23 01:43:36 +02:00
chrwend
abb07a6cef Add tests for formattings managed exception portions 2016-04-23 01:43:36 +02:00
chrwend
34aa6dbc82 Extract Xamarin Exception if available and insert it below "Application Specific Information" 2016-04-23 01:39:11 +02:00
Lukas Spieß
746df23867 Fix Channel tests by using OCMPartialMock of persistence 2016-04-23 01:38:44 +02:00
Lukas Spieß
3fa8a5e4eb Merge branch 'develop' into feature/metrics/develop
# Conflicts:
#	Classes/BITCategoryContainer.h
#	Classes/BITGZIP.h
#	Classes/BITHockeyManager.h
#	Support/buildnumber.xcconfig
#	docs/Changelog-template.md
2016-04-23 01:21:35 +02:00
Lukas Spieß
a78614f333 Amend Changelog with CrashOnly build updates 2016-04-22 22:36:00 +02:00
Lukas Spieß
aca2f4a538 Merge pull request #96 from bitstadium/feature/add-usermetrics-crashonly
Add User Metrics to CrashOnly build
2016-04-22 22:33:02 +02:00
Lukas Spieß
215dfd667e Add User Metrics features to CrashOnly build 2016-04-22 22:26:34 +02:00
Lukas Spieß
d6ed100c97 Fix AppIcon path search with exotic filenames 2016-04-22 21:57:10 +02:00
Lukas Spieß
0eb39be361 Add tests for exotic AppIcon filename variations 2016-04-22 21:56:45 +02:00
Lukas Spieß
60f81dcd66 Make assertions in AppIconFilename tests more precise 2016-04-22 21:56:45 +02:00
Lukas Spieß
69d15ff875 Merge pull request #280 from bitstadium/feature/category-prefix
Prefix category on NSData to prevent symbol collisions
2016-04-22 21:50:01 +02:00
Lukas Spieß
e789e30060 Merge pull request #279 from bitstadium/feature/update-test-frameworks
Update testing frameworks
2016-04-22 21:48:25 +02:00
Michael Schneider
5cfc16733a Add node as parameter in ASLayoutSpecBlock 2016-04-22 11:22:20 -07:00
Michael Schneider
79e5337948 Fix setter override for setLayoutSpecBlock: 2016-04-22 11:22:01 -07:00