Commit Graph

25012 Commits

Author SHA1 Message Date
Adlai Holler
de46701ff7 [ASMapNode] Remove live map on clearFetchedData, not clearContents 2016-02-24 15:20:02 -08:00
appleguy
db2a606a51 Merge pull request #1269 from garrettmoon/fixButtonLabel
[ASButtonNode] Flex shrink should be set on title init, not image init
2016-02-24 15:16:48 -08:00
Garrett Moon
6a1298440d Flex shrink should be set on title init, not image init 2016-02-24 15:10:18 -08:00
appleguy
439ca172d1 Merge pull request #1267 from eanagel/super-layout-required
[ASDisplayNode] Add NS_REQUIRES_SUPER for -layout.
2016-02-24 13:31:56 -08:00
appleguy
74e6d087d4 Merge pull request #1268 from eanagel/forward-scrollViewDidScroll
[ASTableView] Fix recent regression to ensure scrollViewDidScroll: is forwarded correctly
2016-02-24 13:30:08 -08:00
Ethan Nagel
fa4e20e874 Initialize _asyncDelegateImplementsScrollviewDidScroll so we forward scollViewDidScroll: calls 2016-02-24 11:03:06 -08:00
Ethan Nagel
26dcad5218 Add a warning if [super layout] is not called (which causes big problems for ASLayout.) 2016-02-24 10:28:22 -08:00
rcancro
8dbc8b7df4 reordered conditionals, moved beta things to beta header file 2016-02-24 08:06:10 -08:00
Engin Kurutepe
bb856d8786 update build script and travis settings 2016-02-24 15:05:37 +01:00
Aaron Schubert
3d6f6766e9 [tvOS] Implement a default behaviour of ASImageNode, trying to match the behaviour of UIImageView. Still need to add shine. 2016-02-24 13:58:11 +00:00
rcancro
878fedd8f3 Stopped trying to cache the currentScaleFactor
Was running into issues where the scale factor would get cleared when setting a new atributedString on a textNode.

I was clearing out the currentScaleFactor when setting an attributedString into a textNode. It appears that `_calculateSize` isn't always called when setting a new string into a ASTextNode. It can be the case that only `drawInContext:bounds:` is called. With _currentScaleFactor cleared out the renderer that calls`drawInContext...` was being called with a scaleFactor of 0.

It could be the case that the fix could be to remove the clearing of `currentScaleFactor` from `setAttributedString`, but this seems like a safer fix to me. It does, however, require an extra run through the font adjuster when enabled.
2016-02-23 16:51:10 -08:00
appleguy
eb6aa28d42 Merge pull request #1263 from levi/patch-5
[ASCollectionView] Enable animated bounds changes
2016-02-23 13:23:31 -08:00
Levi McCallum
c2d379f8f5 Add a bit of documentation to describe the problem this is solving 2016-02-23 13:02:37 -08:00
Levi McCallum
4640801939 Enable animated bounds changes in ASCollectionView 2016-02-23 09:36:11 -08:00
Engin Kurutepe
1703bd77ee add README.md 2016-02-23 15:06:40 +01:00
Engin Kurutepe
003727746e Add an example project which tests Carthage build 2016-02-23 15:00:56 +01:00
Engin Kurutepe
9c7e21d0bb Merge remote-tracking branch 'facebook/master' 2016-02-23 14:37:15 +01:00
Aaron Schubert
d9cde1f08c [tvOS] Added a default touch down animation for ASControlNode 2016-02-23 12:18:33 +00:00
Aaron Schubert
4ad6d91a10 Add default focus response to ASControlNode 2016-02-23 11:16:07 +00:00
Aaron Schubert
5d367328d9 Make ASControlNode the default focusable view. This is so that we can receive touch events that will manipulate the view. 2016-02-23 10:39:32 +00:00
Aaron Schubert
682903fba5 Make ASDisplayNode unable to be focused by default. ASControlNode will be the new default. 2016-02-23 10:36:53 +00:00
aaronschubert0
99e578a56f Comment out PINRemoteImage Properly. 2016-02-23 10:30:51 +00:00
aaronschubert0
ae965ae940 Disable PINRemoteImage
Probably won't work but easier than writing support for PINRemoteImage
2016-02-23 10:29:43 +00:00
Aaron Schubert
106b5f5d4a Update 2016-02-23 10:20:06 +00:00
appleguy
92f87756b3 Merge pull request #1261 from garrettmoon/fixASNetworkImageNoCache
[ASNetworkImageNode] Should not assert when it is explicitly provided a nil cache.
2016-02-22 22:16:26 -08:00
Garrett Moon
359d19da29 ASNetworkImageNode should support a nil cache. 2016-02-22 21:58:45 -08:00
appleguy
3abde9348d Merge pull request #1256 from Adlai-Holler/AHAffinityRevisions
[ASDisplayNode] Post-Review Refinements of Recent No-Affinity UIKit/CA Property Bridging
2016-02-22 20:41:59 -08:00
appleguy
3eb0d4e877 Merge pull request #1258 from rcancro/textKitBlocks
[ASTextNode] Add block to customize NSLayoutManager and NSTextStorage (subclass, initialization)
2016-02-22 19:44:34 -08:00
appleguy
75f620aa91 Merge pull request #1257 from Adlai-Holler/FixImageNodeLockingIssue
[ASImageNode:displayDidFinish] Unlock _imageLock Correctly
2016-02-22 19:40:13 -08:00
Adlai Holler
fd5723379f [ASImageNode] Lock & unlock directly instead of using stack objects. 2016-02-22 18:48:31 -08:00
appleguy
79389ba66e Merge pull request #1251 from ekurutepe/fix-umbrella-header
[AsyncDisplayKit] Adjust Umbrella header to ensure Carthage build succeeds.
2016-02-22 18:32:34 -08:00
Peter
57a9c196b9 no message 2016-02-23 04:08:47 +03:00
appleguy
fc99ff5e4c Merge pull request #1259 from Adlai-Holler/ASCellNodeLovesASViewController
[ASCellNode] Use ASViewController.node Directly Instead of Wrapping
2016-02-22 15:18:38 -08:00
Adlai Holler
767bff2e1a [ASInternalHelpers] Use ASDisplayNodeThreadIsMain, reduce block allocations 2016-02-22 15:12:13 -08:00
Adlai Holler
977a509bd4 [ASCellNode] If viewControllerBlock returns an ASViewController, use its node directly instead of wrapping 2016-02-22 15:11:27 -08:00
Adlai Holler
afc70b90ab [ASCellNode] Improve documentation, remove unused ivar 2016-02-22 15:10:02 -08:00
rcancro
00b0968bf7 Add ability to customize NSLayoutManager and NSTextStorage when created in the ASTextKitContext 2016-02-22 13:00:02 -08:00
Adlai Holler
57ca0c73bf [ASImageNode] Correctly unlock _imageLock 2016-02-22 09:12:58 -08:00
Adlai Holler
f4e4c501f1 [ASDisplayNode] Remove misplaced comment that has been replaced 2016-02-22 09:06:36 -08:00
Adlai Holler
03d2b57991 [ASImageNode] Unlock immediately after updating _image 2016-02-22 09:04:23 -08:00
Adlai Holler
deccef1d94 [ASDisplayNode] Lock during constrainedSizeForCalculatedLayout 2016-02-22 09:04:01 -08:00
Adlai Holler
015c024b7a [ASPendingState] Give local variables default values 2016-02-22 08:54:58 -08:00
Adlai Holler
100d0a1302 [_ASPendingState] Deduplicate logic for applying setNeedsDisplay and applying frame/bounds/position 2016-02-22 08:52:26 -08:00
appleguy
896f0adcaf Merge pull request #1255 from garrettmoon/fixRelativeSizeResolve
[ASRelativeSize] Fix function prototype with a different name in header than in implementation.
2016-02-21 12:02:22 -08:00
Adlai Holler
b8d2941093 [ASPendingStateController] Unite -flush and -flushNow methods, cleanup 2016-02-21 11:27:36 -08:00
Adlai Holler
ff59401b05 [ASInternalHelpers] Improve spacing 2016-02-21 11:23:54 -08:00
Adlai Holler
5eca1e6c68 [ASDisplayNode:UIViewBridge] Clean up setNeedsDisplay/setNeedsLayout 2016-02-21 11:23:28 -08:00
Adlai Holler
d9d4d40997 [ASDisplayNode:UIViewBridge:setFrame] Use CALayer directly when possible 2016-02-21 10:52:20 -08:00
Adlai Holler
b1c7f47b02 [ASDisplayNode:UIViewBridge] Refactor setFrame: to simplify logic 2016-02-21 10:42:38 -08:00
Adlai Holler
3ff833c4f5 [ASDisplayNode:UIViewBridge] Reduce calls to -isNodeLoaded 2016-02-21 10:10:04 -08:00