Commit Graph

25012 Commits

Author SHA1 Message Date
Adlai Holler
87caed27e2 Add more deep compares when setting public properties to the same value 2015-10-05 23:48:48 -07:00
Adlai Holler
f0b7e150cd Limit 1 inflight Photos.framework request per multiplex image node 2015-10-05 23:40:33 -07:00
Adlai Holler
d94dcdef0f Only do PHAsset metadata requests one at a time to workaround Photos framework deadlock 2015-10-05 23:40:33 -07:00
appleguy
2e5da5599d Merge pull request #713 from Adlai-Holler/MultiplexImageNodeShortCircuit
Use deep compare when setting image identifiers in ASMultiplexImageNode
2015-10-05 22:52:01 -07:00
Adlai Holler
ce97b56580 Sugar 2015-10-05 20:41:21 -07:00
Adlai Holler
c5b5bdd29c Use deep compare when setting image identifiers in ASMultiplexImageNode 2015-10-05 20:34:42 -07:00
appleguy
00e993c07b Merge pull request #710 from garrettmoon/fixShouldRasterizeSubnodes
Fix shouldRasterizeSubnodes skipping setting offset and clipping.
2015-10-05 18:04:54 -07:00
Garrett Moon
b1d03f1d58 Address comments 2015-10-05 16:02:01 -07:00
Garrett Moon
d6c107a896 Fix shouldRasterizeSubnodes skipping setting offset and clipping. 2015-10-05 16:02:01 -07:00
Adlai Holler
ee970d412b Annotate ASCollectionViewProtocols.h 2015-10-05 13:48:09 -07:00
Adlai Holler
8bb9d173dc Merge branch 'master' into update-objc
Conflicts:
	AsyncDisplayKit/ASDisplayNode+Subclasses.h
	AsyncDisplayKit/ASMultiplexImageNode.h
	AsyncDisplayKit/ASViewController.h
	AsyncDisplayKit/Details/ASDataController.h
2015-10-05 13:24:16 -07:00
appleguy
2f1d57e50c Merge pull request #708 from Adlai-Holler/FasterLayoutNodes
Faster handling of iteration to lay out nodes in ASDataController.
2015-10-05 12:46:37 -07:00
Adlai Holler
99b9f73b1a Fix index into size ranges 2015-10-05 11:51:05 -07:00
Adlai Holler
33c07db58c Set node.frame entirely 2015-10-05 11:42:25 -07:00
Adlai Holler
4601fccb5a Optimize ASDataController._layoutNodes 2015-10-05 11:37:29 -07:00
Lukas Spieß
bccfc61a42 Add warnings to docs for threading, properly dispatch internally 2015-10-05 17:39:03 +02:00
Lukas Spieß
ed3ea81864 Disable Authenticator and UpdateManager in TestFlight 2015-10-05 17:12:39 +02:00
Lukas Spieß
13aaaa6ae0 Move AppStore detection and adapt for TestFlight 2015-10-05 17:11:56 +02:00
Scott Goodson
77745c55b0 Properly support operating with nil asyncDelegate for Table & Collection. 2015-10-04 17:11:41 -07:00
appleguy
67cf6d3951 Merge pull request #705 from facebook/ThreadAffinity
Improved messages for thread affinity and frame transform identity assertions.
2015-10-04 16:24:39 -07:00
Scott Goodson
61bb4f022e Improved messages for thread affinity and frame transform identity assertions. 2015-10-04 11:15:57 -07:00
appleguy
057422d52b Merge pull request #699 from rcancro/staticLayout
Fix static layout to ensure it always considers its sub layout's preferred sizes.
2015-10-04 10:52:02 -07:00
appleguy
ca2399f57f Merge pull request #704 from marmelroy/feature-dynamic-framework-test
Fixing dynamic framework target and adding an example for Travis
2015-10-04 09:12:53 -07:00
Roy Marmelstein
c92a15515d Adding readme 2015-10-04 11:07:47 +02:00
Roy Marmelstein
f4ba447159 Updating Travis and Build script to test dynamic framework building 2015-10-04 11:03:52 +02:00
Roy Marmelstein
caf306123c Removed unnecessary bridging header 2015-10-04 11:00:03 +02:00
Roy Marmelstein
4380e0baae Framework test target 2015-10-04 10:58:33 +02:00
appleguy
6f9c819b5d Merge pull request #701 from rcancro/layoutOptionBug
wasn't copying alignSelf
2015-10-02 23:14:01 -07:00
ricky cancro
eb5e670e5d wasn't copying alignSelf 2015-10-02 20:58:52 -07:00
appleguy
897f7210ad Merge pull request #687 from Adlai-Holler/AdvancedPhotos
Advanced Photos Integration
2015-10-02 16:40:58 -07:00
ricky cancro
45a555cdb5 Static layout bug?
I noticed when creating a static layout that the sizeRange of the children was being ignored. The case was:

I had an image as a child of a static layout
The image was set to have an exact range of 90x90
When the static layout was measured, the constrained size came in as 375xInf (the width of the containing node and unbounded)
The static layout computed its final size as 375x90

According to the comments in component kit's header file the static layout  "[c]omputes a size that is the union of all childrens' frames." It appeared that we are only doing that in the unbounded direction. My fix is to do it in both directions.
2015-10-02 15:56:31 -07:00
Adlai Holler
304ec9b543 Refuse to parse ph:// URLs if iOS < 8 for safety 2015-10-02 15:51:32 -07:00
Adlai Holler
d5a6ad2123 Avoid accessing PHImageManager in ASMultiplexImageNode init 2015-10-02 15:41:01 -07:00
appleguy
6d369ff815 Merge pull request #697 from garrettmoon/fixCornerRadius
Corner radius and clipsToBounds should be captured outside block
2015-10-02 15:00:14 -07:00
Adlai Holler
ac8b224d9b Fix broken ASPhotosFrameworkImageRequest test 2015-10-02 13:04:48 -07:00
Adlai Holler
35c118aff0 Merge branch 'master' into AdvancedPhotos
Conflicts:
	AsyncDisplayKit/ASMultiplexImageNode.mm
2015-10-02 12:45:49 -07:00
Adlai Holler
de1f9788f3 Simplify creation of Photos Framework NSURLs in ASMultiplexImageNode 2015-10-02 12:44:21 -07:00
Garrett Moon
c90708a25b Corner radius and clipsToBounds should be captured outside block 2015-10-02 09:30:49 -07:00
appleguy
fd88522f84 Merge pull request #636 from nguyenhuy/fixSetNeedsLayout
Use getters and setters while adjusting position of a node
2015-10-01 18:08:28 -07:00
Lukas Spieß
44b231225c Silence AssetLibrary deprecation warning while we work to replace it 2015-10-01 17:04:46 +02:00
Lukas Spieß
30f27eae8f Small code refactorings and improvements 2015-10-01 17:04:23 +02:00
Lukas Spieß
230ac86130 Make sure showView: method always runs on main queue 2015-10-01 15:37:07 +02:00
Lukas Spieß
5303ebc414 Always present feedback alerts using main queue 2015-10-01 15:37:07 +02:00
Lukas Spieß
02f73a31d2 Use https directly to query Apple's search API
Although the http URL automatically redirects, we can obviously make this more clear by using https directly.
2015-10-01 15:11:02 +02:00
Lukas Spieß
5e1b3a3ef9 Run UI code in authenticator completions on main queue 2015-10-01 15:00:37 +02:00
Huy Nguyen
22fba5a108 Revert "Use getter and setter of other properties in ASDisplayNode's frame setter."
This reverts commit 93e53bbd87.
2015-10-01 11:13:49 +03:00
Lukas Spieß
c5205e8b18 Fix typo in installation setup template 2015-09-30 12:38:15 +02:00
Lukas Spieß
96cfb169b6 Switch back to using UIAlertView
We won't use UIAlertController for now until we have a more robust solution for displaying it without knowing the currently presented view controller.
2015-09-29 16:38:11 +02:00
Lukas Spieß
7539ab06ba Add comments to #endif for clarity 2015-09-29 15:53:46 +02:00
Andreas Linde
74880df968 Add documentation zip to distribution build 2015-09-29 13:48:45 +02:00