appleguy
7662cb67c1
Merge pull request #1432 from maicki/ASDataControllerCrashOnDataSourceDealloc
...
[ASDataController] Refactor ASDataController layout nodes methods
2016-03-31 21:49:58 -07:00
appleguy
938437d38f
Merge pull request #1455 from ejensen/scrolls-to-top
...
[ASEditableTextNode] Synchronize scrollsToTop with scrollEnabled
2016-03-31 21:19:45 -07:00
appleguy
6d1c52b042
Merge pull request #1456 from maicki/ASEnvironment
...
[ASEnvironment] Add support for ASEnvironment, supporting generalized state propagation both up and down node and layout spec trees.
2016-03-31 21:05:38 -07:00
appleguy
ea935456b8
Merge pull request #1437 from ejensen/editable-text-node-layout-manager
...
[ASEditableTextNode] Allow TextKit component customization
2016-03-31 20:46:19 -07:00
Michael Schneider
20ee9bca8d
Rename ASEnvironmentStateCreate to ASEnvironmentStateMakeDefault
2016-03-31 20:43:20 -07:00
Michael Schneider
5baab95506
Add up propagation of ASEnvironmentLayoutOptionsState in ASLayoutSpec while setting a child
2016-03-31 20:43:20 -07:00
Michael Schneider
f46f5640ff
Add improvements
...
- Remove defaults for ASEnvironmentLayoutOptionsState and ASEnvironmentHierarchyState
- Add locking for ASEnvironmentLayoutExtensibilityForwarding
- Other smaller improvements
2016-03-31 20:43:20 -07:00
Michael Schneider
4e757f0969
General improvements
...
- Refactor naming of ASEnvironmentCollection to ASEnvironmentState
- Remove struct pointers
- Move ASEnvironmentStatePropagation to a enum class
- Move merge functions to pure functions
- Move ASLayoutOptionsForwarding and ASLayoutableExtensibility into ASLayoutSpec and ASDisplayNode
- Remove ASLayoutableSetValuesForLayoutable and move into explicit classes (ASDisplayNode, ASTextNode)
2016-03-31 20:43:20 -07:00
Michael Schneider
65b4961802
Add extensibility support for ASEnvironmentLayoutOptionsState
2016-03-31 20:43:20 -07:00
Michael Schneider
96df35e41a
Initial commit for ASEnvironment
2016-03-31 20:43:20 -07:00
Scott Goodson
212e0f6c2b
[AsyncDisplayKit] Move build server to iOS 9.3. Fix Carthage build.
2016-03-31 00:04:56 -07:00
Huy Nguyen
387f3bf634
Properly lock layoutableContextMap
...
Signed-off-by: Huy Nguyen <huy@pinterest.com>
2016-03-29 13:40:57 -07:00
Eric Jensen
a4a0b1f85e
Synchronize ASPanningOverriddenUITextView's scrollsToTop when the scrollEnabled property changes
2016-03-29 12:18:57 -07:00
Scott Goodson
1ea1560694
[ASDisplayNode] Rasterized subnodes require special handling for __exitHierarchy.
2016-03-28 17:58:35 -07:00
Scott Goodson
096df7b385
[ASDisplayNode] Remove #if gating of ASDisplayNode hitTest: (I'd misread this as _ASDisplayView's implementation, and both are needed).
2016-03-28 07:49:14 -07:00
Scott Goodson
cd493358cc
[ASControlNode] Upgrades to +setEnableHitTestDebug: to intersect hitTestSlop with parents' bounds+slop, to accurately predict and visualize UIKit event delivery edge cases.
2016-03-27 22:02:13 -07:00
Scott Goodson
3e2414da6f
[ASInterfaceState] Fix for an edge case of exiting Visible state before node deallocation.
2016-03-27 18:15:40 -07:00
Michael Schneider
c6f00b1541
Use batchCount for indexes passed into internal layout nodes method and NSMaxRange
2016-03-27 17:54:40 -07:00
Michael Schneider
0284e55359
Add explicit range parameter for internal layout nodes method and better documentation
2016-03-27 17:48:17 -07:00
Michael Schneider
552b79deaa
Remove onMainThread: argument in internal layout nodes method
2016-03-27 17:48:17 -07:00
Michael Schneider
1f9e9b8483
Refactor ASDataController layout nodes methods
2016-03-27 17:48:17 -07:00
appleguy
97798010cb
Merge pull request #1443 from nguyenhuy/layoutable_context
...
[ASLayoutable] Introduce ASLayoutableContext, thread-local storage for layout passes.
2016-03-27 17:40:42 -07:00
Huy Nguyen
7bb3015950
Rename ASLayoutableContext methods
2016-03-27 17:38:41 -07:00
Huy Nguyen
81d26994c5
Introduce ASLayoutableContext
...
- The struct is mapped to ID of the current thread and used by subnodes to decide whether they should proceed measurement.
2016-03-27 17:09:59 -07:00
Eric Jensen
2f42a9ca6c
Re-declare the default init method in ASEditableTextNode's header
2016-03-27 00:12:49 -07:00
Scott Goodson
c6093cffdf
Fix assertion format specifier from previous commit.
2016-03-26 23:57:16 -07:00
Scott Goodson
6a887a8acf
[ASDisplayNode] Alternative implementation of interfaceState -> invisible that avoids a subclass call from -dealloc.
2016-03-26 23:24:30 -07:00
Scott Goodson
daf41ebb43
[ASTextNode] Fix edge case where text truncator may not run (manually hosted nodes that are lacking the expected call to -measure).
...
This fixes the scenario described in https://github.com/facebook/AsyncDisplayKit/issues/1295
2016-03-26 18:19:02 -07:00
Eric Jensen
387abbff5d
Rename ASTextKitHelpers to ASTextKitComponents and make the header public
2016-03-26 15:31:53 -07:00
Eric Jensen
5be3b0137a
Add nullability attributes to ASTextNode+Beta
2016-03-25 22:33:13 -07:00
Eric Jensen
0758475409
Remove unnecessary imports
2016-03-25 22:33:02 -07:00
Eric Jensen
0d52176e03
Add an ASEditableTextNode initializer that allows customization of its ASTextKitComponents
2016-03-25 22:23:03 -07:00
Eric Jensen
f8f3585764
Add a ASTextKitComponents initializer that allows customization of its NSTextStorage and NSLayoutManager
2016-03-25 22:12:19 -07:00
Levi McCallum
c07175bfcb
Fix conditional
2016-03-25 11:54:56 -07:00
Levi McCallum
687be58621
Fix PagerNode from not loading
2016-03-25 10:02:47 -07:00
Levi McCallum
f51ca78570
Simplify boolean logic
2016-03-24 21:40:49 -07:00
Levi McCallum
d845a18dfb
Prevent calculation of current index path when the collection view is empty
2016-03-24 21:33:01 -07:00
Eric Jensen
057ec55941
Correct documentation comments
2016-03-24 20:08:03 -07:00
Eric Jensen
7de48da44f
Correct ASEditableTextNode's default value according to the documentation
2016-03-24 20:00:53 -07:00
Eric Jensen
f988f86f7f
Assign the textView's scrollEnabled property in ASEditableTextNode's didLoad method.
...
This prevents a mismatch if the scrollEnabled property on ASEditableTextNode is set before the textView is loaded.
2016-03-24 19:51:16 -07:00
Scott Goodson
eed812dcdf
[ASRangeController] Slight tweaks to the default Full ranges, for memory savings in multi-tabbed apps with still-excellent preloading consistency.
2016-03-23 23:36:59 -07:00
Adlai Holler
a90a83b607
Copy sublayers to avoid NSFastEnumerationMutation exception
2016-03-23 21:57:23 -07:00
appleguy
4ffaebc93b
Merge pull request #1409 from ejensen/swift-alignment-enum
...
[Refactoring] ASHorizontalAlignment & ASVerticalAlignment Swift interface
2016-03-23 21:03:44 -07:00
appleguy
ac5d0265d9
Merge pull request #1408 from ejensen/swift-enum
...
[Refactoring] ASCellNodeVisibilityEvent Swift interface
2016-03-23 21:02:45 -07:00
Levi McCallum
f760c8460a
Nil out currentIndexPath after usage to prevent ASPagerFlowLayout crashes
2016-03-23 17:55:25 -07:00
Michael Schneider
4207e0e1a6
Add CFRunLoopWakeUp in processQueue
2016-03-22 20:19:17 -07:00
Scott Goodson
e59431e702
[ASDisplayNode] Restore dispatch_async for clearContents, to prevent discarding contents for nodes that are simply moving to a new container.
2016-03-22 18:39:23 -07:00
Scott Goodson
5b9302b681
Revert "Prevent deallocation of asyncDataSource and asyncDelegate in ASCollectionView and ASTableView"
...
This reverts commit 3668f45286a56a87d200aea0299caee9d2e4a880.
2016-03-22 14:38:50 -07:00
Scott Goodson
953c0f51f0
Revert "Move call of range update completion blocks to consider early returns in _updateVisibleNodeIndexPaths"
...
This reverts commit 41362fca3942b71cb092376e5baaa78652d1e19b.
2016-03-22 14:37:49 -07:00
appleguy
2319197a59
Merge pull request #1415 from facebook/DeallocInterfaceState
...
[ASInterfaceState] Clear the "Visible" bit immediately upon deallocation, rather than waiting for ASRangeController on the next runloop.
2016-03-22 14:37:29 -07:00