Adlai Holler
f5951d906e
Use fast enumeration for ASElementMap enumerating ( #3137 )
2017-03-04 15:18:41 -08:00
Adlai Holler
fad40c26c2
Remove ASTableView's pendingVisibleIndexPath system ( #3125 )
2017-03-04 12:52:28 -08:00
Adlai Holler
2785a0bcd8
Pager should invalidate flow layout metrics on bounds change ( #3133 )
2017-03-04 11:01:09 -08:00
Adlai Holler
0de270fdfb
Revert "Improve designated initializer usage ( #3132 )"
...
This reverts commit eaa875c7f2e08afa8b597c653be6b7c45cfff66d.
2017-03-03 15:31:28 -08:00
Michael Schneider
eaa875c7f2
Improve designated initializer usage ( #3132 )
...
* Improve designated initializer usage
* Some more changes
* Add some whitespace
* Fix some warning
2017-03-03 14:49:34 -08:00
Michael Schneider
62d7e14ce1
Improve measurement code for cell nodes ( #3119 )
2017-03-03 09:24:04 -08:00
Adlai Holler
93809bd4e7
Add a Convenience Property to Get Owning View Controller ( #3076 )
...
* Add a convenience property -closestViewController
* Address comments
2017-03-02 11:51:16 -08:00
Adlai Holler
012b378a22
Fix a Compiler Warning from ASAbstractLayoutController.mm ( #3123 )
...
* Fix a compiler warning about ASAbstractLayoutController
* Fix merge
2017-03-02 10:59:26 -08:00
Adlai Holler
9c7081f2d7
Majorly Simplify ASTableLayoutController ( #3124 )
...
* Majorly Simplify ASTableLayoutController
* Remove the setVisibleNodeIndexPaths: API
2017-03-02 10:59:13 -08:00
Huy Nguyen
415005b6fc
ASStackLayoutSpec utilizes multiple threads if it runs on main ( #3116 )
2017-03-02 10:12:53 -08:00
Adlai Holler
bccfc6c779
Don't Load Table/Collection Node Just Because User Updated ( #3120 )
...
* Allow user to update collection/table without forcing view to load
* Capture animation enabledness
2017-03-02 10:11:30 -08:00
Michael Schneider
62c5138676
[ASDisplayNode] Fix node is showing up as black box if wrapping an UIActivityIndicatorView ( #3121 )
...
* Set the node to not opaque if it’s wrapping an UIActivityIndicatorView
* Add check for subclass of UIVisualEffectView to see if the node needs to be opaque
2017-03-02 08:57:17 -08:00
Adlai Holler
18dc91ccc2
Remove ASRangeController's viewport API ( #3122 )
2017-03-02 08:38:01 +00:00
appleguy
edd2ce98f7
[ASRangeController] Optimize calls into UICollectionViewLayout via union rect technique. ( #3102 )
...
Details in https://github.com/facebook/AsyncDisplayKit/issues/3082
2017-03-01 21:06:18 -08:00
appleguy
f7dbb2013e
[ASCollectionView] Interop mode should always call sizeForItem: method for index paths that don't use ASCellNodes. ( #3115 )
2017-03-01 19:57:51 -08:00
Garrett Moon
40d3a1de7a
Trying to set the progress block with a nil identifire doesn't make sense. ( #3117 )
2017-03-01 19:51:16 -08:00
Michael Schneider
67baa44fb5
Fix -Wdocumentation warnings ( #3113 )
2017-03-01 11:25:37 -08:00
Garrett Moon
06b0cba68d
It doesn't appear that this method needs to be protected by thread affinity? It has locking and is backed by an ivar, not UIKit. ( #3107 )
2017-03-01 10:57:18 -08:00
Michael Schneider
a08d9dc732
Fix warning ( #3104 )
2017-02-27 21:25:42 -08:00
Michael Schneider
1c1a1468d8
Remove all _cellsForLayoutUpdates after relayout pass happened ( #3103 )
2017-02-27 20:20:32 -08:00
Michael Schneider
973630adc6
[ASCellNode] New way to measure ASCellNode's if layout was invalidated ( #3099 )
...
* New way to informing interaction delegate if ASCellNode get’s a setNeedsLayout call
* Remove nodeDidGetNeedsLayout as optional and better check if cell updates need to happen
* Differentiate between letting a normal display node and a cell node know that the size could have changed
* Check for _interactionDelegate is nil
* Add nullability to out pointer
* Adress comments and some renaming
2017-02-27 17:19:01 -08:00
Adlai Holler
8b08b706b2
Make ASCellNode Visibility Accesses Thread-Safe ( #3100 )
...
* Make ASCellNode visibility accessing thread-safe
* Strong types!
2017-02-27 17:03:08 -08:00
Adlai Holler
25bc97c5c8
Fix Issues Repopulating Supplementary Elements ( #3098 )
...
* Fix issues repopulating supplementary elements
* Remove unrelated change
* Update comments
2017-02-27 16:06:06 -08:00
Adlai Holler
774f3ffa9e
Remove declaration of ASPhotosFrameworkImageRequest.isEqual ( #3097 )
2017-02-27 14:32:42 -08:00
Andy Madan
c7888672c8
Fix cell selection state issues ( #3081 )
...
Resolves #3037
This is a do-over of c85aa11, with the following differences:
- Fixed `_ASTableViewCell` properties **always** being mutated to match corresponding `ASCellNode` passthrough properties, even when the hosted `ASCellNode` is currently `nil`. Now only inheriting passthrough properties when there’s an actual instance of `ASCellNode` to read them from.
- Corrected spelling of `ASCellNode`’s `separatorInset` property.
- Reverted `_ASCollectionViewCell` inheriting the hosted cell node’s `backgroundColor` & `clipsToBounds` properties. This seems to be surprising and unwanted behavior to some, as seen in #3053 and #3044 .
- Moved passthrough of `UITableViewCell`’s `selectedBackgroundView` into `_ASTableViewCell`’s `-setNode:` for consistency.
2017-02-27 12:02:14 -08:00
Adlai Holler
7763356b8a
Replace IGListKit Method Macros with Actual Methods ( #3094 )
...
* Replace IGListKit macros with methods
* Remove docs in impl
* Update example
2017-02-27 11:08:39 -08:00
Huy Nguyen
9876875d4f
Allow users to set (primary) child directly on overlay and background specs ( #3092 )
2017-02-27 09:16:34 -08:00
Huy Nguyen
dc23aca30d
Fix crashes in ASElementMap and ASMutableElementMap ( #3090 )
...
* Fix crashes in ASElementMap and ASMutableElementMap
* testInitialRangeBounds to have a 10% maximum difference
2017-02-27 09:07:23 -08:00
Adlai Holler
73ca6ab514
Shuffle & Cleanup Stuff ( #3080 )
2017-02-26 18:14:13 -08:00
