appleguy 360541fac5 [ASDisplayNode] Change _pendingDisplayNodes from NSMutableSet to ASWeakSet. (#2340) ...

In at least some cases, _pendingDisplayNodes referencing self can cause the
object to live longer than the application needs, while tearing down views.

It also appears there may be a cancellation condition where this state is
not balanced properly, which can cause a reference-cycle leak.  This change
safely fixes this problem when tested against a repro case for it.

I'm filing a followup task to make sure all cancellation edge cases have
proper accounting for this codepath, even though the leak is fixed.

2016-10-04 10:22:54 -04:00

..

Details

[ASCollectionView] Allow User to Submit Updates Before Initial Data Load (#2337)

2016-10-03 19:13:50 -04:00

Layout

[Layout] Rename ASStackLayoutable to ASStackLayoutElement (#2322)

2016-09-29 12:29:21 -07:00

Private

[ASDisplayNode] Change _pendingDisplayNodes from NSMutableSet to ASWeakSet. (#2340)

2016-10-04 10:22:54 -04:00

TextKit

[Layout] Layout API based on content area (#2110)

2016-09-07 08:44:48 -07:00

_ASTransitionContext.h

Clean up header comments (for consistent Facebook licensing info) (#1741)

2016-06-11 23:31:39 -07:00

_ASTransitionContext.m

[Layout] Rename ASLayoutable to ASLayoutElement (#2290)

2016-09-29 00:02:47 -07:00

ASButtonNode.h

Add some nullability specifiers to our public headers (#2291)

2016-09-27 18:15:04 -04:00

ASButtonNode.mm

check button state before changing` (#2323)

2016-09-29 21:22:23 -07:00

ASCellNode.h

Revert "[ASCellNode] Fix applyLayoutAttributes not called, add readonly layoutAttributes property (#2321)"

2016-10-02 19:36:06 -07:00

ASCellNode.mm

Revert "[ASCellNode] Fix applyLayoutAttributes not called, add readonly layoutAttributes property (#2321)"

2016-10-02 19:36:06 -07:00

ASCellNode+Internal.h

Revert "[ASCellNode] Fix applyLayoutAttributes not called, add readonly layoutAttributes property (#2321)"

2016-10-02 19:36:06 -07:00

ASCollectionNode.h

@return is recognized by the syntax highlighter. (#2313)

2016-09-28 14:40:05 -07:00

ASCollectionNode.mm

[ASDisplayNode] Renamed range update callbacks (#2130)

2016-08-26 20:18:38 -07:00

ASCollectionNode+Beta.h

Clean up header comments (for consistent Facebook licensing info) (#1741)

2016-06-11 23:31:39 -07:00

ASCollectionView.h

[API] Remove old deprecated methods. (#2312)

2016-10-03 14:57:01 -04:00

ASCollectionView.mm

Handle nil node blocks gracefully in production (#2338)

2016-10-03 20:06:13 -04:00

ASCollectionViewLayoutFacilitatorProtocol.h

Clean up header comments (for consistent Facebook licensing info) (#1741)

2016-06-11 23:31:39 -07:00

ASCollectionViewProtocols.h

Clean up header comments (for consistent Facebook licensing info) (#1741)

2016-06-11 23:31:39 -07:00

ASContextTransitioning.h

Move Transition Layout API out of beta header and remove shouldMeasureAsync from API

2016-08-10 10:30:25 -07:00

ASControlNode.h

Clean up header comments (for consistent Facebook licensing info) (#1741)

2016-06-11 23:31:39 -07:00

ASControlNode.mm

[Infer] Fix Infer errors/warnings (#1938)

2016-07-16 15:29:24 -07:00

ASControlNode+Subclasses.h

Clean up header comments (for consistent Facebook licensing info) (#1741)

2016-06-11 23:31:39 -07:00

ASControlNode+tvOS.h

Clean up header comments (for consistent Facebook licensing info) (#1741)

2016-06-11 23:31:39 -07:00

ASControlNode+tvOS.m

Clean up header comments (for consistent Facebook licensing info) (#1741)

2016-06-11 23:31:39 -07:00

ASDisplayNode.h

Add allowsGroupOpacity property to ASDisplayNode (#2320)

2016-09-29 14:30:05 -07:00

ASDisplayNode.mm

[ASDisplayNode] Change _pendingDisplayNodes from NSMutableSet to ASWeakSet. (#2340)

2016-10-04 10:22:54 -04:00

ASDisplayNode+Beta.h

Revise performance measurement naming and structure (#2265)

2016-09-20 15:39:09 -04:00

ASDisplayNode+Deprecated.h

[API] Remove old deprecated methods. (#2312)

2016-10-03 14:57:01 -04:00

ASDisplayNode+Subclasses.h

[Layout] Rename ASLayoutable to ASLayoutElement (#2290)

2016-09-29 00:02:47 -07:00

ASDisplayNodeExtras.h

[ASDisplayNode] Ensure ASHierarchyState propagation does not jump discontinuities in the node hierarchy. (#2263)

2016-09-19 12:04:39 -07:00

ASDisplayNodeExtras.mm

[ASDisplayNode] Ensure ASHierarchyState propagation does not jump discontinuities in the node hierarchy. (#2263)

2016-09-19 12:04:39 -07:00

ASEditableTextNode.h

@return is recognized by the syntax highlighter. (#2313)

2016-09-28 14:40:05 -07:00

ASEditableTextNode.mm

Convert to type-generic math (#2050)

2016-08-09 15:31:37 -07:00

ASImageNode.h

@return is recognized by the syntax highlighter. (#2313)

2016-09-28 14:40:05 -07:00

ASImageNode.mm

[Layout] Further deprecation steps for preferredFrameSize (#2255)

2016-09-27 16:07:36 -04:00

ASImageNode+AnimatedImage.mm

[ASDisplayNode] Renamed range update callbacks (#2130)

2016-08-26 20:18:38 -07:00

ASImageNode+tvOS.h

Clean up header comments (for consistent Facebook licensing info) (#1741)

2016-06-11 23:31:39 -07:00

ASImageNode+tvOS.m

Convert to type-generic math (#2050)

2016-08-09 15:31:37 -07:00

ASMapNode.h

[ASMapNode] Add custom pin annotation for static maps (#1890)

2016-08-22 10:44:29 -07:00

ASMapNode.mm

[Layout] Layout API based on content area (#2110)

2016-09-07 08:44:48 -07:00

ASMultiplexImageNode.h

@return is recognized by the syntax highlighter. (#2313)

2016-09-28 14:40:05 -07:00

ASMultiplexImageNode.mm

[API] Remove old deprecated methods. (#2312)

2016-10-03 14:57:01 -04:00

ASNavigationController.h

Add some nullability specifiers to our public headers (#2291)

2016-09-27 18:15:04 -04:00

ASNavigationController.m

Use indexOfObjectIdenticalTo since we only care if the pointers are equal. Thanks @Adlai-Holler!

2016-07-07 11:13:18 -07:00

ASNetworkImageNode.h

@return is recognized by the syntax highlighter. (#2313)

2016-09-28 14:40:05 -07:00

ASNetworkImageNode.mm

[API] Remove old deprecated methods. (#2312)

2016-10-03 14:57:01 -04:00

ASPagerFlowLayout.h

Add some nullability specifiers to our public headers (#2291)

2016-09-27 18:15:04 -04:00

ASPagerFlowLayout.m

Clean up header comments (for consistent Facebook licensing info) (#1741)

2016-06-11 23:31:39 -07:00

ASPagerNode.h

@return is recognized by the syntax highlighter. (#2313)

2016-09-28 14:40:05 -07:00

ASPagerNode.m

[ASDisplayNode] Add Convenience Interface State Accessors (#2168)

2016-09-01 16:44:16 -07:00

ASRunLoopQueue.h

[Build settings] add missing newlines at end of file

2016-08-18 15:01:41 -07:00

ASRunLoopQueue.mm

[Infer] Fix Infer errors/warnings (#1938)

2016-07-16 15:29:24 -07:00

ASScrollNode.h

Clean up header comments (for consistent Facebook licensing info) (#1741)

2016-06-11 23:31:39 -07:00

ASScrollNode.m

Clean up header comments (for consistent Facebook licensing info) (#1741)

2016-06-11 23:31:39 -07:00

ASTabBarController.h

Add some nullability specifiers to our public headers (#2291)

2016-09-27 18:15:04 -04:00

ASTabBarController.m

Use indexOfObjectIdenticalTo since we only care if the pointers are equal. Thanks @Adlai-Holler!

2016-07-07 11:13:18 -07:00

ASTableNode.h

Add some nullability specifiers to our public headers (#2291)

2016-09-27 18:15:04 -04:00

ASTableNode.mm

[ASDisplayNode] Renamed range update callbacks (#2130)

2016-08-26 20:18:38 -07:00

ASTableView.h

[API] Remove old deprecated methods. (#2312)

2016-10-03 14:57:01 -04:00

ASTableView.mm

Handle nil node blocks gracefully in production (#2338)

2016-10-03 20:06:13 -04:00

ASTableViewInternal.h

* Tidy the header imports, forward declaring classes and protocols where appropriate to avoid import cycles and using the framework/system header notation for imports occuring in .h files.

2016-07-07 15:12:19 +10:00

ASTableViewProtocols.h

Clean up header comments (for consistent Facebook licensing info) (#1741)

2016-06-11 23:31:39 -07:00

ASTextNode.h

[ASTextNode] Actually deprecate attributedString property (#2151)

2016-09-01 16:43:03 -07:00

ASTextNode.mm

Disable ASTextKitRenderer cache (#2315)

2016-09-28 16:42:06 -04:00

ASTextNode+Beta.h

Add some nullability specifiers to our public headers (#2291)

2016-09-27 18:15:04 -04:00

ASVideoNode.h

[API] Remove old deprecated methods. (#2312)

2016-10-03 14:57:01 -04:00

ASVideoNode.mm

[API] Remove old deprecated methods. (#2312)

2016-10-03 14:57:01 -04:00

ASVideoPlayerNode.h

[ASVideoPlayerNode] Expose the UIActivityIndicatorViewStyle to clients (#1911)

2016-07-29 11:09:38 -07:00

ASVideoPlayerNode.mm

[Layout] Rename ASLayoutable to ASLayoutElement (#2290)

2016-09-29 00:02:47 -07:00

ASViewController.h

Enable ASRangeControllerUpdateRangeProtocol by default if view controller or node support it. (#2133)

2016-08-25 21:18:04 -07:00

ASViewController.mm

Fix ASViewController accessing traitCollection on iOS 7 (#2259)

2016-09-16 08:52:09 -07:00

ASVisibilityProtocols.h

Add some nullability specifiers to our public headers (#2291)

2016-09-27 18:15:04 -04:00

ASVisibilityProtocols.m

[Build settings] add missing newlines at end of file

2016-08-18 15:01:41 -07:00

AsyncDisplayKit-Prefix.pch

[Build settings] add missing newlines at end of file

2016-08-18 15:01:41 -07:00

AsyncDisplayKit.h

Introduce ASSectionContext and ASSection (#2178)

2016-10-01 14:04:05 -04:00

AsyncDisplayKit+Debug.h

Add some nullability specifiers to our public headers (#2291)

2016-09-27 18:15:04 -04:00

AsyncDisplayKit+Debug.m

[Layout] Layout API based on content area (#2110)

2016-09-07 08:44:48 -07:00

module.modulemap

…

UIImage+ASConvenience.h

Add some nullability specifiers to our public headers (#2291)

2016-09-27 18:15:04 -04:00

UIImage+ASConvenience.m

Simplify/optimize rounded image generation (#2292)

2016-09-27 18:42:46 -04:00