mirror of
https://github.com/Swiftgram/Telegram-iOS.git
synced 2025-09-10 14:35:42 +00:00
8986838b48
* Add move detection and support to ASLayoutTransition ...and NSArray+Diffing. Add some tests. * Update CHANGELOG.md * Update CHANGELOG.md * Update ASLayout+IGListKit.h * Update ASLayout+IGListKit.mm * Use std collections to avoid NSNumber boxing * Update ASLayoutTransition.mm * Code review updates. * Use `unordered_multimap` on stack instead of unordered_map<id,queue> on heap * Remove notFound BOOL (use NSNotFound sentinel value) and put some vars inside the if (insertions/moves) loop * Don't copy defaultCompare block (redundant under ARC) * Whitespace * Remove unneeded mutableCopy-s in ArrayDiffingTests * Code review updates. * Type _subnodeMoves pair.first to ASDisplayNode * instead of id * C++ enumeration * unowned refs for adding previousLayout nodes to _subnodeMoves * Remove unreleated ASDynamicCast that is probably right though * Add commentary to NSArray+Diffing.h; make multimap elements unowned * Use std::make_pair, optimize ASLayout+IGListKit * Oops I thought I had added these headers but nope * Simplify simplify * Diff subnodes instead of sublayouts * Another randomized test with actual ASLayouts
322 lines
11 KiB
Objective-C
322 lines
11 KiB
Objective-C
//
|
|
// ArrayDiffingTests.m
|
|
// Texture
|
|
//
|
|
// Created by Levi McCallum on 1/29/16.
|
|
//
|
|
// Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the /ASDK-Licenses directory of this source tree. An additional
|
|
// grant of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// Modifications to this file made after 4/13/2017 are: Copyright (c) 2017-present,
|
|
// Pinterest, Inc. Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
|
|
#import <XCTest/XCTest.h>
|
|
|
|
#import <AsyncDisplayKit/NSArray+Diffing.h>
|
|
|
|
@interface NSArray (ArrayDiffingTests)
|
|
- (NSIndexSet *)_asdk_commonIndexesWithArray:(NSArray *)array compareBlock:(BOOL (^)(id lhs, id rhs))comparison;
|
|
@end
|
|
|
|
@interface ArrayDiffingTests : XCTestCase
|
|
|
|
@end
|
|
|
|
@implementation ArrayDiffingTests
|
|
|
|
- (void)testDiffingCommonIndexes
|
|
{
|
|
NSArray<NSArray *> *tests = @[
|
|
@[
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[@"bob", @"alice", @"dave", @"gary"],
|
|
@[@0, @1, @2]
|
|
],
|
|
@[
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[@"bob", @"gary", @"dave"],
|
|
@[@0, @2]
|
|
],
|
|
@[
|
|
@[@"bob", @"alice"],
|
|
@[@"gary", @"dave"],
|
|
@[],
|
|
],
|
|
@[
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[],
|
|
@[],
|
|
],
|
|
@[
|
|
@[],
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[],
|
|
],
|
|
];
|
|
|
|
for (NSArray *test in tests) {
|
|
NSIndexSet *indexSet = [test[0] _asdk_commonIndexesWithArray:test[1] compareBlock:^BOOL(id lhs, id rhs) {
|
|
return [lhs isEqual:rhs];
|
|
}];
|
|
NSMutableIndexSet *mutableIndexSet = [indexSet mutableCopy];
|
|
|
|
for (NSNumber *index in (NSArray *)test[2]) {
|
|
XCTAssert([indexSet containsIndex:[index integerValue]]);
|
|
[mutableIndexSet removeIndex:[index integerValue]];
|
|
}
|
|
|
|
XCTAssert([mutableIndexSet count] == 0, @"Unaccounted deletions: %@", mutableIndexSet);
|
|
}
|
|
}
|
|
|
|
- (void)testDiffingInsertionsAndDeletions {
|
|
NSArray<NSArray *> *tests = @[
|
|
@[
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[@"bob", @"alice", @"dave", @"gary"],
|
|
@[@3],
|
|
@[],
|
|
],
|
|
@[
|
|
@[@"a", @"b", @"c", @"d"],
|
|
@[@"d", @"c", @"b", @"a"],
|
|
@[@1, @2, @3],
|
|
@[@0, @1, @2],
|
|
],
|
|
@[
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[@"bob", @"gary", @"alice", @"dave"],
|
|
@[@1],
|
|
@[],
|
|
],
|
|
@[
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[@"bob", @"alice"],
|
|
@[],
|
|
@[@2],
|
|
],
|
|
@[
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[],
|
|
@[],
|
|
@[@0, @1, @2],
|
|
],
|
|
@[
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[@"gary", @"alice", @"dave", @"jack"],
|
|
@[@0, @3],
|
|
@[@0],
|
|
],
|
|
@[
|
|
@[@"bob", @"alice", @"dave", @"judy", @"lynda", @"tony"],
|
|
@[@"gary", @"bob", @"suzy", @"tony"],
|
|
@[@0, @2],
|
|
@[@1, @2, @3, @4],
|
|
],
|
|
@[
|
|
@[@"bob", @"alice", @"dave", @"judy"],
|
|
@[@"judy", @"dave", @"alice", @"bob"],
|
|
@[@1, @2, @3],
|
|
@[@0, @1, @2],
|
|
],
|
|
];
|
|
|
|
long n = 0;
|
|
for (NSArray *test in tests) {
|
|
NSIndexSet *insertions, *deletions;
|
|
[test[0] asdk_diffWithArray:test[1] insertions:&insertions deletions:&deletions];
|
|
NSMutableIndexSet *mutableInsertions = [insertions mutableCopy];
|
|
NSMutableIndexSet *mutableDeletions = [deletions mutableCopy];
|
|
|
|
for (NSNumber *index in (NSArray *)test[2]) {
|
|
XCTAssert([mutableInsertions containsIndex:[index integerValue]], @"Test #%ld: insertions %@ does not contain %@",
|
|
n, insertions, index);
|
|
[mutableInsertions removeIndex:[index integerValue]];
|
|
}
|
|
for (NSNumber *index in (NSArray *)test[3]) {
|
|
XCTAssert([mutableDeletions containsIndex:[index integerValue]], @"Test #%ld: deletions %@ does not contain %@",
|
|
n, deletions, index
|
|
);
|
|
[mutableDeletions removeIndex:[index integerValue]];
|
|
}
|
|
|
|
XCTAssert([mutableInsertions count] == 0, @"Test #%ld: Unaccounted insertions: %@", n, mutableInsertions);
|
|
XCTAssert([mutableDeletions count] == 0, @"Test #%ld: Unaccounted deletions: %@", n, mutableDeletions);
|
|
n++;
|
|
}
|
|
}
|
|
|
|
- (void)testDiffingInsertsDeletesAndMoves
|
|
{
|
|
NSArray<NSArray *> *tests = @[
|
|
@[
|
|
@[@"a", @"b"],
|
|
@[@"b", @"a"],
|
|
@[],
|
|
@[],
|
|
@[[NSIndexPath indexPathWithIndexes:(NSUInteger[]) {1, 0} length:2],
|
|
[NSIndexPath indexPathWithIndexes:(NSUInteger[]) {0, 1} length:2]
|
|
]],
|
|
@[
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[@"bob", @"alice", @"dave", @"gary"],
|
|
@[@3],
|
|
@[],
|
|
@[]],
|
|
@[
|
|
@[@"a", @"b", @"c", @"d"],
|
|
@[@"d", @"c", @"b", @"a"],
|
|
@[],
|
|
@[],
|
|
@[[NSIndexPath indexPathWithIndexes:(NSUInteger[]){3, 0} length:2],
|
|
[NSIndexPath indexPathWithIndexes:(NSUInteger[]){2, 1} length:2],
|
|
[NSIndexPath indexPathWithIndexes:(NSUInteger[]){1, 2} length:2],
|
|
[NSIndexPath indexPathWithIndexes:(NSUInteger[]){0, 3} length:2]
|
|
]],
|
|
@[
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[@"bob", @"gary", @"dave", @"alice"],
|
|
@[@1],
|
|
@[],
|
|
@[[NSIndexPath indexPathWithIndexes:(NSUInteger[]) {1, 3} length:2]
|
|
]],
|
|
@[
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[@"bob", @"alice"],
|
|
@[],
|
|
@[@2],
|
|
@[]],
|
|
@[
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[],
|
|
@[],
|
|
@[@0, @1, @2],
|
|
@[]],
|
|
@[
|
|
@[@"bob", @"alice", @"dave"],
|
|
@[@"gary", @"alice", @"dave", @"jack"],
|
|
@[@0, @3],
|
|
@[@0],
|
|
@[]],
|
|
@[
|
|
@[@"bob", @"alice", @"dave", @"judy", @"lynda", @"tony"],
|
|
@[@"gary", @"bob", @"suzy", @"tony"],
|
|
@[@0, @2],
|
|
@[@1, @2, @3, @4],
|
|
@[[NSIndexPath indexPathWithIndexes:(NSUInteger[]){0, 1} length:2],
|
|
[NSIndexPath indexPathWithIndexes:(NSUInteger[]){5, 3} length:2]
|
|
]],
|
|
@[
|
|
@[@"bob", @"alice", @"dave", @"judy"],
|
|
@[@"judy", @"dave", @"alice", @"bob"],
|
|
@[],
|
|
@[],
|
|
@[[NSIndexPath indexPathWithIndexes:(NSUInteger[]){3, 0} length:2],
|
|
[NSIndexPath indexPathWithIndexes:(NSUInteger[]){2, 1} length:2],
|
|
[NSIndexPath indexPathWithIndexes:(NSUInteger[]){1, 2} length:2],
|
|
[NSIndexPath indexPathWithIndexes:(NSUInteger[]){0, 3} length:2]
|
|
]]
|
|
|
|
];
|
|
|
|
long n = 0;
|
|
for (NSArray *test in tests) {
|
|
NSIndexSet *insertions, *deletions;
|
|
NSArray<NSIndexPath *> *moves;
|
|
[test[0] asdk_diffWithArray:test[1] insertions:&insertions deletions:&deletions moves:&moves];
|
|
NSMutableIndexSet *mutableInsertions = [insertions mutableCopy];
|
|
NSMutableIndexSet *mutableDeletions = [deletions mutableCopy];
|
|
|
|
for (NSNumber *index in (NSArray *) test[2]) {
|
|
XCTAssert([mutableInsertions containsIndex:[index integerValue]], @"Test #%ld, insertions does not contain %ld",
|
|
n, (long)[index integerValue]);
|
|
[mutableInsertions removeIndex:(NSUInteger) [index integerValue]];
|
|
}
|
|
for (NSNumber *index in (NSArray *) test[3]) {
|
|
XCTAssert([mutableDeletions containsIndex:[index integerValue]], @"Test #%ld, deletions does not contain %ld",
|
|
n, (long)[index integerValue]);
|
|
[mutableDeletions removeIndex:(NSUInteger) [index integerValue]];
|
|
}
|
|
|
|
XCTAssert([mutableInsertions count] == 0, @"Test #%ld, Unaccounted insertions: %@", n, mutableInsertions);
|
|
XCTAssert([mutableDeletions count] == 0, @"Test #%ld, Unaccounted deletions: %@", n, mutableDeletions);
|
|
|
|
XCTAssert([moves isEqual:test[4]], @"Test #%ld, %@ !isEqual: %@", n, moves, test[4]);
|
|
n++;
|
|
}
|
|
}
|
|
|
|
- (void)testArrayDiffingRebuildingWithRandomElements
|
|
{
|
|
NSArray<NSNumber *> *original = @[];
|
|
NSArray<NSNumber *> *pending = @[];
|
|
|
|
NSIndexSet *insertions = nil;
|
|
NSIndexSet *deletions = nil;
|
|
NSArray<NSIndexPath *> *moves;
|
|
|
|
for (int testNumber = 0; testNumber <= 25; testNumber++) {
|
|
int len = arc4random_uniform(10);
|
|
for (int j = 0; j < len; j++) {
|
|
original = [original arrayByAddingObject:@(arc4random_uniform(25))];
|
|
}
|
|
len = arc4random_uniform(10);
|
|
for (int j = 0; j < len; j++) {
|
|
pending = [pending arrayByAddingObject:@(arc4random_uniform(25))];
|
|
}
|
|
// Some sequences that presented issues in the past:
|
|
if (testNumber == 0) {
|
|
original = @[@20, @11, @14, @2, @14, @5, @4, @18, @0];
|
|
pending = @[@9, @18, @18, @19, @20, @18, @22, @10, @3];
|
|
}
|
|
if (testNumber == 1) {
|
|
original = @[@5, @9, @21, @11, @5, @9, @8];
|
|
pending = @[@2, @12, @17, @19, @9, @1, @8, @5, @21];
|
|
}
|
|
if (testNumber == 2) {
|
|
original = @[@14, @14, @12, @8, @20, @4, @0, @10];
|
|
pending = @[@14];
|
|
}
|
|
|
|
[original asdk_diffWithArray:pending insertions:&insertions deletions:&deletions moves:&moves];
|
|
|
|
NSMutableArray *deletionsList = [NSMutableArray new];
|
|
[deletions enumerateIndexesUsingBlock:^(NSUInteger idx, BOOL *stop) {
|
|
[deletionsList addObject:@(idx)];
|
|
}];
|
|
NSMutableArray *insertionsList = [NSMutableArray new];
|
|
[insertions enumerateIndexesUsingBlock:^(NSUInteger idx, BOOL *stop) {
|
|
[insertionsList addObject:@(idx)];
|
|
}];
|
|
|
|
NSUInteger i = 0;
|
|
NSUInteger j = 0;
|
|
NSMutableArray<NSNumber *> *test = [NSMutableArray new];
|
|
for (NSUInteger count = 0; count < [pending count]; count++) {
|
|
if (i < [insertionsList count] && [insertionsList[i] unsignedIntegerValue] == count) {
|
|
[test addObject:pending[[insertionsList[i] unsignedIntegerValue]]];
|
|
i++;
|
|
} else if (j < [moves count] && [moves[j] indexAtPosition:1] == count) {
|
|
[test addObject:original[[moves[j] indexAtPosition:0]]];
|
|
j++;
|
|
} else {
|
|
[test addObject:original[count]];
|
|
}
|
|
}
|
|
|
|
XCTAssert([test isEqualToArray:pending], @"Did not mutate to expected new array:\n [%@] -> [%@], actual: [%@]\ninsertions: %@\nmoves: %@\ndeletions: %@",
|
|
[original componentsJoinedByString:@","], [pending componentsJoinedByString:@","], [test componentsJoinedByString:@","],
|
|
insertions, moves, deletions);
|
|
original = @[];
|
|
pending = @[];
|
|
}
|
|
}
|
|
@end
|