mirror of
https://github.com/Swiftgram/Telegram-iOS.git
synced 2025-09-11 23:14:48 +00:00
* Separate dataSource & UIKit index spaces Beef up our supplementary node support Make the API way better Go nuts Add a unit test for UICollectionView's handling of reloadData inside batch updates Wrap indexPathForNode: in a cache Convert index paths in delegate methods Go back on table view Put collection view back Switch up the API Move most ASCollectionView API to ASCollectionNode Move most table logic over to ASTableNode Do the things More conversion work Keep on keepin' on Get table view delegate API done More porting Simplify Clear the delegate More cleanup Move more stuff around Remove pointless file Re-add some API Put back more API Use the right flag * Some cleanup * Remove incorrect comment * Tweak the API * Put back a couple methods * update example projects (note: ASCollectionView deprecation warnings expected) * change reloadDataWithCompletion:nil --> reloadData * Clean up rebase * Make deprecated numberOfItemsInSection methods optional * Use the right flag * Address nits * update ASDKTube, ASDKgram & ASViewController examples
165 lines
7.4 KiB
Objective-C
165 lines
7.4 KiB
Objective-C
//
|
||
// ASUICollectionViewTests.m
|
||
// AsyncDisplayKit
|
||
//
|
||
// Created by Adlai Holler on 8/18/16.
|
||
// Copyright © 2016 Facebook. All rights reserved.
|
||
//
|
||
|
||
#import <XCTest/XCTest.h>
|
||
#import <OCMock/OCMock.h>
|
||
#import <OCMock/NSInvocation+OCMAdditions.h>
|
||
|
||
@interface ASUICollectionViewTests : XCTestCase
|
||
|
||
@end
|
||
|
||
@implementation ASUICollectionViewTests
|
||
|
||
/// Test normal item-affiliated supplementary node
|
||
- (void)testNormalTwoIndexSupplementaryElement
|
||
{
|
||
[self _testSupplementaryNodeAtIndexPath:[NSIndexPath indexPathForItem:0 inSection:1] sectionCount:2 expectException:NO];
|
||
}
|
||
|
||
/// If your supp is indexPathForItem:inSection:, the section index must be in bounds
|
||
- (void)testThatSupplementariesWithItemIndexesMustBeWithinNormalSections
|
||
{
|
||
[self _testSupplementaryNodeAtIndexPath:[NSIndexPath indexPathForItem:0 inSection:3] sectionCount:2 expectException:YES];
|
||
}
|
||
|
||
/// If your supp is indexPathWithIndex:, that's OK even if that section is out of bounds!
|
||
- (void)testThatSupplementariesWithOneIndexAreOKOutOfSectionBounds
|
||
{
|
||
[self _testSupplementaryNodeAtIndexPath:[NSIndexPath indexPathWithIndex:3] sectionCount:2 expectException:NO];
|
||
}
|
||
|
||
- (void)testThatNestedBatchCompletionsAreCalledInOrder
|
||
{
|
||
UICollectionViewLayout *layout = [[UICollectionViewLayout alloc] init];
|
||
id layoutMock = [OCMockObject partialMockForObject:layout];
|
||
|
||
UICollectionView *cv = [[UICollectionView alloc] initWithFrame:CGRectMake(0, 0, 100, 100) collectionViewLayout:layoutMock];
|
||
id dataSource = [OCMockObject niceMockForProtocol:@protocol(UICollectionViewDataSource)];
|
||
|
||
cv.dataSource = dataSource;
|
||
|
||
XCTestExpectation *inner0 = [self expectationWithDescription:@"Inner completion 0 is called"];
|
||
XCTestExpectation *inner1 = [self expectationWithDescription:@"Inner completion 1 is called"];
|
||
XCTestExpectation *outer = [self expectationWithDescription:@"Outer completion is called"];
|
||
|
||
NSMutableArray<XCTestExpectation *> *completions = [NSMutableArray array];
|
||
|
||
[cv performBatchUpdates:^{
|
||
[cv performBatchUpdates:^{
|
||
|
||
} completion:^(BOOL finished) {
|
||
[completions addObject:inner0];
|
||
[inner0 fulfill];
|
||
}];
|
||
[cv performBatchUpdates:^{
|
||
|
||
} completion:^(BOOL finished) {
|
||
[completions addObject:inner1];
|
||
[inner1 fulfill];
|
||
}];
|
||
} completion:^(BOOL finished) {
|
||
[completions addObject:outer];
|
||
[outer fulfill];
|
||
}];
|
||
|
||
[self waitForExpectationsWithTimeout:5 handler:nil];
|
||
XCTAssertEqualObjects(completions, (@[ outer, inner0, inner1 ]), @"Expected completion order to be correct");
|
||
}
|
||
|
||
- (void)_testSupplementaryNodeAtIndexPath:(NSIndexPath *)indexPath sectionCount:(NSInteger)sectionCount expectException:(BOOL)shouldFail
|
||
{
|
||
UICollectionViewLayoutAttributes *attr = [UICollectionViewLayoutAttributes layoutAttributesForSupplementaryViewOfKind:@"SuppKind" withIndexPath:indexPath];
|
||
attr.frame = CGRectMake(0, 0, 20, 20);
|
||
UICollectionViewLayout *layout = [[UICollectionViewLayout alloc] init];
|
||
id layoutMock = [OCMockObject partialMockForObject:layout];
|
||
|
||
[[[[layoutMock expect] ignoringNonObjectArgs] andReturn:@[ attr ]] layoutAttributesForElementsInRect:CGRectZero];
|
||
UICollectionView *cv = [[UICollectionView alloc] initWithFrame:CGRectMake(0, 0, 100, 100) collectionViewLayout:layoutMock];
|
||
[cv registerClass:[UICollectionReusableView class] forSupplementaryViewOfKind:@"SuppKind" withReuseIdentifier:@"ReuseID"];
|
||
|
||
id dataSource = [OCMockObject niceMockForProtocol:@protocol(UICollectionViewDataSource)];
|
||
__block id view = nil;
|
||
[[[dataSource expect] andDo:^(NSInvocation *invocation) {
|
||
NSIndexPath *indexPath = [invocation getArgumentAtIndexAsObject:4];
|
||
view = [cv dequeueReusableSupplementaryViewOfKind:@"SuppKind" withReuseIdentifier:@"ReuseID" forIndexPath:indexPath];
|
||
[invocation setReturnValue:&view];
|
||
}] collectionView:cv viewForSupplementaryElementOfKind:@"SuppKind" atIndexPath:indexPath];
|
||
[[[dataSource expect] andReturnValue:[NSNumber numberWithInteger:sectionCount]] numberOfSectionsInCollectionView:cv];
|
||
|
||
cv.dataSource = dataSource;
|
||
if (shouldFail) {
|
||
XCTAssertThrowsSpecificNamed([cv layoutIfNeeded], NSException, NSInternalInconsistencyException);
|
||
} else {
|
||
[cv layoutIfNeeded];
|
||
XCTAssertEqualObjects(attr, [cv layoutAttributesForSupplementaryElementOfKind:@"SuppKind" atIndexPath:indexPath]);
|
||
XCTAssertEqual(view, [cv supplementaryViewForElementKind:@"SuppKind" atIndexPath:indexPath]);
|
||
}
|
||
|
||
[dataSource verify];
|
||
[layoutMock verify];
|
||
}
|
||
|
||
- (void)testThatIssuingAnUpdateBeforeInitialReloadIsUnacceptable
|
||
{
|
||
UICollectionViewFlowLayout *layout = [[UICollectionViewFlowLayout alloc] init];
|
||
UICollectionView *cv = [[UICollectionView alloc] initWithFrame:CGRectMake(0, 0, 100, 100) collectionViewLayout:layout];
|
||
id dataSource = [OCMockObject niceMockForProtocol:@protocol(UICollectionViewDataSource)];
|
||
|
||
// Setup empty data source – 0 sections, 0 items
|
||
[[[dataSource stub] andDo:^(NSInvocation *invocation) {
|
||
NSIndexPath *indexPath = [invocation getArgumentAtIndexAsObject:3];
|
||
__autoreleasing UICollectionViewCell *view = [cv dequeueReusableCellWithReuseIdentifier:@"CellID" forIndexPath:indexPath];
|
||
[invocation setReturnValue:&view];
|
||
}] collectionView:cv cellForItemAtIndexPath:OCMOCK_ANY];
|
||
[[[dataSource stub] andReturnValue:[NSNumber numberWithInteger:0]] numberOfSectionsInCollectionView:cv];
|
||
[[[dataSource stub] andReturnValue:[NSNumber numberWithInteger:0]] collectionView:cv numberOfItemsInSection:0];
|
||
[cv registerClass:[UICollectionViewCell class] forCellWithReuseIdentifier:@"CellID"];
|
||
cv.dataSource = dataSource;
|
||
|
||
// Update data source – 1 section, 0 items
|
||
[[[dataSource stub] andReturnValue:[NSNumber numberWithInteger:1]] numberOfSectionsInCollectionView:cv];
|
||
|
||
/**
|
||
* Inform collection view – insert section 0
|
||
* Throws exception because collection view never saw the data source have 0 sections.
|
||
* so it's going to read "oldSectionCount" now and get 1. It will also read
|
||
* "newSectionCount" and get 1. Then it'll throw because "oldSectionCount(1) + insertedCount(1) != newSectionCount(1)".
|
||
* To workaround this, you could add `[cv numberOfSections]` before the data source is updated to
|
||
* trigger the collection view to read oldSectionCount=0.
|
||
*/
|
||
XCTAssertThrowsSpecificNamed([cv insertSections:[NSIndexSet indexSetWithIndex:0]], NSException, NSInternalInconsistencyException);
|
||
}
|
||
|
||
// If you put reloadData in a batch update, collection view will ignore it and perform the normal
|
||
// update validation i.e. throw an exception if your data source counts changed.
|
||
- (void)testThatPuttingReloadDataInABatchUpdateDoesntWork
|
||
{
|
||
UICollectionViewLayout *layout = [[UICollectionViewLayout alloc] init];
|
||
UICollectionView *cv = [[UICollectionView alloc] initWithFrame:CGRectMake(0, 0, 100, 100) collectionViewLayout:layout];
|
||
id dataSource = [OCMockObject niceMockForProtocol:@protocol(UICollectionViewDataSource)];
|
||
// Start data source at 1 section, 1 item
|
||
[[[dataSource stub] andReturnValue:[NSNumber numberWithInteger:1]] numberOfSectionsInCollectionView:cv];
|
||
[[[dataSource expect] andReturnValue:[NSNumber numberWithInteger:1]] collectionView:cv numberOfItemsInSection:0];
|
||
|
||
cv.dataSource = dataSource;
|
||
|
||
// Verify initial data.
|
||
XCTAssertEqual([cv numberOfSections], 1);
|
||
XCTAssertEqual([cv numberOfItemsInSection:0], 1);
|
||
[dataSource verify];
|
||
|
||
XCTAssertThrows([cv performBatchUpdates:^{
|
||
// Change data source to 1 section, 2 items
|
||
[[[dataSource stub] andReturnValue:[NSNumber numberWithInteger:2]] collectionView:cv numberOfItemsInSection:0];
|
||
[cv reloadData];
|
||
} completion:nil]);
|
||
}
|
||
|
||
@end
|