mirror of
https://github.com/Swiftgram/Telegram-iOS.git
synced 2025-12-29 17:31:56 +00:00
74c6cca0b6
* Refactor ASDataController Check optional methods in ASDataControllerSource * Reimplement reloadData * Refactor new code - No more new/inserted contexts flag - Encapsulate code shared between reloadData and updateWithChangeSet - Remove dataControllerWillDeleteAllData delegate method - Hierarchy changes no longer needs to conform to NSCopying - Reword TODOs * Forgot to call completion block of reloadData :P * Completion block of -[ASDataController reloadDataWithCompletion:] is nullable * Data queried from ASCollectionNode and ASTableNode should be in UIKit index space - This helps to avoid immature node allocation, especially when node virtualization is a thing - However, this means that -reloadDataInitiallyIfNeeded in ASCollectionNode and ASTableNode must wait until all updates are finished. * ASDataController shouldn't assume that allocated nodes were also laid out * Revert "Data queried from ASCollectionNode and ASTableNode should be in UIKit index space" This reverts commit 7bc977b3808a92f484b297781d0f5b30aa258e17. * -nodeAtIndexPath: of ASDataController now forces node allocation, with the assumption that clients absolutely need it. - Revisit this when node virtualization is implemented. * ASDataController only grab changeSet.completionHandler when needed because it'll be niled out * Fix ASTableViewTests related to reloadData * Fix testThatDeletedItemsAreMarkedInvisible in ASCollectionViewTests * Minor changes in ASCollectionView and ASTableView * ASCollectionView and ASTableView shouldn't call [super reloadData] before their data controller does anything * Address comments * Fuse reloadData into -updateWithChangeSet: of ASDataController * reloadData shouldn't be called as if it's inside a batch - It can't be used in conjuntion with other updates. - Calling it inside a batch update during the initial load can cause data inconsistency thrown by UICollectionView/UITableView * Refactor ASDataControllerDelegate and ASRangeControllerDelegate - Replace delegate methods in these protocols with -willUpdateWithChangeSet and -didUpdateWithChangeSet. - ASRangeController, ASCollectionView and ASTableView are simplified because of this. * Fix mismatch between sorting orders in ASDataController * Forgot to call completion handler of reload change sets * Make sure ASCollectionView is compatible with the behavior of UICollectionView's reloadData - Since UICollectionView's reloadData doesn't requery data source but defers until the next layout pass, we need to wait until then to update range controller and do batch fetching. - `-[ASCollectionView waitUntilAllUpdatesAreCommited]` needs to force a layout pass to make sure everything is ready after it returns. * testSectionIndexHandling of ASTableViewTests should only check visible nodes. Other nodes will be re-measured later. * ASTableView is not ready until the first layout pass finished * Address comments * Bug fixes
80 lines
3.0 KiB
Objective-C
80 lines
3.0 KiB
Objective-C
//
|
|
// ASCollectionViewLayoutInspector.m
|
|
// AsyncDisplayKit
|
|
//
|
|
// Created by Garrett Moon on 11/19/16.
|
|
// Copyright © 2016 Facebook. All rights reserved.
|
|
//
|
|
|
|
#import <AsyncDisplayKit/ASCollectionViewLayoutInspector.h>
|
|
|
|
#import <AsyncDisplayKit/ASCollectionView.h>
|
|
#import <AsyncDisplayKit/ASCollectionView+Undeprecated.h>
|
|
#import <AsyncDisplayKit/ASCollectionNode.h>
|
|
|
|
#pragma mark - Helper Functions
|
|
|
|
// Returns a constrained size to let the cells layout itself as far as possible based on the scrollable direction
|
|
// of the collection view
|
|
ASSizeRange NodeConstrainedSizeForScrollDirection(ASCollectionView *collectionView) {
|
|
CGSize maxSize = collectionView.bounds.size;
|
|
if (ASScrollDirectionContainsHorizontalDirection(collectionView.scrollableDirections)) {
|
|
maxSize.width = CGFLOAT_MAX;
|
|
} else {
|
|
maxSize.height = CGFLOAT_MAX;
|
|
}
|
|
return ASSizeRangeMake(CGSizeZero, maxSize);
|
|
}
|
|
|
|
#pragma mark - ASCollectionViewLayoutInspector
|
|
|
|
@implementation ASCollectionViewLayoutInspector {
|
|
struct {
|
|
unsigned int implementsConstrainedSizeForNodeAtIndexPathDeprecated:1;
|
|
unsigned int implementsConstrainedSizeForNodeAtIndexPath:1;
|
|
} _delegateFlags;
|
|
}
|
|
|
|
#pragma mark Lifecycle
|
|
|
|
- (instancetype)initWithCollectionView:(ASCollectionView *)collectionView
|
|
{
|
|
return [self init];
|
|
}
|
|
|
|
#pragma mark ASCollectionViewLayoutInspecting
|
|
|
|
- (void)didChangeCollectionViewDelegate:(id<ASCollectionDelegate>)delegate
|
|
{
|
|
if (delegate == nil) {
|
|
memset(&_delegateFlags, 0, sizeof(_delegateFlags));
|
|
} else {
|
|
_delegateFlags.implementsConstrainedSizeForNodeAtIndexPathDeprecated = [delegate respondsToSelector:@selector(collectionView:constrainedSizeForNodeAtIndexPath:)];
|
|
_delegateFlags.implementsConstrainedSizeForNodeAtIndexPath = [delegate respondsToSelector:@selector(collectionNode:constrainedSizeForItemAtIndexPath:)];
|
|
}
|
|
}
|
|
|
|
- (ASSizeRange)collectionView:(ASCollectionView *)collectionView constrainedSizeForNodeAtIndexPath:(NSIndexPath *)indexPath
|
|
{
|
|
if (_delegateFlags.implementsConstrainedSizeForNodeAtIndexPath) {
|
|
return [collectionView.asyncDelegate collectionNode:collectionView.collectionNode constrainedSizeForItemAtIndexPath:indexPath];
|
|
} else if (_delegateFlags.implementsConstrainedSizeForNodeAtIndexPathDeprecated) {
|
|
#pragma clang diagnostic push
|
|
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
|
|
return [collectionView.asyncDelegate collectionView:collectionView constrainedSizeForNodeAtIndexPath:indexPath];
|
|
#pragma clang diagnostic pop
|
|
} else {
|
|
// With 2.0 `collectionView:constrainedSizeForNodeAtIndexPath:` was moved to the delegate. Assert if not implemented on the delegate but on the data source
|
|
ASDisplayNodeAssert([collectionView.asyncDataSource respondsToSelector:@selector(collectionView:constrainedSizeForNodeAtIndexPath:)] == NO, @"collectionView:constrainedSizeForNodeAtIndexPath: was moved from the ASCollectionDataSource to the ASCollectionDelegate.");
|
|
}
|
|
|
|
return NodeConstrainedSizeForScrollDirection(collectionView);
|
|
}
|
|
|
|
- (ASScrollDirection)scrollableDirections
|
|
{
|
|
return ASScrollDirectionNone;
|
|
}
|
|
|
|
@end
|