Huy Nguyen e70325563a

Only clear ASCollectionView's data during deallocation (#1154) ...

This is a follow up on #1136. Our experiment results show that clearing data frequently is the cause of our #1 crash. @maicki and I believe that this is because if the collection view is being used, silently clearing its data without notifying the backing UICollectionView can put it out-of-sync and causes mayhem next time the collection view processes a batch update. If you look at the stack trace closely, you'll notice that the crash doesn't occur on the same run loop that clearData is called. This made it extremely tricky to investigate and identify the root cause.

Another interesting question would be whether or not we want to clear the data during deallocation at all, since the data will be cleared out soon anyway.

2018-10-03 16:14:01 -07:00

..

Base

Don't copy onDidLoadBlocks #trivial (#1123)

2018-09-17 12:40:18 -07:00

Debug

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

Details

Fix compilation warnings #trivial (#1132)

2018-09-20 07:54:10 -07:00

Layout

Remove ASRectMap, which is not worth its own weight (#1127)

2018-09-18 11:58:24 -07:00

Private

Fix compilation warnings #trivial (#1132)

2018-09-20 07:54:10 -07:00

TextKit

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

tvOS

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

_ASTransitionContext.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

_ASTransitionContext.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASBlockTypes.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASButtonNode.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASButtonNode.mm

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASCellNode.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASCellNode.mm

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASCGImageBuffer.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASCGImageBuffer.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASCollectionNode.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASCollectionNode.mm

Remove necessity to use view to access rangeController in ASTableNode, ASCollectionNode (#1103)

2018-09-19 07:51:46 -07:00

ASCollectionNode+Beta.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASCollections.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASCollections.m

Explicitly cast to (void *) -> (const void **) to satisfy strict compilers (#1098)

2018-09-05 22:49:08 -07:00

ASCollectionView.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASCollectionView.mm

Only clear ASCollectionView's data during deallocation (#1154)

2018-10-03 16:14:01 -07:00

ASCollectionViewLayoutFacilitatorProtocol.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASCollectionViewProtocols.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASConfiguration.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASConfiguration.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASConfigurationDelegate.h

Add a -textureDidInitialize delegate callback (#1100)

2018-09-06 11:08:45 -07:00

ASConfigurationInternal.h

Add a -textureDidInitialize delegate callback (#1100)

2018-09-06 11:08:45 -07:00

ASConfigurationInternal.m

Add a -textureDidInitialize delegate callback (#1100)

2018-09-06 11:08:45 -07:00

ASContextTransitioning.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASControlNode.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASControlNode.mm

#trivial Shouldn't hold the lock while adding subnodes (#1091)

2018-08-30 22:04:40 -07:00

ASControlNode+Subclasses.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASDisplayNode.h

Remove use of NSHashTable for interface state delegates #trivial (#1122)

2018-09-17 14:29:22 -07:00

ASDisplayNode.mm

Clean up timing of layout tree flattening/ copying of unflattened tree for Weaver (#1157)

2018-10-03 14:49:15 -07:00

ASDisplayNode+Beta.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASDisplayNode+Convenience.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASDisplayNode+Convenience.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASDisplayNode+InterfaceState.h

Make interface state delegate non optional (#1112)

2018-09-12 09:48:39 -07:00

ASDisplayNode+Layout.mm

Clean up timing of layout tree flattening/ copying of unflattened tree for Weaver (#1157)

2018-10-03 14:49:15 -07:00

ASDisplayNode+Subclasses.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASDisplayNode+Yoga.mm

Remove reliance on shared_ptr for ASDisplayNodeLayouts (#1131)

2018-09-19 11:23:19 -07:00

ASDisplayNodeExtras.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASDisplayNodeExtras.mm

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASEditableTextNode.h

Fix typos and minor code cleanups #trivial (#1120)

2018-09-17 13:35:00 -07:00

ASEditableTextNode.mm

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASExperimentalFeatures.h

Only clear ASCollectionView's data during deallocation (#1154)

2018-10-03 16:14:01 -07:00

ASExperimentalFeatures.m

Only clear ASCollectionView's data during deallocation (#1154)

2018-10-03 16:14:01 -07:00

ASImageNode.h

Call out to AnimatedImage subclass hook in the next runloop cycle (#1087)

2018-09-12 09:39:22 -07:00

ASImageNode.mm

Improve locking around clearContents (#1107)

2018-09-14 08:48:19 -07:00

ASImageNode+AnimatedImage.mm

Call out to AnimatedImage subclass hook in the next runloop cycle (#1087)

2018-09-12 09:39:22 -07:00

ASLocking.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASMainThreadDeallocation.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASMainThreadDeallocation.mm

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASMapNode.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASMapNode.mm

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASMultiplexImageNode.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASMultiplexImageNode.mm

Improve locking around clearContents (#1107)

2018-09-14 08:48:19 -07:00

ASNavigationController.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASNavigationController.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASNetworkImageLoadInfo.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASNetworkImageLoadInfo.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASNetworkImageNode.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASNetworkImageNode.mm

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASNodeController+Beta.h

Make interface state delegate non optional (#1112)

2018-09-12 09:48:39 -07:00

ASNodeController+Beta.mm

Make interface state delegate non optional (#1112)

2018-09-12 09:48:39 -07:00

ASPagerFlowLayout.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASPagerFlowLayout.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASPagerNode.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASPagerNode.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASPagerNode+Beta.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASRangeManagingNode.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASRunLoopQueue.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASRunLoopQueue.mm

Rollout ASDeallocQueueV2 #trivial (#1143)

2018-10-01 11:20:12 -07:00

ASScrollNode.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASScrollNode.mm

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASSectionController.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASSupplementaryNodeSource.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASTabBarController.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASTabBarController.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASTableNode.h

Remove necessity to use view to access rangeController in ASTableNode, ASCollectionNode (#1103)

2018-09-19 07:51:46 -07:00

ASTableNode.mm

Remove necessity to use view to access rangeController in ASTableNode, ASCollectionNode (#1103)

2018-09-19 07:51:46 -07:00

ASTableNode+Beta.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASTableView.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASTableView.mm

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASTableViewInternal.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASTableViewProtocols.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASTextNode2.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASTextNode2.mm

Don't copy container during ASTextNode2 layout (#1115)

2018-09-13 11:06:12 -07:00

ASTextNode.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASTextNode.mm

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASTextNode+Beta.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASTextNodeCommon.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASVideoNode.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASVideoNode.mm

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASVideoPlayerNode.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASVideoPlayerNode.mm

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASViewController.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASViewController.mm

Fix compilation warnings #trivial (#1132)

2018-09-20 07:54:10 -07:00

ASVisibilityProtocols.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

ASVisibilityProtocols.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

AsyncDisplayKit.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

AsyncDisplayKit.modulemap

Fix failing build in XCode 8.3 (#3241)

2017-04-04 14:37:45 -07:00

AsyncDisplayKit+IGListKitMethods.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

AsyncDisplayKit+IGListKitMethods.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

IGListAdapter+AsyncDisplayKit.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

IGListAdapter+AsyncDisplayKit.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

Info.plist

Shuffle & Cleanup Stuff (#3080)

2017-02-26 18:14:13 -08:00

UIImage+ASConvenience.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

UIImage+ASConvenience.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

UIResponder+AsyncDisplayKit.h

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00

UIResponder+AsyncDisplayKit.m

[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). (#1077)

2018-08-28 07:39:18 -07:00