ThePain/Swiftgram
1
0
Fork 0
mirror of https://github.com/Swiftgram/Telegram-iOS.git synced 2026-01-06 21:22:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ASImageNode] Use kCGBlendModeCopy when Possible (#2197)

Browse Source 
* [ASImageNode] Use kCGBlendModeCopy when possible

* Make the blend mode logic more readable
This commit is contained in:
Adlai Holler
2016-09-05 20:52:06 -07:00
committed by GitHub
parent e233a1cccc
commit 607ec8f4a5
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
AsyncDisplayKit/ASImageNode.mm
View File

@@ -437,15 +437,19 @@ static ASDN::Mutex cacheLock;
// will do its rounding on pixel instead of point boundaries
UIGraphicsBeginImageContextWithOptions(key.backingSize, key.isOpaque, 1.0);
BOOL contextIsClean = YES;
CGContextRef context = UIGraphicsGetCurrentContext();
if (context && key.preContextBlock) {
key.preContextBlock(context);
contextIsClean = NO;
}
// if view is opaque, fill the context with background color
if (key.isOpaque && key.backgroundColor) {
[key.backgroundColor setFill];
UIRectFill({ .size = key.backingSize });
contextIsClean = NO;
}
// iOS 9 appears to contain a thread safety regression when drawing the same CGImageRef on
@@ -460,8 +464,12 @@ static ASDN::Mutex cacheLock;
// Another option is to have ASDisplayNode+AsyncDisplay coordinate these cases, and share the decoded buffer.
// Details tracked in https://github.com/facebook/AsyncDisplayKit/issues/1068
@synchronized(key.image) {
[key.image drawInRect:key.imageDrawRect];
UIImage *image = key.image;
BOOL canUseCopy = (contextIsClean || CGImageGetAlphaInfo(image.CGImage) == kCGImageAlphaNone);
CGBlendMode blendMode = canUseCopy ? kCGBlendModeCopy : kCGBlendModeNormal;
@synchronized(image) {
[image drawInRect:key.imageDrawRect blendMode:blendMode alpha:1];
}
if (context && key.postContextBlock) {