[Umbrella] ASCollectionView -> ASCollectionNode Migration, Separate Index Spaces (#2372)

* Separate dataSource & UIKit index spaces

Beef up our supplementary node support

Make the API way better

Go nuts

Add a unit test for UICollectionView's handling of reloadData inside batch updates

Wrap indexPathForNode: in a cache

Convert index paths in delegate methods

Go back on table view

Put collection view back

Switch up the API

Move most ASCollectionView API to ASCollectionNode

Move most table logic over to ASTableNode

Do the things

More conversion work

Keep on keepin' on

Get table view delegate API done

More porting

Simplify

Clear the delegate

More cleanup

Move more stuff around

Remove pointless file

Re-add some API

Put back more API

Use the right flag

* Some cleanup

* Remove incorrect comment

* Tweak the API

* Put back a couple methods

* update example projects (note: ASCollectionView deprecation warnings expected)

* change reloadDataWithCompletion:nil --> reloadData

* Clean up rebase

* Make deprecated numberOfItemsInSection methods optional

* Use the right flag

* Address nits

* update ASDKTube, ASDKgram & ASViewController examples

AsyncDisplayKitTests/ASUICollectionViewTests.m

@@ -41,7 +41,6 @@
 
   UICollectionView *cv = [[UICollectionView alloc] initWithFrame:CGRectMake(0, 0, 100, 100) collectionViewLayout:layoutMock];
   id dataSource = [OCMockObject niceMockForProtocol:@protocol(UICollectionViewDataSource)];
-  [[[dataSource stub] andReturnValue:[NSNumber numberWithInteger:1]] collectionView:cv numberOfItemsInSection:0];
 
   cv.dataSource = dataSource;
 
@@ -137,4 +136,29 @@
   XCTAssertThrowsSpecificNamed([cv insertSections:[NSIndexSet indexSetWithIndex:0]], NSException, NSInternalInconsistencyException);
 }
 
+// If you put reloadData in a batch update, collection view will ignore it and perform the normal
+// update validation i.e. throw an exception if your data source counts changed.
+- (void)testThatPuttingReloadDataInABatchUpdateDoesntWork
+{
+  UICollectionViewLayout *layout = [[UICollectionViewLayout alloc] init];
+  UICollectionView *cv = [[UICollectionView alloc] initWithFrame:CGRectMake(0, 0, 100, 100) collectionViewLayout:layout];
+  id dataSource = [OCMockObject niceMockForProtocol:@protocol(UICollectionViewDataSource)];
+  // Start data source at 1 section, 1 item
+  [[[dataSource stub] andReturnValue:[NSNumber numberWithInteger:1]] numberOfSectionsInCollectionView:cv];
+  [[[dataSource expect] andReturnValue:[NSNumber numberWithInteger:1]] collectionView:cv numberOfItemsInSection:0];
+
+  cv.dataSource = dataSource;
+
+  // Verify initial data.
+  XCTAssertEqual([cv numberOfSections], 1);
+  XCTAssertEqual([cv numberOfItemsInSection:0], 1);
+  [dataSource verify];
+
+  XCTAssertThrows([cv performBatchUpdates:^{
+    // Change data source to 1 section, 2 items
+    [[[dataSource stub] andReturnValue:[NSNumber numberWithInteger:2]] collectionView:cv numberOfItemsInSection:0];
+    [cv reloadData];
+  } completion:nil]);
+}
+
 @end