ThePain/Swiftgram
1
0
Fork 0
mirror of https://github.com/Swiftgram/Telegram-iOS.git synced 2025-12-24 07:05:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add an experimental flag to use native dispatch_apply (#1345)

Browse Source 
* Add an experimental flag to use native dispatch_apply instead of our core count * 2 approach. This has shown performance wins in some profiling.

* Add in other places
This commit is contained in:
Adlai Holler
2019-02-21 12:33:40 -08:00
committed by Huy Nguyen
parent 8edb5a45d3
commit efeb3d2749
5 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Schemas/configuration.json
View File

@@ -25,7 +25,8 @@
"exp_did_enter_preload_skip_asm_layout",
"exp_disable_a11y_cache",
"exp_skip_a11y_wait",
"exp_new_default_cell_layout_mode"
"exp_new_default_cell_layout_mode",
"exp_dispatch_apply"
]
}
}

1
Source/ASExperimentalFeatures.h
View File

@@ -31,6 +31,7 @@ typedef NS_OPTIONS(NSUInteger, ASExperimentalFeatures) {
ASExperimentalDisableAccessibilityCache = 1 << 10, // exp_disable_a11y_cache
ASExperimentalSkipAccessibilityWait = 1 << 11, // exp_skip_a11y_wait
ASExperimentalNewDefaultCellLayoutMode = 1 << 12, // exp_new_default_cell_layout_mode
ASExperimentalDispatchApply = 1 << 13, // exp_dispatch_apply
ASExperimentalFeatureAll = 0xFFFFFFFF
};

3
Source/ASExperimentalFeatures.mm
View File

@@ -24,7 +24,8 @@ NSArray<NSString *> *ASExperimentalFeaturesGetNames(ASExperimentalFeatures flags
@"exp_did_enter_preload_skip_asm_layout",
@"exp_disable_a11y_cache",
@"exp_skip_a11y_wait",
@"exp_new_default_cell_layout_mode"]));
@"exp_new_default_cell_layout_mode",
@"exp_dispatch_apply"]));
if (flags == ASExperimentalFeatureAll) {
return allNames;

6
Source/Private/ASDispatch.mm
View File

@@ -7,6 +7,8 @@
//
#import <AsyncDisplayKit/ASDispatch.h>
#import <AsyncDisplayKit/ASConfigurationInternal.h>
// Prefer C atomics in this file because ObjC blocks can't capture C++ atomics well.
#import <stdatomic.h>
@@ -19,6 +21,10 @@
*/
void ASDispatchApply(size_t iterationCount, dispatch_queue_t queue, NSUInteger threadCount, NS_NOESCAPE void(^work)(size_t i)) {
if (threadCount == 0) {
if (ASActivateExperimentalFeature(ASExperimentalDispatchApply)) {
dispatch_apply(iterationCount, queue, work);
return;
}
threadCount = NSProcessInfo.processInfo.activeProcessorCount * 2;
}
dispatch_group_t group = dispatch_group_create();

6
Tests/ASConfigurationTests.mm
View File

@@ -30,7 +30,8 @@ static ASExperimentalFeatures features[] = {
ASExperimentalDidEnterPreloadSkipASMLayout,
ASExperimentalDisableAccessibilityCache,
ASExperimentalSkipAccessibilityWait,
ASExperimentalNewDefaultCellLayoutMode
ASExperimentalNewDefaultCellLayoutMode,
ASExperimentalDispatchApply
};
@interface ASConfigurationTests : ASTestCase <ASConfigurationDelegate>
@@ -55,7 +56,8 @@ static ASExperimentalFeatures features[] = {
@"exp_did_enter_preload_skip_asm_layout",
@"exp_disable_a11y_cache",
@"exp_skip_a11y_wait",
@"exp_new_default_cell_layout_mode"
@"exp_new_default_cell_layout_mode",
@"exp_dispatch_apply"
];
}