fix analyzer warning

it's somewhat more clear to release and set to nil,
then store a new reference directly in the ivar.
This commit is contained in:
Stephan Diederich 2013-06-20 14:24:44 +02:00
parent 070844e234
commit f1ba1b092b

View File

@ -271,11 +271,16 @@ static inline NSAttributedString * NSAttributedStringBySettingColorFromContext(N
- (CTFramesetterRef)framesetter {
if (_needsFramesetter) {
@synchronized(self) {
if (_framesetter) CFRelease(_framesetter);
if (_highlightFramesetter) CFRelease(_highlightFramesetter);
if (_framesetter) {
CFRelease(_framesetter);
_framesetter = nil;
}
if (_highlightFramesetter) {
CFRelease(_highlightFramesetter);
_highlightFramesetter = nil;
}
self.framesetter = CTFramesetterCreateWithAttributedString((__bridge CFAttributedStringRef)self.renderedAttributedText);
self.highlightFramesetter = nil;
_framesetter = CTFramesetterCreateWithAttributedString((__bridge CFAttributedStringRef)self.renderedAttributedText);
_needsFramesetter = NO;
}
}