Commit Graph

3875 Commits

Author SHA1 Message Date
Michael Schneider
018ad148bc Further work 2016-12-05 16:50:58 -08:00
Michael Schneider
d57e33b2f0 Some further improvements 2016-12-05 16:43:46 -08:00
Michael Schneider
9fefd4a5b0 Cleanup ASVideoNode a bit 2016-12-05 16:43:46 -08:00
Michael Schneider
70b647c2b9 Add support for setting a static image to ASNetworkImageNode 2016-12-05 16:43:46 -08:00
Michael Schneider
143abdaa96 Change Header of ASImageNode+Private 2016-12-05 16:43:46 -08:00
Michael Schneider
9adb6554fc Add assertion against externally setting .image in specific ASImageNode subclasses 2016-12-05 16:43:46 -08:00
Adlai Holler
42c7bb291e Merge pull request #2715 from facebook/AHMoreBatchFetching
Ensure Batch Fetching Includes Leading Screens, Even if Not Scrolling
2016-12-05 16:27:01 -08:00
Adlai Holler
20c66f1025 Beef up the tests 2016-12-05 15:37:49 -08:00
Adlai Holler
9bc58dc024 When not visible, only batch fetch to fill visible area 2016-12-05 15:00:39 -08:00
Adlai Holler
21cad90355 Ensure we always fill leading screens for batching 2016-12-05 14:51:07 -08:00
Adlai Holler
b775a1a8eb Merge pull request #2712 from facebook/AHFixAssertionMacros
Improve Assertion Macros
2016-12-05 12:54:14 -08:00
Adlai Holler
19b97a68af Fix our assertion macros 2016-12-05 11:42:26 -08:00
Michael Schneider
a2e75152f8 [ASDisplayNode] Fix flickering for nodes that support range managed interface state (#2710)
* Fix flickering for range managed nodes

* Go back to old behavior to check for range managed before calling didExitPreloadState in interface state change
2016-12-05 10:34:03 -08:00
Michael Schneider
e361d00a73 Our calculated layout is suitable for this constrainedSize, so keep using it and invalidate any pending layout that has been generated in the past. (#2706) 2016-12-02 16:17:14 -08:00
Adlai Holler
1997073802 Address Misc Warnings (#2698)
* Address compiler warnings

* Typo
2016-12-02 14:04:05 -08:00
Garrett Moon
9706b85145 Remove files that no longer exist from podfile exclusion (#2697)
* Remove files that no longer exist from podfile exclusion

* Missed some references to dealloc2main
2016-12-02 13:29:16 -08:00
Andrew Yates
8ab83504e3 Update Readme logo (#2691) 2016-12-02 13:14:53 -08:00
Garrett Moon
d9209e69c2 Update to RC 1 (#2695) 2016-12-02 10:00:15 -08:00
Adlai Holler
40a8769217 Filter out extra items when querying collection view layout (#2693) 2016-12-02 08:48:46 -08:00
Adlai Holler
8e90a31cc1 Merge pull request #2687 from maicki/MSBetterErrorMessageForDeallocatedDisplayNodeInLayout
Better error message if a display node is created in layoutSpecThatFits: and deallocated before it was added to a subnode
2016-12-01 17:39:56 -08:00
Adlai Holler
051b738236 Inject data source class name into update validation exceptions, deprecate suppression flag (#2692) 2016-12-01 17:30:36 -08:00
Garrett Moon
8f7a632f4c Add the slack channel to the issue template. (#2690) 2016-12-01 14:00:36 -08:00
Garrett Moon
ba2268ac99 2611 rename fetch data (#2689)
* Replace fetch data with preload terminology
- Deprecate `-fetchData` and `-clearFetchedData` in favor of `-preload` and `-clearPreloadedData`
- Move `-setNeedsPreload`, `-recursivelyPreload` and `-recursivelyClearPreloadedData` to ASDisplayNode+FrameworkPrivate.h
- Update internal implementation, comments and tests

* Folllow up on #2642:
- Remove -preload and -clearPreloadedData in favor of -didEnterPreloadState and -didExitPreloadState.
- -didEnterPreloadState and -didExitPreloadState call the deprecated -fetchData and -clearFetchedData methods if they are overriden.

* Missed one in a test

* Get rid of behavior change for now.

* Revert more behavior changes, fix tests.

* Don't need these anymore.
2016-12-01 13:41:22 -08:00
Michael Schneider
c7ea15a5e4 Misc improvements to ASViewController (#2653)
- Remove layoutThatFit: call in viewWillAppear:
- Deprecate nodeConstrainedSize
- Use the view’s bounds to layout the node
2016-12-01 09:56:41 -08:00
Michael Schneider
66acd69e22 Better error message if a display node is created in layoutSpecThatFits: and deallocated before it was added to a subnode 2016-12-01 07:03:39 -08:00
Adlai Holler
b075aa2851 Merge pull request #2682 from facebook/AHFixMoreDeallocVisibleCases
Fix Edge Cases of Table Cell Nodes Deallocated While Visible
2016-11-30 09:01:01 -08:00
Adlai Holler
81a04bc93b Remove magic number 2016-11-30 09:00:48 -08:00
Adlai Holler
361f7be6ed Merge pull request #2681 from facebook/2.0-beta.3
Update podspec to beta 3
2016-11-29 17:05:56 -08:00
Adlai Holler
98ef8c00de Reduce cleverness 2016-11-29 16:27:33 -08:00
Adlai Holler
3fe87ffb64 Add a test replicating Issue 2252 2016-11-29 16:19:48 -08:00
Adlai Holler
bb8d7d1be9 Modify ASTableView range code to fix interface state issues with grouped tables 2016-11-29 15:42:00 -08:00
Garrett Moon
7c685620aa Update podspec to beta 3 2016-11-29 14:58:41 -08:00
Adlai Holler
df497b82c2 Improve Batch Fetching Call Pattern to Reduce Fetch Calls (#2675)
* Test & tweak batch fetching implementation

* Tighten the test

* Stop batch fetching at the end of range controller pass

* Clean up the test

* Still check for batch fetching after each frame when scrolling

* Ensure batch fetching happens for empty collection/table
2016-11-29 13:40:03 -08:00
appleguy
aa9dff00de Merge pull request #2672 from facebook/AHRemoveVCFetch
[ASViewController] Remove Extra recursivelyFetchData Call
2016-11-29 10:46:22 -08:00
appleguy
7861c63a68 Merge pull request #2676 from maicki/MSRevertConstrainedSizeChanges
Revert constrainedSize changes that should have never made it in
2016-11-28 17:23:50 -08:00
Michael Schneider
52bb2a3a6e Revert constrainedSize changes that should have never made it in 2016-11-28 17:20:26 -08:00
Adlai Holler
b00365ac59 Remove explicit recursivelyFetchData call from ASViewController 2016-11-28 15:34:46 -08:00
Hannah Troisi
5f9e84ce28 [Examples] fix CustomCollectionView-Swift project configs (#2671)
* fix podfile

* add Sample scheme

* remove example project workspace files

* remove use_frameworks!

* add Sample scheme

* add use_frameworks! back in

* add scrollableDirections method
2016-11-28 15:33:29 -08:00
Michael Schneider
4928af4635 [Layout Transition] Layout Transition Fixes (#2657)
* Don’t call layoutIfNeeded before starting the layout transition

* Further improvements
2016-11-28 12:57:03 -08:00
Adlai Holler
a862ac230f Merge pull request #2664 from garrettmoon/enableRangeControllerMemWarning
This patch enables memory warning support on ASRangeController by def…
2016-11-28 11:30:50 -08:00
Adlai Holler
95ffbb2358 Merge pull request #2669 from facebook/IsViewLoadedMethod
Use the Method Form for UIViewController.viewLoaded – Maintains Xcode Backwards Compatibility
2016-11-28 11:28:54 -08:00
Adlai Holler
82e1c5bf0b Use the method form for UIViewController.isViewLoaded, since it is supported by Xcode 7.3.1 2016-11-28 11:12:22 -08:00
Adlai Holler
02283bd0d6 Merge pull request #2648 from maicki/MSFixASTableViewRotationGlitch
[ASTableView] Not animated for end updates if animation is already going on within ASTableView
2016-11-28 09:59:05 -08:00
Garrett Moon
04dc582a7a Rename didUpdateCurrentRangeMode to preserveCurrentRangeMode 2016-11-27 16:05:31 -08:00
Garrett Moon
62f378a9fd This patch enables memory warning support on ASRangeController by default
It also fixes a couple subtle bugs:
1. If a range controller update was in flight and you were manually setting the range
mode, you could actually clear out the range mode by calling updateCurrentRangeWithMode:
This is fixed by setting _didUpdateCurrentRange = YES if _needsRangeUpdate is YES.
2. Calling setNeedsUpdate after calling updateCurrentRangeWithMode: can cause the
current range mode to get cleared out. This is because updateCurrentRangeWithMode:
will not set _didUpdateCurrentRange if _currentRangeMode == rangeMode.
2016-11-27 15:42:07 -08:00
Rajeev Gupta
91734ea979 [Examples] CustomCollectionView in Swift3 (#2591)
* new Swift example

* removed asyncDataSource and asyncDelegate. Also using collectionNode methods instead of collectionView

* Fixing the folder structure

* Updated with @george-gw feedback. Thanks George.
2016-11-27 13:01:35 -08:00
appleguy
8d89f7074f Merge pull request #2662 from facebook/AHDrawMethodNoEscape
Add noescape Attribute to isCancelledBlock Parameters
2016-11-27 11:12:36 -08:00
Adlai Holler
c205edc1b1 Merge pull request #2656 from maicki/MSHandleRootNodeViewLoadingInASViewController
[ASViewController] Trigger load view in ASViewController if node did load but not the view of the view controller
2016-11-27 10:43:42 -08:00
Adlai Holler
aee2aaf40a Align the colons 2016-11-27 10:36:21 -08:00
Adlai Holler
b689a59b45 Mark isCancelled block as noescape to improve the Swift import 2016-11-27 10:31:35 -08:00