Michael Schneider
01fed69b26
Adds trampoline for inserting and deletion of nodes
...
Currently measurement always needs to happen on the main thread if implicit hierarchy management is enabled as adding and removing from nodes needs to happen on the main thread. We now will trampoline to the main thread to do the insertion and deletion of nodes.
This also resolves the issue that can occur if a node is already loaded deep in the layout hierarchy in the layout that the node is transforming to. Before insertion or deletion is happening we need to crawl the layout hierarchy to check that though.
2016-07-01 16:33:37 -07:00
Adlai Holler
a77a6eaaf5
Merge pull request #1820 from gazreese/ASCollectionView-tuning-parameters
...
[ASCollectionView] Tuning parameters not set
2016-07-01 15:09:01 -07:00
Adlai Holler
988098be26
Merge pull request #1837 from gazreese/ASVideoPlayerNode-placeholder-image
...
[ASVideoPlayerNode] Expose placeholder image for the underlying ASVideoNode
2016-07-01 14:50:29 -07:00
Adlai Holler
3814f42074
Merge pull request #1838 from levi/patch-18
...
[ASPagerNode] Add nodeForPageAtIndex:
2016-07-01 14:21:35 -07:00
Adlai Holler
5dcc7e9430
Merge pull request #1823 from facebook/AHExposePINDownloader
...
[Project] Publicize ASPINRemoteImageDownloader.h
2016-07-01 14:21:16 -07:00
Adlai Holler
96fb5b3261
Merge pull request #1786 from maicki/FixPlaceholderIsNotAppearing
...
[ASDisplayNode] Handle placeholder layer creation in case the size of the node changes after the initial placeholder layer was created
2016-07-01 13:54:01 -07:00
Adlai Holler
d8efa54f21
Merge pull request #1806 from maicki/MSAddASButtonNodePreferredFrameSize
...
[ASButtonNode] Add support for 'preferredFrameSize' to ASButtonNode
2016-07-01 13:50:33 -07:00
Adlai Holler
d80a4430f2
Merge pull request #1840 from facebook/AHRemoveAggregateInitializer
...
[ASDataController] Remove Aggregate CGRect Initializer
2016-07-01 11:58:35 -07:00
Adlai Holler
ebaa2c157e
Remove aggregate CGRect initializers in ASDataController
2016-07-01 11:47:05 -07:00
Levi McCallum
53bc126ae5
Add implementation of nodeForPageAtIndex:
2016-07-01 09:42:39 -07:00
Levi McCallum
b1ceab7a61
Add nodeForPageAtIndex: to header and clean up doc
2016-07-01 09:39:36 -07:00
Gareth Reese
0a5f03e8fc
Merge master into ASVideoPlayerNode-placeholder-image
2016-07-01 15:33:00 +01:00
Gareth Reese
09a344b669
[ASVideoPlayerNode] Expose the placeholder image for the video player node
2016-07-01 15:15:10 +01:00
ricky
8c3025bb12
[ASDisplayNode] added asyncTraitCollectionDidChange method ( #1831 )
...
Subclasses can override this method to react to a trait collection change
2016-06-30 19:45:29 -07:00
Michael Schneider
8804342a98
Don't propagate trait collections to cells if the node is not loaded yet ( #1833 )
...
This fixes an issue where the propagation of trait collections trigger are creation of the node if the node view was not loaded yet.
2016-06-30 19:44:40 -07:00
Adlai Holler
e5b5bbad5b
Merge pull request #1832 from maicki/MSFixImport
...
Change @import to #import
2016-06-30 08:55:30 -07:00
Adlai Holler
04b0aceb8b
Merge pull request #1835 from facebook/AHMakeIndexSetHelpersFrameworkVisible
...
[Framework Build] Make NSIndexSet Helpers Framework-Visible
2016-06-30 08:47:14 -07:00
Adlai Holler
27b99cf0b6
Make NSIndexSet helpers framework-visible
2016-06-30 08:46:11 -07:00
Michael Schneider
53f22da1dc
Code style improvements
2016-06-30 07:30:57 -07:00
Michael Schneider
d1b4e07d0f
Add support for 'preferredFrameSize' to ASButtonNode
2016-06-30 07:30:57 -07:00
Michael Schneider
5f7cdbd9ca
Handle placeholder layer creation in case the size of the node changed after the initial placeholder layer was created
2016-06-30 07:30:17 -07:00
Michael Schneider
f0e96cc808
Change @import to #import
2016-06-30 07:18:30 -07:00
Adlai Holler
284160b07b
Merge pull request #1821 from maicki/MSAddConformsToProtocolToProxy
...
[ASDelegateProxy] Add `conformsToProtocol:`
2016-06-29 09:18:14 -07:00
Adlai Holler
45ef91171d
[ASTextNode] Release Lock Sooner in -setAttributedText: ( #1828 )
...
* [ASTextNode] Release lock sooner in -setAttributedText:
* [ASTextNode] Expand the critical scope a bit
2016-06-28 20:18:30 -07:00
Gareth Reese
1d356242fd
[ASVideoNode] Ensure that observer methods don't observer all other ASVideoNode objects
2016-06-28 15:41:26 +01:00
Adlai Holler
d82e1ce95b
Merge pull request #1812 from facebook/AHUpdateIntegrity
...
[ASDataController] Improve Update Handling, Esp. Reloading Sections
2016-06-27 18:11:11 -07:00
Adlai Holler
db9826c4c6
Add a space for Jenkins testing
2016-06-27 17:30:06 -07:00
Hannah Troisi
0414cf7c9b
Jenkins build test 4
2016-06-27 17:24:01 -07:00
Hannah Troisi
ceff3e8987
Jenkins build test 3
...
added another space
2016-06-27 17:14:24 -07:00
Hannah Troisi
c10497ed99
Jenkins build test 2
...
Added a space to trigger a Jenkins build.
2016-06-27 17:07:53 -07:00
Hannah Troisi
e0fc55e25f
Jenkins build test
...
Adding a space to test jenkins build hooks.
2016-06-27 16:57:08 -07:00
Hannah Troisi
20edc81f55
Update build.sh file
...
Adding MODE = "examples" will allow Kosta to speed up internal ASDK build.
2016-06-27 11:19:32 -07:00
Adlai Holler
f7fa90aafd
[Project] Publicize ASPINRemoteImageDownloader.h
2016-06-27 10:21:52 -07:00
Michael Schneider
4091d70003
Add conformsToProtocol: to ASDelegateProxy
2016-06-27 06:38:42 -07:00
Gareth Reese
d55621c285
[ASCollectionView] Tuning parameters not set
2016-06-27 14:07:00 +01:00
Hannah Troisi
db04f4b851
[ASTableView] Add constrainedSizeForRowAtIndexPath: to control row heights from delegate ( #1769 )
...
* [ASTableView] constrainedSizeForRowAtIndexPath
* Quick fix to header file
* Switch to Delegate from DataSource.
* Update testing variables to reflect switch to delegate
2016-06-26 23:09:53 -07:00
appleguy
ae87717263
Revert "Remove old website folder from master branch" ( #1818 )
2016-06-26 17:12:59 -07:00
Hannah Troisi
f71e207e0a
Remove old website files from master branch ( #1817 )
...
- new website files are in gh-pages branch (and have been for awhile)
2016-06-26 17:08:35 -07:00
Hannah Troisi
e4abe898d5
[ASEditableTextNode] Support UITextInputTraits pass-through methods (threadsafe for use before view creation) ( #1809 )
...
* [ASEditableTextNode] Support UITextInputTraits
* consistent property attributes
* remove logging, fix tests to account for UIKit weirdness
* address @appleguy's comments
2016-06-24 16:53:10 -07:00
Michael Schneider
3fb0e18504
[ASTextNode] Further locking improvements for ASTextNode ( #1813 )
...
* Further locking improvements for ASTextNode
* Remove tighter holding of lock as this operation needs to complete with the lock held
2016-06-24 16:49:05 -07:00
Adlai Holler
0a354f8f4e
[ASDataController] Remove implementation for unused hooks
2016-06-24 15:48:23 -07:00
Adlai Holler
211dcdf0e8
[_ASHierarchyChangeSet] Remove unused new method
2016-06-24 13:56:08 -07:00
Adlai Holler
0a525a3c16
[ASFlowLayoutController] Fix enumeration bug in ASFlowLayoutController
2016-06-24 13:52:16 -07:00
Adlai Holler
27dc52c0c5
[ASHierarchyChangeSet] Document reload-splitting behavior
2016-06-24 13:20:06 -07:00
Adlai Holler
304f8f6cb1
[ASHierarchyChangeSet] Clean up and add documentation
2016-06-24 13:17:00 -07:00
Adlai Holler
84e8b2686c
[ASDataController] Combine isolated reloads into a batch
2016-06-24 13:03:51 -07:00
Adlai Holler
5d72f2f2cc
Enable the thrash testing
2016-06-24 11:12:37 -07:00
Adlai Holler
d8d2524b89
One more critical update integrity fix
2016-06-24 11:12:37 -07:00
Adlai Holler
681876bd59
Fix more issues with data integrity
2016-06-24 11:12:37 -07:00
Adlai Holler
9c70cec8d8
Improve update handling more
2016-06-24 11:12:37 -07:00
