Eric Jensen
527397ba7e
Replace id with instancetype in initializers
2016-04-13 11:20:05 -07:00
Adlai Holler
140ca717b1
[ASMultiplexImageNode] Do not eagerly cancel image downloads
2016-04-12 22:14:34 -07:00
Adlai Holler
60c3ed27ff
Fix more indentation
2016-04-12 17:46:44 -07:00
Adlai Holler
faf29dd978
Fix indentation
2016-04-12 17:45:40 -07:00
Adlai Holler
7128f69678
[ASMultiplexImageNode] Avoid deadlock by reading our interface state earlier
2016-04-12 17:35:46 -07:00
Eric Jensen
fcab11ee8d
Use __kindof annotation for subside traversal methods that filter based on class
2016-04-12 17:24:28 -07:00
Eric Jensen
2d86dd8ead
Correct nullability annotations of node traversal helpers
2016-04-12 17:15:36 -07:00
Michael Schneider
d0023a97f7
Fix fetching will continually trigger in a loop after reaching end of content
...
Don't schedule a new check for a batch fetch if no data changed previous batch fetch
2016-04-12 17:14:43 -07:00
Adlai Holler
0022cad000
[ASMultiplexImageNode] Copy recent changes made to ASNetworkImageNode for progress image handling
2016-04-12 14:34:11 -07:00
Adlai Holler
362c41ae80
[ASNetworkImageNode] Attach progress image handler even if download starts while already visible
2016-04-12 14:17:41 -07:00
Adlai Holler
37c7f6f849
[ASNetworkImageNode] Remove retain
2016-04-12 14:17:41 -07:00
Adlai Holler
11461f415f
[ASNetworkImageNode] Improve readability, resolve self retain, reduce locking
2016-04-12 14:17:41 -07:00
Scott Goodson
8ccef1e99f
[ASEnvironment] Fix incomplete gating of upward propagation of layout properties (disabled for now).
2016-04-11 20:34:24 -07:00
appleguy
74407d50c4
Merge pull request #1513 from maicki/NodesLayerInLayerAccessiblity
...
[ASDisplayNode] Add handling layer backed accessibility elements within layer backed nodes
2016-04-11 17:46:19 -07:00
Michael Schneider
45d50624d1
Fix disabled state propagation for final layoutable
2016-04-11 17:41:48 -07:00
Michael Schneider
2fade63f1b
Add handling layer backed accessibility elements within layer backed nodes
2016-04-11 12:59:04 -07:00
Scott Goodson
678c201dbc
[ASLayout] Add additional validation step to intercept incorrect values in production and safely zero them out.
...
These conditions already had assertions, but at runtime, an insufficiently tested and incorrect ASLayoutSpec could
generate values that cause UIKit to enter an infinite loop (e.g. inside of UICollectionView layout validation).
2016-04-10 16:42:22 -07:00
Michael Schneider
ed0ed74b72
Add switch to enable / disable layout option properties
2016-04-10 15:04:49 -07:00
Michael Schneider
3c66013088
Remove logging message
2016-04-10 14:23:33 -07:00
appleguy
14fc30aab0
Merge pull request #1504 from hannahmbanana/hitTestDebug
...
[ASControlNode] Improved hitTestDebug to account for limiting display area by parent .clipsToBounds
2016-04-10 12:52:47 -07:00
Scott Goodson
974d8c8817
[ASEnvironmentState] Don't upward-propagate sizeRange or layoutPosition (this behavior, if ultimately desirable, requires additional limiting conditions).
2016-04-10 01:31:32 -07:00
Hannah Troisi
4bd48505af
[ASControlNode] hitTestDebug name refactoring
2016-04-10 01:15:15 -07:00
Hannah Troisi
a6f779a7fe
[ASControlNode] hitTestDebug tool refactoring + comments:wq
2016-04-10 00:51:36 -07:00
Hannah Troisi
7fa810c77f
[ASControlNode] modified hitTestDebug tool vizualize clipping of .clipsToBounds & fixed bug
...
- added orange overlay edge highlighting if tapable area clipped by .clipsToBounds of any parent in the hierarchy
- fixed bug in comparison of child / parent rect edges
2016-04-10 00:19:00 -07:00
Hannah Troisi
f633f6fff0
[ASControlNode] modify hitTestDebug tool to highlight edges clipped by one or more superviewsw
2016-04-09 21:36:57 -07:00
appleguy
7c4db3fbc1
Merge pull request #1477 from maicki/SmallContentBatchFetch
...
[ASBatchContext] Fix fetch call won't occur for content smaller than bounds unless user scrolls
2016-04-09 19:15:06 -07:00
Michael Schneider
6a147021bc
Move setting of accessibilityFrame into accessibleElements
...
- Calculate accessibilityFrame for accessibleElements already in accessibleElements method
- Remove asyncdisplaykit_node associated object as it's not needed anymore
2016-04-09 17:03:35 -07:00
Michael Schneider
1b7db082dd
Improve _ASDisplayViewAccessibility
...
- Add class method to create a UIAccessibilityElement from a ASDisplayNode
- Add function to iterate through a ASDisplayNode tree in bfs fashion
- Add assert for _accessibleElements in accessibilityElementAtIndex:
2016-04-09 16:07:30 -07:00
Michael Schneider
14ca529911
Moving accessibility related code to _ASDisplayViewAccessibility
2016-04-09 11:23:25 -07:00
Michael Schneider
a6f287a8fd
Address pull request comment regarding ASDisplayNode properties
2016-04-09 11:23:25 -07:00
Michael Schneider
3b91c22fdf
Recreate the accessibleElements if accessed
2016-04-09 11:23:25 -07:00
Michael Schneider
39950e74b2
Remove NS_AVAILABLE_IOS(8_0);
2016-04-09 11:23:25 -07:00
Michael Schneider
28c4fede57
Add support for newly added a11y properties in iOS 8 / 9 and tvOS
...
New a11y properties:
- accessibilityNavigationStyle
- accessibilityHeaderElements
- accessibilityActivationPoint
- accessibilityPath
2016-04-09 11:23:25 -07:00
Michael Schneider
34df512eeb
Remove ASNodeValidForAccessibility
2016-04-09 11:23:25 -07:00
Michael Schneider
f3303c1fb8
Add properties for accessibilty to ASDisplayNode to support layer backed nodes
2016-04-09 11:23:25 -07:00
Michael Schneider
ef31c3abf0
Copy accessibilityIdentifier to UIAccessibilityElement if a node is assigned
2016-04-09 11:23:25 -07:00
Michael Schneider
4056bf9ef3
Return NO if node i not valid for accessibility
2016-04-09 11:23:25 -07:00
Michael Schneider
03a7c55d59
Add accessibility support for shouldRasterizeDescendants and layerBacked nodese
2016-04-09 11:23:25 -07:00
Michael Schneider
9c29d0efa8
Initial commit for improved accessibility support
2016-04-09 11:23:25 -07:00
Michael Schneider
e9fe92444f
Small comment fix
2016-04-09 10:55:52 -07:00
Michael Schneider
be26f0c2e5
Revert back to use UIKit version to prevent animations
2016-04-09 10:55:52 -07:00
Michael Schneider
c19c2da2ee
Remove horizontal scrolling behavior detection for ASTableView
2016-04-09 10:55:52 -07:00
Michael Schneider
18fe728230
Remove deprecation of completeBatchFetching:
2016-04-09 10:55:52 -07:00
Michael Schneider
bb110ca6e8
Readd ASDisplayShouldFetchBatchForContext
2016-04-09 10:55:52 -07:00
Michael Schneider
24ca09ee6c
Move most of the batch fetching logic to a central place for ASTableView and ASCollectionView usage
2016-04-09 10:55:52 -07:00
Michael Schneider
40fe1f3ac7
Schedule _checkForBatchFetching call in animation block
2016-04-09 10:55:52 -07:00
Michael Schneider
ab8928c140
Consolidate methods for batch fetching in ASTableView
2016-04-09 10:55:52 -07:00
Michael Schneider
f92e7d5a29
Move completeBatchFetching: to deprecated location in header
2016-04-09 10:55:52 -07:00
Michael Schneider
c25a252e1c
Fix fetch call won't occur for content smaller than bounds unless user scrolls
2016-04-09 10:55:52 -07:00
appleguy
0fbc77dd25
Merge pull request #1495 from maicki/FixASTableViewUpdateRangeCrash
...
[ASTableView] Fix crash if called updateCurrentRangeWithMode: on an ASTableNode
2016-04-08 21:14:59 -07:00
