appleguy
d3e4db2c5c
Merge pull request #444 from levi/patch-1
...
Fix typo in ASTableView
2015-05-13 22:55:24 -10:00
appleguy
e3ecaca40e
Merge pull request #446 from nscoding/nscoding/snapshots
...
Update FBSnapshotTestCase to 1.8.1
2015-05-13 22:52:36 -10:00
appleguy
dbb8c2e421
Merge pull request #451 from eanagel/setDelegate-fix
...
Fix a crash in setAsyncDelegate: that happens randomly (UIScrollViewAccessibility or NSProxy)
2015-05-13 22:50:19 -10:00
Ethan Nagel
d9acd7bb84
More fixes to catch/handle the delegate getting into an invalid state. These changes will allow setting tableView.asyncDataSource/delegate = nil. (Previously this would have no effect in dealloc thanks to ARC magic). Also added some defensive code to help identify the problem earlier.
2015-05-13 11:00:37 -07:00
Ethan Nagel
58402b6af0
change the order we tear things down in setAsyncDelegate/DataSource to avoid a random crash in UIScrollViewAccessibility.
2015-05-12 12:11:05 -07:00
Levi McCallum
1530ef2841
Prevent UITableView insertion/deletion animations by default
...
Fixes #292
2015-05-07 21:53:38 -07:00
Levi McCallum
4619457a1e
Fix typo in ASTableView
2015-05-07 14:51:03 -07:00
Patrik Tomas Chamelo
19e57d9d46
Update FBSnapshotTestCase to 1.8.1
2015-05-07 14:14:50 -07:00
Ethan Nagel
a38cf3ef37
Merge branch 'master' into astableview-in-xib
2015-05-05 09:31:31 -07:00
Ethan Nagel
c81f5d08fc
refactor ASTAbleView initialization code so it also gets initialized when starting from initWithCoder:
2015-05-04 08:51:25 -07:00
Ethan Nagel
38f08c9bd8
support layers as well as views when doing ASDisplayCell cleanup (in case we add support for layer-backed ASDisplayCells in the future.)
2015-05-03 21:45:33 -07:00
appleguy
f248dbddd1
Merge pull request #405 from eanagel/reloadData-completion
...
Add (optional) completion handler for ASTableView and AsCollectionView reloadData
2015-05-03 19:25:06 -07:00
appleguy
74fc9a429e
Merge pull request #440 from Driftt/control-node-target-retain
...
Don’t retain an action’s target in ASControlNode
2015-05-03 19:12:28 -07:00
rlasante
04ec602500
Don’t retain an action’s target in ASControlNode
...
- addTarget:action:forControlEvents: should not retain the target. If it does
then there is a very high likelihood of a retain cycle.
2015-05-01 13:04:26 -04:00
Ethan Nagel
a0ec62b282
Add option to pass through touches to non-link text (disabled by default.)
2015-04-27 17:59:59 -07:00
Ethan Nagel
b40c1dbfc3
on ASDataController dealloc, ensure that loaded Cell nodes are not in the TableViewCell. For reasons I don't fully understand, this avoids a retain cycle with the currently displayed cells.
2015-04-22 13:57:25 -07:00
Dasmer Singh
7fedfdd757
[README.md] Add Coveralls badge
2015-04-22 12:23:11 -04:00
Dasmer Singh
9006f7c356
Ignore .gcov files in git
2015-04-22 12:20:37 -04:00
Dasmer Singh
f8c02147fb
[.slather.yml] Add newline to end of file
2015-04-21 17:02:04 -04:00
Dasmer Singh
9cf056f6d5
Set GENERATE_TEST_COVERAGE_FILES & INSTRUMENT_PROGRAM_FLOW_ARCS to YES in Life Without CocoaPods.xcodeproj
2015-04-21 16:39:21 -04:00
Dasmer Singh
de04da843f
Update Podfile.lock
2015-04-21 16:38:39 -04:00
dasmer
1c8b425a44
Generate coverage stats using slather/Coveralls
2015-04-20 23:48:49 -04:00
Tobias Klonk
2a29f81b3a
ASTextNode expose exclusion paths
...
expose NSTextContainer's exclusionPaths property on ASTextNode to be able to exclude view areas from typesetting.
This implements #394
2015-04-20 10:21:01 +02:00
Ethan Nagel
68e2e068c3
Bug Fix - ASTableVie sometimes fails to render cell contents when scrolling programatically. Root cause is because we assume UITableView's indexPathsForVisibleRows return the new item to be displayed after tableView:willDisplayCell:forRowAtIndexPath: is called. This is not always true, especially when we are scrolling programmatically. Fix is to track this "pending" visible index path and return it along with the UITableView's indexPathsForVisibleRows in rangeControllerVisibleNodeIndexPaths:.
2015-04-17 16:09:44 -07:00
Onha Choe
74d2433d60
change ASMutableAttributedStringBuilderTests so that it is safe against different MAX macro
...
when MAX macro is defined in such a way in "sys/params.h", this test will become flaky,
fix so that it doesn't happen
2015-04-14 13:57:54 -07:00
Nadine Salter
1316389f10
New patent grant.
...
https://code.facebook.com/posts/1639473982937255/updating-our-open-source-patent-grant/
2015-04-10 12:15:09 -07:00
Ryan Nystrom
24bb0926bc
Merge pull request #421 from facebook/xcode-6-3
...
Xcode 6.3 support
2015-04-08 16:44:50 -07:00
Ryan Nystrom
7eed85a7f0
Merge pull request #418 from spicyj/kittens
...
Add new kittens after last row
2015-04-08 16:36:33 -07:00
Ryan Nystrom
300724388b
Merge pull request #420 from facebook/swolchok-patch-1
...
s/assign/strong/ on an object-typed ivar
2015-04-08 16:36:02 -07:00
Ryan Nystrom
527a6228a9
Xcode 6.3 support
2015-04-08 16:35:10 -07:00
Ryan Nystrom
6d8d7aeece
Passing the torch
2015-04-07 16:09:17 -07:00
Scott Wolchok
15dfd25aff
s/assign/strong/ on an object-typed ivar
...
It caused a zombie in tests.
2015-04-06 14:47:42 -07:00
Ryan Nystrom
01e7d09a26
Merge pull request #412 from mikee179/master
...
Adds property for long press touch cancellation
2015-04-03 14:12:32 -07:00
Ben Alpert
a8c484119b
Add new kittens after last row
...
New kittens were being added before the last kitten instead of after it
because we weren't taking into account the first (header) row.
2015-04-03 12:40:53 -07:00
Michael Kuntscher
a92dd3189b
Adds property for long press touch cancellation
2015-04-01 16:38:29 -07:00
Ian Cloutier
8699ab8ed7
Fix handling of pending nodes and placeholder layer
2015-03-30 18:59:40 -04:00
Ethan Nagel
abd725d8c1
update documentation for reloadData:completion
2015-03-27 18:14:05 -07:00
Ryan Nystrom
6ae17e55bc
Merge pull request #403 from facebook/touch-forwarding
...
Forward touches to super instead of the superview
2015-03-26 21:11:53 -07:00
Ryan Nystrom
b6715b5cf9
Forward touches to super instead of the superview
...
fixes #402
2015-03-26 21:11:13 -07:00
Nadine Salter
d3a8f44068
Merge pull request #404 from facebook/textnode-tapping
...
Allow double-tap gestures on text nodes
2015-03-26 18:01:36 -07:00
Ryan Nystrom
29a360d562
Allow double-tap gestures on text nodes
2015-03-26 17:22:22 -07:00
Ethan Nagel
3f509dbd2f
add completion block to reloadData methods
2015-03-26 16:32:44 -07:00
Nadine Salter
dd10fda42c
Fix ASSnapshotTestCase #import.
2015-03-23 16:39:21 -07:00
Nadine Salter
eeb96e662c
Merge pull request #396 from facebook/ASSnapshotTestCase
...
[tests] ASSnapshotTestCase.
2015-03-23 16:08:32 -07:00
Nadine Salter
ad3f3b5fdc
Disable flakey test.
2015-03-23 15:59:29 -07:00
Ryan Nystrom
50eccabac8
Merge pull request #389 from facebook/issue-380
...
Fix ASImageNode -measure: / -setImage: deadlock.
2015-03-23 14:48:12 -07:00
Nadine Salter
ecd6872814
[tests] AsyncDisplayKitTestHost.
2015-03-23 14:06:38 -07:00
Nadine Salter
b869d025ff
[tests] ASSnapshotTestCase.
2015-03-23 14:06:38 -07:00
Nadine Salter
13e1c65d03
Fix ASImageNode -measure: / -setImage: deadlock.
...
Speculative fix for #380 . Calling `-[ASImageNode setImage:]` on a
background queue will take the image lock, then trampoline to the main
queue to invalidate calculatedSize and set needsDisplay without
releasing the lock. Any other method call that takes the image lock on
the main queue can block on the trampoline completing -- deadlock.
Note that the trampoline is itself a clowny workaround for thread
affinity (#134 ) and should be removed. With this patch applied,
ASImageNode's `-setImage:` and `-calculateSizeThatFits:` can still race:
1. -setImage changes _image, then trampolines to main
2. -calculateSizeThatFits measures _image
3. trampoline completes, invalidates calculated size
4. ???
5. ~~profit!~~ 💥
2015-03-23 14:05:15 -07:00
Ryan Nystrom
814aff5a6d
Merge pull request #388 from facebook/issue-383
...
Remove ASImageNode's tint property.
2015-03-23 13:59:20 -07:00
