Gareth Reese
062bcf3631
[ASVideoNode] issue #1782 Placeholder images are replaced by a blank placeholder. Now checks the .URL property of the parent class as well as the .image to ensure that new placeholders aren't generated.
2016-06-21 07:51:58 +01:00
Hannah Troisi
c857e809f4
Clean up header comments (for consistent Facebook licensing info) ( #1741 )
...
[Licensing] Clean up header comments (for consistent Facebook licensing info)
2016-06-11 23:31:39 -07:00
appleguy
a7128cd213
Merge pull request #1605 from lappp9/override-callback-for-display-range
...
[ASDisplayNode] Added callbacks for entering and exiting fetch data and display ranges
2016-06-11 22:21:20 -07:00
Eric Jensen
001d3ea624
Use a strong reference to the current asset in order to prevent setting a placeholder image if the asset is set to nil while the placeholder image is generating
2016-06-08 12:37:32 -07:00
Luke Parham
fc5467b110
fixed typo and added backwards compatibility for 'visibilityDidChange'
2016-06-06 02:02:23 -05:00
Luke Parham
e510120031
changed '-visibilityDidChange:' to '-visiblieStateDidChange:' to match the others
2016-06-06 00:56:21 -05:00
Hannah Troisi
52d58992da
[ASVideoNode] Change superclass to ASNetworkImageNode so that it can be its own placeholder ( #1710 )
...
* [ASVideoNode] Change superclass to ASNetworkImageNode so that ASVideoNode can be its own placeholder
- remove _placeholderImageNode property of ASVideoNode (use self.image now instead)
- move layoutSpecThatFits: code to calculateSizeThatFits: & layout: methods as ASImageNode uses calculateSizeThatFits:
* [ASVideoNode] Tweaks to the definition of the delegate protocols to integrate with ASNetworkImageNode (superclass)
2016-06-05 18:18:52 -07:00
Scott Goodson
783011bc0e
[ASVideoNode] Added a couple comments for clarity and to identify future improvement areas.
2016-06-04 21:38:05 -07:00
Erekle
4ab0f1ec60
[ASVideoPlayerNode] fixes; Ability to add custom controls
2016-05-23 23:23:33 +04:00
Erekle
100d2b4f26
moved spinner to ASVIdeoPlayerNode
2016-05-19 15:07:39 +04:00
Erekle
053b14992c
Merge remote-tracking branch 'facebook/master' into ASVideoPlayerNode
...
# Conflicts:
# AsyncDisplayKit/ASVideoNode.h
# AsyncDisplayKit/ASVideoNode.mm
2016-05-19 11:57:16 +04:00
Max Gu
73b41ee450
Renaming the delegate flags for the deprecated methods
2016-05-18 22:10:06 -07:00
Max Gu
1c64a4a785
Surpressing deprecated methods warning
2016-05-18 16:39:45 -07:00
Max Gu
90877847c2
Adding deprecated methods back
2016-05-18 14:05:08 -07:00
Max Gu
a93bc72e25
Updating and adding a few APIs for ASVideoNode
2016-05-18 08:40:58 -07:00
Max Gu
325e37020c
Adding startup loading state in ASVideoNode
2016-05-17 15:31:30 -07:00
Erekle
98c451118b
removed play button
...
* Removed play button from ASVideoNode
* Removed play button tests
* added some checks in ASVideoPlayerNode
* added new delegate method for time formats
2016-05-13 00:46:55 +04:00
Erekle
d0345549f6
Merge remote-tracking branch 'facebook/master' into ASVideoPlayerNode
...
# Conflicts:
# AsyncDisplayKit.xcodeproj/project.pbxproj
2016-05-12 13:05:24 +04:00
Michael Schneider
9b3ecd28a9
Fix position of loading spinner in ASVideoNode
2016-05-11 20:14:22 +02:00
Erekle
975690744b
Merge remote-tracking branch 'facebook/master' into ASVideoPlayerNode
2016-05-11 20:43:57 +04:00
Erekle
52b40f8004
ASVideoPlayerNodeControlType and fixes
...
* changed static string to ASVideoPlayerNodeControlType
* public property for duration
* public method for seek
* new _controlFlexGrowSpacerSpec; used to use flexible space in
controlbar. for example if user does not want to have scrubber, he can
replace it with flexible spacer and duration text node will be kept at
the right edge.
2016-05-10 23:57:47 +04:00
Erekle
716082d411
better duration handling. new ASVideoNode states
2016-05-10 22:48:32 +04:00
Erekle
c46547ac5f
prototype
...
Added duration detection in ASVideoNode.
2016-05-06 21:41:54 +04:00
Michael Schneider
cac4ed5626
Move layout of ASVideoNode to layout specs
...
- This should fix adjusting a custom play button position
- Fix sample project use of ASVideoNode
2016-05-05 16:49:01 -07:00
Erekle
5c3770e543
fixes
2016-05-05 02:03:03 +04:00
Erekle
82cc6f49f2
coding style fixes
2016-05-05 01:49:52 +04:00
Erekle
b3af10d4ad
Merge remote-tracking branch
...
# Conflicts:
# AsyncDisplayKit/ASVideoNode.mm
2016-05-03 22:59:54 +04:00
Erekle
34e6238391
_delegateFlags
...
added _delegateFlags like in ASCollectionView
2016-05-01 17:11:40 +04:00
Robin Chou
b700eeb32c
Use ASPerformOnMainThread
helper. -fetchData
improvements.
2016-04-30 17:22:11 -04:00
Erekle
2c2a73dc83
playbackBufferEmpty and spinner
...
added playbackBufferEmpty logic, moved spinner show/hide to separate
methods.
2016-04-29 20:49:14 +04:00
Erekle
399703dbb2
new delegate methods
...
Added new delegate methods; updated Videos example project
2016-04-29 12:59:15 +04:00
Robin Chou
75b55974b5
Loads asset values with -loadValuesAsync
.
2016-04-28 20:02:15 -04:00
Eric Jensen
f2ab6ca6dd
Restructure conditional logic
2016-04-26 23:15:14 -07:00
Eric Jensen
fcf4a4d112
Prevent unnecessary locking when generating a placeholder image on a background thread
2016-04-26 19:44:53 -07:00
Eric Jensen
e3817ac42d
Prevent UI blocking caused by accessing the AVAsset's 'tracks' property on the UI thread
2016-04-26 19:42:05 -07:00
Max Gu
13fc13fb56
Removing an unnecessary assertion in ASVideoNode
2016-04-21 15:20:08 -07:00
appleguy
dd4853bf3a
Merge pull request #1273 from aaronschubert0/tvOS
...
[tvOS] Add default focus states to ASControlNode & ASImageNode.
2016-04-20 13:29:31 -07:00
appleguy
966c579d31
Merge pull request #1557 from ejensen/video-player-item-replace
...
[ASVideoNode] Reuse existing AVPlayer when available
2016-04-19 16:40:03 -07:00
Eric Jensen
4a010337f6
Limit resuming of buffering videos to those that are visible
2016-04-19 13:21:06 -07:00
Eric Jensen
f01ceab3e7
Reuse the existing AVPlayer when it's available in fetchData
2016-04-19 13:04:35 -07:00
Aaron Schubert
21abe8f899
Fix merge conflicts
2016-04-19 09:02:07 +01:00
Eric Jensen
a49d620771
Replace dispatch_async(dispatch_get_main_queue... with ASPerformBlockOnMainThread
2016-04-18 23:08:57 -07:00
Eric Jensen
6a4bc3fd5b
Rename setPlaceholderImage to setVideoPlaceholderImage in order to prevent super class setter conflict
2016-04-18 22:30:32 -07:00
Eric Jensen
a2b03d6e90
Change ASContentModeFromVideoGravity's default to UIViewContentModeScaleAspectFit
2016-04-18 22:13:49 -07:00
Eric Jensen
b5c3b15069
Observe playbackLikelyToKeepUp in order to handle player buffer filling and emptying
2016-04-18 22:13:49 -07:00
Eric Jensen
e65d63a502
Simplified and improved video node's handling of state changes:
...
- Simplified visibility state change handling.
- Placeholder image is now updated after switching assets.
- Improves memory usage by clearing the placeholder image in clearFetchedData.
2016-04-18 22:13:49 -07:00
appleguy
33e36de5dc
Merge pull request #1552 from chourobin/feature/hls
...
[ASVideoNode] Re-enables HLS support
2016-04-18 22:09:43 -07:00
Robin Chou
bdd4baf933
Re-enables HLS support (can't use AVAsset for HTTP live stream media).
2016-04-18 22:38:47 -04:00
Eric Jensen
c1c1358baf
Fix video stalling by pausing the video after backgrounding the application
2016-04-18 13:53:43 -07:00
Eric Jensen
983c2f1f49
Replacing ASVideoNode's playButton now cleans-up the previous button's state
2016-04-18 13:53:43 -07:00