Commit Graph

13022 Commits

Author SHA1 Message Date
Sujay
c4080a253f more spelling fixes 2018-02-05 12:36:21 -06:00
Peter Iakovlev
64d878dfc3 no message 2018-02-05 19:32:26 +04:00
Grishka
60d40e4ee4 deinitializing multi-threaded things seems like a good way to go mad 2018-02-03 20:54:38 +04:00
Grishka
e7e7d2f05e crash fix 2018-02-03 20:21:58 +04:00
Michael Schneider
5ea4d51596 Get CatDealsCollectionView example running again #trivial (#783)
* Get CatDealsCollectionView example running again

* Fix it for real and some other styling stuff

* Fix some warning

* Adjust headers
2018-02-02 11:41:19 -08:00
Adlai Holler
c6454214ac Retain the reference color space (#784) 2018-02-02 10:36:17 -08:00
Peter Iakovlev
0a81afd110 no message 2018-02-02 00:16:42 +04:00
Michael Schneider
38b76e0eb2 Improve nullable annotations for _ASDisplayLayer and _ASDisplayView (#780) 2018-02-01 08:44:47 -08:00
Adlai Holler
1be4d8d088 Add #764 to the changelog 2018-02-01 06:45:07 -08:00
Vladyslav Chapaev
0f061b401e node tint color fix (#764) 2018-02-01 06:43:46 -08:00
Peter Iakovlev
dfcfa3772c no message 2018-02-01 05:18:26 +04:00
Adlai Holler
0c4ccc5253 Improve ASNetworkImageNode delegate callout behavior (#778)
* Improve ASNetworkImageNode delegate callout behavior

* no message
2018-01-31 12:18:04 -08:00
Alex Hill
0bb53552b0 [ASCellNode] focusStyle mapping (#727)
* [ASCellNode] Adds mapping for UITableViewCell focusStyle

* Update CHANGELOG.md
2018-01-31 10:07:08 -08:00
Peter Iakovlev
47cd4b0d76 no message 2018-01-31 20:40:55 +04:00
Huy Nguyen
ea547270f2 [ASDisplayNode] Force a layout pass on a visible node as soon as it enters preload state (#779)
This reverts commit 2e98588372 (#751).

The reason we can't wait for the coming CA's layout pass is that cell node visibility events occur before the pass, at which time the cell's subnodes don't have correct frames for impression tracking.

The root cause of this problem is that, right now, cell node visible states are set by ASRangeController well before the layout pass of the hosting collection/table view. That means we're "jumping the gun". The more I think about this, the more I agree with @Adlai-Holler that we need to treat visible state differently. That is, a node should only be visible (and thus get visibility events) after it's fully loaded, it's view/layer attached to the hierarchy and laid out by a CA transaction. In other words, at the end of the CA layout pass. Such change needs time and effort to be thoroughly reviewed and tested. Until then, let's roll with this fix.
2018-01-31 15:35:14 +00:00
Aaron Rosenberger
d6971980a3 Fixed: completeBatchFetching is called on a background thread (#731)
* Fixed breaking issue where completeBatchFetching is called on a background thread when no items are added to the collection

* Changed spaces to tabs for consistency

* Moved return statement for Code Review feedback

* Fixed the same issue in the Objective-C version of ASDKgram

* One more

* Update PhotoFeedModel.m

Fix header
2018-01-31 10:23:04 -05:00
Denis Morozov
511bec63a2 Fix capturing self in the block while loading image in ASNetworkImageNode (#777)
* Fix capturing self in the block while loading image in ASNetworkImageNode

* Restore re-strongify while switching on the main thread

* Update CHANGELOG.md
2018-01-31 10:20:00 -05:00
Michael Schneider
20e31f7d70 Fix synchronous state of node if +viewClass or +layerClass is overwritten #trivial (#776)
* Fix synchronous state of node if +viewClass is overwritten

* Also check for _layerClass overwrite for synchronous flag

* Update some code style
2018-01-31 07:07:38 -08:00
Adlai Holler
fef965f78e Add support for providing additional info to network image node delegate (#775)
* Add support for piping arbitrary user info from ASImageDownloader to the ASNetworkImageNodeDelegate

* s/source/sourceType

* Fix stuff and take Michael's advice
2018-01-30 17:50:38 -05:00
Michael Schneider
196d76d82d Expose asyncdisplaykit_node in _ASDisplayView same as in _ASDisplayLayer #trivial (#773)
* Expose asyncdisplaykit_node in _ASDisplayView same as in _ASDisplayLayer

* Change comment
2018-01-30 14:24:46 -08:00
Justin Swart
7ba4376b6f Update PINCache (#769) 2018-01-30 14:19:37 -05:00
Adlai Holler
2e94bb8120 Improve no-copy rendering experiment, remove +load method (#771)
* Improve graphics contexts experiment

* Update changelog

* Remove extra space

* Add a unit test for screen scale

* Fix typo and use unique value
2018-01-30 14:18:37 -05:00
Flatout73
b0c3e65da8 Fix misprint (#768) 2018-01-29 12:05:48 +00:00
Denis Morozov
3f27546ec8 Fix typos in layout2-layoutspec-types.md #trivial (#770) 2018-01-29 12:05:33 +00:00
Peter Iakovlev
3fb2a63e21 no message 2018-01-29 03:04:39 +04:00
Peter Iakovlev
0d3e30c7c9 no message 2018-01-28 20:02:12 +04:00
Sujay
5354b974ff fix spelling 2018-01-25 23:14:53 -06:00
Grishka
6b0d4a6cc3 fix 2018-01-24 17:56:42 +03:00
Mikhail Filimonov
82783ba8ba Merge branch 'master' of https://github.com/peter-iakovlev/TelegramCoreDev 2018-01-24 12:17:47 +04:00
Mikhail Filimonov
1b7c78cf9b no message 2018-01-24 12:17:39 +04:00
Mikhail Filimonov
3fb91f5b38 Merge branch 'master' of https://github.com/peter-iakovlev/PostboxDev 2018-01-24 12:17:25 +04:00
Mikhail Filimonov
dbdd13b2e8 no message 2018-01-24 12:17:15 +04:00
brandon_withrow
d1008701a0 version Bump 2018-01-23 13:47:50 -08:00
Peter Iakovlev
6f5513f01a no message 2018-01-24 01:05:05 +04:00
Peter Iakovlev
707558f331 no message 2018-01-24 01:04:37 +04:00
Peter Iakovlev
df33221c66 Merge commit '3024d9c43a392b63b98436df0ab54242aa91d35c' 2018-01-23 22:59:05 +04:00
Peter Iakovlev
bcfea1396b no message 2018-01-23 22:58:32 +04:00
Peter
3024d9c43a Merge commit '50c01586839b0113730b0aaa9a4011b954868da2' 2018-01-23 22:58:14 +04:00
Peter
4b6b3e5334 no message 2018-01-23 22:58:09 +04:00
Adlai Holler
c3ae4474d0 NoCopyRendering experiment: Fix possible memory leak if image node rendering is canceled #trivial (#765)
* Fix memory leak if image node rendering is canceled

* Update comment
2018-01-23 10:45:34 -08:00
Adlai Holler
9b8a919a93 Revert "Faster collection operations (#748)" (#759)
This reverts commit 5c13403ef7.
2018-01-22 11:38:09 -08:00
Adlai Holler
5c13403ef7 Faster collection operations (#748)
* Faster collection operations

* Fix a few things

* Put the stupid semicolon

* Address warning

* Cut down retain/releases during collection operations

* Update CHANGELOG.md
2018-01-22 13:22:03 +00:00
Brandon Withrow
961877ed68 Merge pull request #482 from meta-craft/feature/tvos_framework
Added a new tvOS target
2018-01-19 11:40:44 -08:00
Brandon Withrow
7072abeba9 Merge pull request #511 from axoic/bugfix
[bugfix] fix collision of images with same name in different bundles.…
2018-01-19 11:38:02 -08:00
brandon_withrow
60affeeb51 Cleanup 2018-01-19 11:36:19 -08:00
Brandon Withrow
dd03fa4e9a Merge pull request #533 from floschliep/master
Fix convenience class methods of public classes
2018-01-19 11:30:36 -08:00
Mikhail Filimonov
c8fa120b1d Merge branch 'master' of https://github.com/peter-iakovlev/TelegramCoreDev
# Conflicts:
#	TelegramCore/Api.swift
#	TelegramCore/ExportMessageLink.swift
#	TelegramCore/SearchMessages.swift
#	TelegramCore/SearchPeers.swift
#	TelegramCore/Serialization.swift
2018-01-19 01:08:38 +04:00
Peter Iakovlev
50c0158683 no message 2018-01-19 00:39:08 +04:00
Peter Iakovlev
05452bdac0 Merge branch 'groups'
# Conflicts:
#	Postbox/MessageHistoryView.swift
2018-01-19 00:37:47 +04:00
Peter Iakovlev
bdca59e601 no message 2018-01-19 00:36:37 +04:00