1138 Commits

Author SHA1 Message Date
Scott Goodson
affb786a14 [ASButtonNode] Pass through setDisplaysAsynchronously: to subnodes (image and title). 2016-01-14 23:12:01 -08:00
Scott Goodson
e92a1360e7 Ensure new ASPagerNode has a weak reference to the data source. 2016-01-14 21:43:46 -08:00
Luke Parham
d9559111a0 renamed nic cage sample, added redundancy for loading player in case its nil when visible, added video tests, disabled assert for new range controller 2016-01-14 02:39:36 -06:00
Scott Goodson
df10f8f19a Check array size before accessing section - rare crash for improper data source use, de-escalated to messaging nil. 2016-01-14 00:25:53 -08:00
appleguy
9afb77f7bc Merge pull request #1058 from Adlai-Holler/DidEndDisplayingNodeProvideNode
Add New didEndDisplayingNode:forItemAtIndexPath: delegate methods to provide removed node
2016-01-13 23:55:34 -08:00
appleguy
a0c7b0a7b5 Merge pull request #1061 from dinhviethoa/ascontrolnode-touchesended-twice
Fixed behavior of ASControlNode when -touchesEnded:withEvent: sometimes firing twice.
2016-01-13 23:26:53 -08:00
Viet Hoa Dinh
dbe068c970 Fixed behavior of ASControlNode when -touchesEnded:withEvent: sometimes firing twice. 2016-01-13 19:06:01 -08:00
Adlai Holler
a19ba586f7 Revert change that seems to have caused internal inconsistency in range controller 2016-01-13 13:34:20 -07:00
Luke Parham
579313f086 Merge branch 'master' into ASVideoNode 2016-01-13 12:22:55 -06:00
Aaron Schubert
28b03e3a28 [tvOS] Expose UIFocusEnvironment Protocol methods to ASDisplayNode 2016-01-13 10:09:44 +00:00
Adlai Holler
d19e56d802 Beef up documentation around new delegate methods 2016-01-12 23:27:30 -07:00
Adlai Holler
5e72daa2e3 Pass node along in didEndDisplayingNode method 2016-01-12 15:42:37 -07:00
Aaron Schubert
cc4f604ea3 [tvOS] Initial commit to make build run. 2016-01-12 14:43:30 +00:00
Aaron Schubert
e8f5f61e3b [ASMapNode] Defer creation of default options till they are needed. 2016-01-11 19:42:34 +00:00
Aaron Schubert
239ec6feab [ASMapNode] Updated comment of options property. 2016-01-11 19:30:56 +00:00
Scott Goodson
90a1bb2346 Ruthlessly improve efficiency in ASRangeControllerBeta.
- Use completedNodes directly, caching inner arrays and counts between loop iterations.
- Merge codepaths between the "entire self - table / collection" visible or invisible cases
- Ensure we do not trigger an assertion if a previous iteration's node is nil by the time
  we try to reset its interfaceState.
2016-01-10 02:58:48 -08:00
Scott Goodson
0feaa2a368 Improvements to the efficiency of recursivelySetInterfaceState: and the beta range controller. 2016-01-10 02:40:47 -08:00
Scott Goodson
d45db5ac32 Disable creation of backing ASTable/CollectionNode for the *View varients (retain cycle). 2016-01-09 20:44:24 -08:00
appleguy
c3ef2efe0c Merge pull request #1040 from facebook/ASRangeControllerBetaScrollJump
[ASRangeControllerBeta] Support disjoint ranges between updates (scroll jumps, etc)
2016-01-09 15:54:05 -08:00
Bin Liu
a36a955eb0 fix indentation 2016-01-06 13:09:59 -08:00
Bin Liu
4435405cbb Make ASControlState imitate UIControlState
- selected state isn't implicitly controlled by ASControlNode anymore
- highlighted state can be overriden by users
- Decouple ASButtonNode's state from control events
2016-01-06 12:17:52 -08:00
Scott Goodson
bbfd08829f Switch Tests to use ASRangeControllerBeta. Use NSSet instead of NSMutableSet. 2016-01-05 23:29:11 -08:00
Scott Goodson
d1c3894dbb [ASRangeControllerBeta] Add tracking of all index paths that have .interfaceState set, ensure updating. 2016-01-05 23:17:54 -08:00
Bin Liu
4f67050b9b Fix another typo, fix build failure 2016-01-05 18:04:26 -08:00
Bin Liu
82c098b39d Fixed typo 2016-01-05 17:35:30 -08:00
Bin Liu
6bb51063f9 Replace ASButtonState with ASControlState 2016-01-05 17:07:44 -08:00
Aaron Schubert
45fa36eba5 ASMapNode now supports MKMapSnapshotOptions as opposed to just a region property. 2016-01-05 13:44:41 +00:00
appleguy
8a5f080fcc Merge pull request #1026 from 1nput0utput/ASControlNodeMutationCrash
[ASControlNode] Copy event table before calling action methods, as they may trigger action removal.
2016-01-03 20:18:30 -08:00
appleguy
005408bd2c Merge pull request #1030 from facebook/OthogonalEfficiency
[ASRangeController] Inspect delegate's ASInterfaceState to delay preloading beyond viewport until visible.
2016-01-03 20:17:25 -08:00
Scott Goodson
984fe43997 [ASRangeController] Inspect delegate's ASInterfaceState to delay preloading beyond viewport until visible. 2016-01-03 19:14:07 -08:00
Rahul Malik
a509b7523f Update interface of ASViewController to use lightweight generics. This allows
subclasses of ASViewController to specify the type of ASDisplayNode it
contains which allows for stronger type-checking and auto-completion against
the specified type.

Example Subclass Declaration:
@interface MyASViewController : ASViewController<MyASDisplayNodeSubclass *>
@end
2016-01-03 18:56:09 -08:00
Rajinder Ramgarhia
688e8d27de Add comment explaning the change 2016-01-03 11:02:33 -05:00
Scott Goodson
25b6f29584 Introduce ASCollectionInternal file and create always-available ASCView -> ASCNode backpointer. 2016-01-01 23:36:00 -08:00
Rajinder Ramgarhia
73373ee17b Fix ASControlNode mutation crash 2016-01-01 22:27:08 -05:00
Scott Goodson
b273f358f5 [ASRangeController] Initial implementation of functional-style, ASInterfaceState-based range controller. 2016-01-01 00:48:44 -08:00
Scott Goodson
7a9cd1f930 [ASRangeController] Introduce totally rewritten range controller based on ASInterfaceState. 2015-12-31 17:59:59 -08:00
Scott Goodson
8f914f8430 Fix logic error in handling enablement of beta display range. 2015-12-31 15:38:32 -08:00
Scott Goodson
aee7b3b77a Remove padding workaround from old CoreText days.
This is a vestige from Paper.  Discussion: https://github.com/facebook/AsyncDisplayKit/issues/1013
2015-12-31 01:52:08 -08:00
Scott Goodson
df9f433353 Prevent calling unsupported UICollectionViewDelegate methods (supplementary view appearance) 2015-12-31 00:21:20 -08:00
appleguy
50c97b2636 Revert "[ASCellNode] Forward pointInside to node implementation from UITableViewCell." 2015-12-30 23:42:18 -08:00
Scott Goodson
ffcddf36e2 Ensure that ASRangeController immediately removes any deleted nodes from its range state. 2015-12-30 22:42:11 -08:00
appleguy
9b9d8bc9b6 Merge pull request #1016 from facebook/RasterizationUnloadingNodes
Ensure that the uncommon __unloadNode codepath does not unintentionally trigger node removal.
2015-12-30 00:23:06 -08:00
appleguy
cc15d74e67 Merge pull request #1008 from yury/bridge-uitableviewcell-pointinside
[ASCellNode] Forward pointInside to node implementation from UITableViewCell.
2015-12-29 23:25:48 -08:00
Scott Goodson
df3ce787f7 Ensure that the uncommon __unloadNode codepath does not unintentionally trigger node removal. 2015-12-29 23:11:33 -08:00
Scott Goodson
051f1f6cdd Use _ASDisplayLayer for both ASTableView and ASCollectionView. zeroContentInsets to fix UIKit. 2015-12-29 22:24:44 -08:00
Scott Goodson
1870208153 [ASPagerNode] Ensure delegate property can be set before the view is loaded and is not overwritten. 2015-12-29 20:46:42 -08:00
yury
83960065ed Code style fix 2015-12-29 12:10:08 +03:00
yury
382326ea84 Bridge UITableViewCell pointInside to ASNodeCell
Allow ASNodeCell to specify pointInside of UITableViewCell.
This is very usefull, if ASNodeCell is presented as bubble aligned to
left or right (like Messages.app) and we need to be able to select row
only if user taps on bubble.
2015-12-28 16:11:50 +03:00
appleguy
4c4f0c8932 Merge pull request #1006 from facebook/ASNetworkImageFileURLs
[ASNetworkImageNode] Improve handling of file URLs for images.
2015-12-27 17:11:59 -08:00
appleguy
9264496939 Merge pull request #1005 from facebook/ASDisplayNodeContentsPreservation
[ASDisplayNode] Preserve contents after non-range-managed nodes are removed from superviews or windows.
2015-12-27 17:11:49 -08:00