Peter
34b6e37b8c
Merge commit '131619de96190415aec89987d4493220c6d0305d'
...
# Conflicts:
# Source/ASDisplayNode+Deprecated.h
# Source/ASDisplayNode.mm
# Source/ASDisplayNodeExtras.h
# Source/ASImageNode+AnimatedImage.mm
# Source/Private/ASSection.h
# Source/Private/_ASHierarchyChangeSet.mm
2017-12-25 01:44:19 +04:00
Garrett Moon
46d46fdf12
#trivial Fixes image nodes being stuck not being able to download image ( #720 )
...
* #trivial Fixes image nodes being stuck not being able to download image
* Clear out the _cacheUUID too even though this is not strictly necessary.
2017-12-18 15:15:29 -08:00
Garrett Moon
008a1ce208
Revert Adds support for specifying a quality indexed array of URLs ( #699 )
...
* Revert "Adds support for specifying a quality indexed array of URLs (#557 )"
This reverts commit 3c77d4a5da44c46c7b80b2a627c95389b7d6352d.
* Add CHANGELOG entry
2017-12-05 13:55:19 -08:00
Garrett Moon
0b6d41f872
A couple performance tweaks for animated images #trivial ( #634 )
...
* A couple performance tweaks for animated images
* @nguyenhuy's comments
* Avoid calling animatedImageData twice. Thanks @maicki.
* Fix call to background deallocation
* Good catch by @Adlai-Holler
2017-12-04 14:56:04 -08:00
Adlai Holler
af99ff5ef2
Have ASNetworkImageNode report whether images were cached or not ( #639 )
...
* Have ASNetworkImageNode report whether images were cached or not.
* Update changelog
* Add fileURL case
2017-10-25 15:57:30 -07:00
Garrett Moon
1705ec0140
Don't set download results if no longer in preload range. ( #606 )
...
Good catch by @djblake, if you scroll fast enough, you leave images
set on the image node because didExitPreloadRange (which would have
cleared it) was already called.
2017-10-09 10:13:28 -07:00
Huy Nguyen
9df6909d71
[ASImageNode] Always dealloc images in a background queue ( #561 )
...
* ASImageNode to always dealloc its images in a background queue
* Update CHANGELOG
2017-09-11 13:33:30 -07:00
Garrett Moon
3c77d4a5da
Adds support for specifying a quality indexed array of URLs ( #557 )
...
* Add support for downloading a set of URLs on ASNetworkImageNode
* Should be building now;
* Remove old unused code
* Add a changelog message
* Bump PINRemoteImage
* Huy's comments
2017-09-11 11:12:45 -07:00
Huy Nguyen
786963c6a9
[ASDisplayNode] Deprecate -displayWillStart in favor of -displayWillStartAsynchronously: ( #536 )
...
* Deprecate -[ASDisplayNode displayWillStart] in favor of -displayWillStartAsynchronously:
* Minor change
* Fix CHANGELOG
* Update CHANGELOG.md
* Update CHANGELOG.md
2017-09-08 18:04:43 +01:00
Peter
555fe0239d
Merge commit 'ba08ae1318cac3a40c4c0fe6c920e1675117dc2f'
2017-08-04 13:12:11 +03:00
Peter
587d2b2132
Merge commit '3ccc2f0f15d2e4ed7105f0ef6aea575e05cfd7ad'
...
# Conflicts:
# AsyncDisplayKit.xcodeproj/project.pbxproj
# Source/ASDisplayNode.mm
# Source/ASMapNode.mm
# Source/Details/ASDataController.mm
# Source/Details/ASPINRemoteImageDownloader.h
# Source/Details/ASPINRemoteImageDownloader.m
2017-08-04 13:12:06 +03:00
Adlai Holler
01c14f0fc2
Invalidate layouts more aggressively when transitioning with animation ( #476 )
...
* Be more aggressive at invalidating layouts during transitions, add a debug method, fix some build errors when verbose logging
* Add a changelog entry
2017-07-26 22:27:58 -07:00
Adlai Holler
8ec4b312cf
Overhaul our logging, add activity tracing support. ( #399 )
...
* Improve the os_log and os_activity integration
* Address feedback from Scott and Huy
2017-07-03 19:03:26 -07:00
Garrett Moon
d5f10652c6
Fixes an issue with GIFs that would always be covered by their placeholder ( #326 )
...
Also adds a subclass override for when the animated image is set.
2017-06-02 16:13:36 -07:00
Garrett Moon
850aeb442c
Assert only once we know URL has changed ( #247 )
...
We need this in case someone is setting the URL to nil before setting
the image directly. I.e. they have a node which has been used as a network
node or an image node but now they want it to be an image node.
They should then set the URL to nil and then set the image.
*if* it was used as a network node previously, this would work.
If it was previously used as an image node it would historically assert.
This addresses that.
2017-05-05 16:32:54 -07:00
Garrett Moon
8013e25524
Update license v2 ( #67 )
...
* Fixed license
* Update all licenses
* Update Dangerfile for new license
* Update already updated licenses
* Closer…
* Closer…
* Closer…
* Closer…
* Closer…
* Closer…
* Closer…
* Closer…
* Closer…
* Closer…
* Closer…
2017-04-24 16:59:57 -07:00
Peter
baf94a7575
Merge commit '30ad10da3c34439d6c1c8f8e8f88539d875cf6bf'
...
# Conflicts:
# AsyncDisplayKit.xcodeproj/project.pbxproj
# Source/ASImageNode+AnimatedImage.mm
# Source/ASImageNode.mm
# Source/AsyncDisplayKit.modulemap
# Source/Details/_ASCollectionViewCell.m
# Source/asdkmodule.modulemap
# Source/module.modulemap
2017-04-18 19:50:49 +03:00
Adlai Holler
fdb54a02d9
Fix case where we forget to unlock in ASNetworkImagenode ( #17 )
2017-04-17 11:38:07 -07:00
Garrett Moon
8c3775f5e2
Need to check availability before use of macros. ( #3254 )
...
* Need to check availability before use of macros.
* Get rid of PCH and enforce macro definition.
* Remove prefix
* Switch to global warning instead, much better.
2017-04-10 15:06:40 -07:00
Garrett Moon
68a8d5f468
Add download resume support ( #3246 )
...
* Adds support for resuming downloads that were canceled due to exiting preload range.
* Update to latest PINRemoteImage
* Fix warnings
* Address comments. Thanks @nguyenhuy!
2017-04-10 11:18:05 -07:00
Garrett Moon
30ad10da3c
_setImage wasn't calling correct implementation ( #3243 )
...
_setImage is intended to call the super version of the method,
however with the adoption of the new _locked_ prefix, ASImageNode's
implementation would call back into ASNetworkImageNode's implementation.
This restore the intent of the _setImage method.
2017-04-04 15:13:10 -07:00
Michael Schneider
1f042e960d
[ASNetworkImageNode] Improve locking ( #3187 )
...
* Locking improvements for ASNetworkImageNode
* Fix typo
* Address comments
* Address comments
* Change comment to kick build
2017-03-28 10:42:59 +01:00
Flo
d5a84bf7b1
[ASImageProtocols] Fix nullables to avoid bridging crashes ( #3190 )
...
* [ASMultiplex/NetworkImageNode] Ensure ASImageProtocols are not called with nil arguments.
* [ASBasic/PINRemoteImageDownloader] Do not check for nil downloadIdentifier needlessly.
* [ASImageCacheProtocol] Make synchronouslyFetchedCachedImageWithURL URL nonnull.
2017-03-17 11:46:10 -07:00
Peter
7617b9a9f3
Merge commit 'e6ee24debcae89bd0066061b42ad1a6a73da9486'
...
# Conflicts:
# Source/ASDisplayNode.mm
# Source/ASImageNode.mm
# Source/Details/ASCollectionViewLayoutController.mm
2017-03-15 13:31:39 +03:00
Adlai Holler
0de270fdfb
Revert "Improve designated initializer usage ( #3132 )"
...
This reverts commit eaa875c7f2e08afa8b597c653be6b7c45cfff66d.
2017-03-03 15:31:28 -08:00
Michael Schneider
eaa875c7f2
Improve designated initializer usage ( #3132 )
...
* Improve designated initializer usage
* Some more changes
* Add some whitespace
* Fix some warning
2017-03-03 14:49:34 -08:00
Garrett Moon
40d3a1de7a
Trying to set the progress block with a nil identifire doesn't make sense. ( #3117 )
2017-03-01 19:51:16 -08:00
Peter
d1ab6976b5
Merge commit 'a08d9dc7328bef8cfc1b50b36cc05edb09af25a3'
...
# Conflicts:
# AsyncDisplayKit.xcodeproj/project.pbxproj
# AsyncDisplayKit/ASPagerFlowLayout.m
# AsyncDisplayKit/AsyncDisplayKit.modulemap
# AsyncDisplayKit/Details/ASCollectionDataController.h
# AsyncDisplayKit/Details/ASCollectionDataController.mm
# AsyncDisplayKit/Details/ASDataController.mm
# AsyncDisplayKit/Private/ASDataController+Subclasses.h
# AsyncDisplayKit/module.modulemap
# Source/Debug/AsyncDisplayKit+Debug.h
# Source/Details/ASCollectionElement.mm
# Source/module.modulemap
2017-03-01 15:57:40 +04:00
Adlai Holler
73ca6ab514
Shuffle & Cleanup Stuff ( #3080 )
2017-02-26 18:14:13 -08:00