Commit Graph

2436 Commits

Author SHA1 Message Date
Michael Schneider
3b91c22fdf Recreate the accessibleElements if accessed 2016-04-09 11:23:25 -07:00
Michael Schneider
39950e74b2 Remove NS_AVAILABLE_IOS(8_0); 2016-04-09 11:23:25 -07:00
Michael Schneider
28c4fede57 Add support for newly added a11y properties in iOS 8 / 9 and tvOS
New a11y properties:
- accessibilityNavigationStyle
- accessibilityHeaderElements
- accessibilityActivationPoint
- accessibilityPath
2016-04-09 11:23:25 -07:00
Michael Schneider
b284d3f606 Enable tests for accessibility properties for layer backed nodes 2016-04-09 11:23:25 -07:00
Michael Schneider
34df512eeb Remove ASNodeValidForAccessibility 2016-04-09 11:23:25 -07:00
Michael Schneider
f3303c1fb8 Add properties for accessibilty to ASDisplayNode to support layer backed nodes 2016-04-09 11:23:25 -07:00
Michael Schneider
ef31c3abf0 Copy accessibilityIdentifier to UIAccessibilityElement if a node is assigned 2016-04-09 11:23:25 -07:00
Michael Schneider
4056bf9ef3 Return NO if node i not valid for accessibility 2016-04-09 11:23:25 -07:00
Michael Schneider
03a7c55d59 Add accessibility support for shouldRasterizeDescendants and layerBacked nodese 2016-04-09 11:23:25 -07:00
Michael Schneider
9c29d0efa8 Initial commit for improved accessibility support 2016-04-09 11:23:25 -07:00
appleguy
0fbc77dd25 Merge pull request #1495 from maicki/FixASTableViewUpdateRangeCrash
[ASTableView] Fix crash if called updateCurrentRangeWithMode: on an ASTableNode
2016-04-08 21:14:59 -07:00
appleguy
141b36e700 Merge pull request #1497 from levi/update-asdk
[ASDisplayNode] Fix issue where zero was returned on idential object array lookup
2016-04-08 16:40:32 -07:00
Levi McCallum
6f41d28dd0 Fix issue where zero was returned on idential object array lookup
Reviewers: scottg, schneider, garrett

Reviewed By: garrett

Subscribers: jenkins

Differential Revision: https://phabricator.pinadmin.com/D84131
2016-04-08 16:35:40 -07:00
Michael Schneider
2a8a58ec84 Expose the rangeController in ASTableView 2016-04-08 11:13:02 -07:00
appleguy
5e3091551e Merge pull request #1494 from levi/update-asdk
[ASDisplayNode] Provide a nil check and better typing for node in layout find methods
2016-04-08 10:58:21 -07:00
Levi McCallum
2cb6969c79 Use unsigned integers for findNodes vectors
Summary: Also refector logic and naming to be simpler and more descriptive

Reviewers: schneider, chris, scottg

Reviewed By: schneider, chris, scottg

Subscribers: chris, jenkins

Differential Revision: https://phabricator.pinadmin.com/D83911
2016-04-08 10:41:49 -07:00
Scott Goodson
ccddb36ed9 [ASDisplayNode] Ensure that Visible interfaceState is cleared on removal from hierarchy for rasterized elements. 2016-04-07 14:10:34 -07:00
Scott Goodson
a9b02e8632 [ASDataController] Handle incorrect client code that returns a nil ASCellNode (assert, but use zero-size cell in production). 2016-04-06 21:34:06 -07:00
appleguy
a45783cb9d Merge pull request #1486 from levi/update-asdk
[ASInsetLayoutSpec] Prevent from creating a computed layout when child is nil
2016-04-06 21:06:24 -07:00
Levi McCallum
25096117e7 Prevent ASInsetLayoutSpec from creating a computed layout when child is nil
Reviewers: scottg, schneider, ricky, garrett

Reviewed By: garrett

Subscribers: garrett, jenkins

Differential Revision: https://phabricator.pinadmin.com/D83683

JIRA Issue(s): BRIO-4729
2016-04-06 17:05:49 -07:00
appleguy
b3d6b545f8 Merge pull request #1478 from lappp9/muting-video-nodes
[ASVideoNode] Ensure mute property is passed onto the internal player
2016-04-05 22:10:43 -07:00
appleguy
26c8b0437e Merge pull request #1474 from Adlai-Holler/AHFilterInvalidMapSnapshotDimensions
[ASMapNode] Never Provide Invalid Snapshot Dimensions to MapKit
2016-04-05 22:03:31 -07:00
appleguy
5ebfedf645 Merge pull request #1484 from Adlai-Holler/AHNoDuplicateActions
[ASControlNode] Deduplicate Target-Action-Events Entries, Fix Exception When Removing Nil Target
2016-04-05 18:48:15 -07:00
Adlai Holler
9e56cb553f [ASControlNode] Squash duplicated target-action-event tuples, fix assertion failure removing nil target 2016-04-05 15:51:53 -07:00
appleguy
40e12b9830 Merge pull request #1482 from maicki/FixSettingASEnvironmentStateExtensions
Fix setting and add merging ASEnvironmentStateExtensions
2016-04-05 15:29:42 -07:00
Michael Schneider
27cc2bec82 Add merging ASEnvironmentStateExtensions on upward propegation 2016-04-05 14:22:32 -07:00
Michael Schneider
41eb1917e4 Fix setting ASEnvironmentStateExtensions values 2016-04-05 14:22:32 -07:00
appleguy
95b9374fd5 Merge pull request #1481 from maicki/FixASLayoutableExtensibilityComments
Fix comments about maximum number of extended values in ASLayoutableExtensibility
2016-04-05 13:08:01 -07:00
Michael Schneider
5ba756eac7 Fix comments about maximum number of extended values in ASLayoutableExtensibility 2016-04-05 07:44:28 -07:00
Luke Parham
be463c0a17 muting the video node mutes the player 2016-04-05 02:37:07 -05:00
Adlai Holler
fd159aa196 [ASMapNode] Never set invalid snapshot dimensions into MapKit 2016-04-04 16:42:51 -07:00
appleguy
0ef9d295b9 Merge pull request #1469 from hannahmbanana/ASEnvironmentTweaks
[ASEnvironment - Layout] Fixes to upward propagation of ASLayoutable properties.
2016-04-02 18:35:48 -07:00
Hannah Troisi
dbad1c38e5 [ASEnvironment - Layout] Fixes to upward propagation of ASLayoutable properties. 2016-04-02 15:03:43 -07:00
Hannah Troisi
a817abd43f Merge remote-tracking branch 'facebook/master' 2016-04-01 20:07:51 -07:00
appleguy
7662cb67c1 Merge pull request #1432 from maicki/ASDataControllerCrashOnDataSourceDealloc
[ASDataController] Refactor ASDataController layout nodes methods
2016-03-31 21:49:58 -07:00
appleguy
938437d38f Merge pull request #1455 from ejensen/scrolls-to-top
[ASEditableTextNode] Synchronize scrollsToTop with scrollEnabled
2016-03-31 21:19:45 -07:00
appleguy
234d937c92 Merge pull request #1461 from hannahmbanana/examples_cleanup
[Examples Documentation] add screenshots/gifs to README.md
2016-03-31 21:14:44 -07:00
appleguy
6d1c52b042 Merge pull request #1456 from maicki/ASEnvironment
[ASEnvironment] Add support for ASEnvironment, supporting generalized state propagation both up and down node and layout spec trees.
2016-03-31 21:05:38 -07:00
appleguy
ea935456b8 Merge pull request #1437 from ejensen/editable-text-node-layout-manager
[ASEditableTextNode] Allow TextKit component customization
2016-03-31 20:46:19 -07:00
Michael Schneider
20ee9bca8d Rename ASEnvironmentStateCreate to ASEnvironmentStateMakeDefault 2016-03-31 20:43:20 -07:00
Michael Schneider
5baab95506 Add up propagation of ASEnvironmentLayoutOptionsState in ASLayoutSpec while setting a child 2016-03-31 20:43:20 -07:00
Michael Schneider
f46f5640ff Add improvements
- Remove defaults for ASEnvironmentLayoutOptionsState and ASEnvironmentHierarchyState
- Add locking for ASEnvironmentLayoutExtensibilityForwarding
- Other smaller improvements
2016-03-31 20:43:20 -07:00
Michael Schneider
4e757f0969 General improvements
- Refactor naming of ASEnvironmentCollection to ASEnvironmentState
- Remove struct pointers
- Move ASEnvironmentStatePropagation to a enum class
- Move merge functions to pure functions
- Move ASLayoutOptionsForwarding and ASLayoutableExtensibility into ASLayoutSpec and ASDisplayNode
- Remove ASLayoutableSetValuesForLayoutable and move into explicit classes (ASDisplayNode, ASTextNode)
2016-03-31 20:43:20 -07:00
Michael Schneider
65b4961802 Add extensibility support for ASEnvironmentLayoutOptionsState 2016-03-31 20:43:20 -07:00
Michael Schneider
96df35e41a Initial commit for ASEnvironment 2016-03-31 20:43:20 -07:00
appleguy
94bfc17d0d Merge pull request #1467 from hannahmbanana/master
[Documentation] update README.md to add Carthage sheild + update CocoaPods download count
2016-03-31 19:40:32 -07:00
appleguy
b54c8de27e Merge pull request #1463 from marmelroy/master
[AsyncDisplayKit] - Fix Travis issues
2016-03-31 19:39:38 -07:00
Hannah Troisi
2903d7ea1b removing files required to run website locally 2016-03-31 12:35:59 -07:00
Hannah Troisi
2b18d70de7 Merge remote-tracking branch 'facebook/master' 2016-03-31 12:31:32 -07:00
Roy Marmelstein
4415bbbd06 Workaround for https://github.com/facebook/xctool/issues/666 2016-03-31 10:10:09 +02:00