Adlai Holler
abcdaf8f55
Merge pull request #1956 from facebook/AHNoSkipEmptyUpdate
...
[ASCollectionView] Do Not Suppress Empty Updates
2016-07-20 13:41:49 -07:00
Adlai Holler
3ebddb6837
[ASCollectionView] Move the variable in
2016-07-20 13:06:00 -07:00
Adlai Holler
6a13c0365b
[ASCollectionView] Do not suppress empty updates
2016-07-20 12:53:01 -07:00
Max Gu
44a80672cb
Adding track to the requestedKeys to be loaded asynchronously so that it doesn't block the main thread
2016-07-19 20:25:32 -07:00
Michael Schneider
7096f47f90
Merge pull request #1951 from maicki/MSFixASViewControllerConstrainedSizeiOS8
...
Fixes iOS 7 and iOS 8 wrong size in viewWillAppear: while a a rotation is happening
2016-07-19 16:48:51 -07:00
Michael Schneider
90d5c97d0f
Fixes iOS 7 and iOS 8 wrong size in viewWillAppear: while a a rotation is happening
2016-07-19 16:24:47 -07:00
Max Gu
7237149b0f
Merge branch 'patch-4' of https://github.com/Xinchi/AsyncDisplayKit into patch-4
2016-07-19 15:58:56 -07:00
Max Gu
a4555869de
Re-enabling HLS video constructed from URL
...
Apple claims in the AVFoundationProgramming Guide that HLS videos can be constructed only through URL, but later with iOS 4.3 release notes it claimed to bring updates to how the HLS videos should be initialized, which works with asset too. I’ve tested with both, and it looks like initializing with asset is buggy.
2016-07-19 15:57:22 -07:00
Adlai Holler
fceae5d2f8
Merge pull request #1946 from facebook/AHDataControllerGCD
...
[ASDataController] Migrate Editing Queue to GCD for Performance/Debuggability
2016-07-18 18:42:10 -07:00
Adlai Holler
1777dae300
[ASDataController] Set context variable value
2016-07-18 18:41:51 -07:00
Adlai Holler
46a911ecf4
[ASDataController] Clean up by using a dispatch_group
2016-07-18 15:01:22 -07:00
Adlai Holler
f737d28368
Merge pull request #1947 from facebook/AHFixZeroSizeLayout
...
[ASCollectionView/ASTableView] Check for Zero-Size Correctly
2016-07-18 13:53:36 -07:00
Adlai Holler
50e8ad2e7c
[ASTableView/ASCollectionView] Ignore bounds.origin when checking for zero-size
2016-07-18 12:17:42 -07:00
Adlai Holler
fa34888d98
[ASDataController] Migrate to GCD queue to make debugging easier
2016-07-18 12:15:27 -07:00
appleguy
d4c5a09817
[ASDisplayNode+AsyncDisplay.mm] Refactor display block creation method for conciseness and readability. ( #1933 )
...
* [ASDisplayNode+AsyncDisplay.mm] Refactor display block creation method for conciseness and readability.
* [ASDisplayNode+AsyncDisplay.mm] Some additional fixes / improvements that are required for the prior commit.
* Fix one last spot of the merge with __instanceLock__.unlock();
2016-07-16 16:24:07 -07:00
Michael Schneider
6e573fba0d
Reset _calculatedSize if a new constrained size is set on the ASTextKitRenderer ( #1942 )
2016-07-16 16:23:47 -07:00
Scott Goodson
8644c03ab8
Revert "[ASDisplayNode] Short circuit measure calls that have a zero-area constrainedSize. ( #1939 )"
...
This reverts commit 3664ca67cb
2016-07-16 16:12:50 -07:00
appleguy
74bf376b2f
[ASDisplayNode] Rename _propertyLock to __instanceLock__ to avoid subclass naming collisions. ( #1941 )
2016-07-16 15:32:13 -07:00
appleguy
3664ca67cb
[ASDisplayNode] Short circuit measure calls that have a zero-area constrainedSize. ( #1939 )
...
* [ASDisplayNode] Short circuit measure calls that have a zero-area constrainedSize.
// If the constrainedSize is completely zero-area, then there is no possibility for layout calculations to be successful.
// This also avoids the issue of an inset being applied to 0, creating negative frame values.
* [ASDisplayNode] Fix to shouldMeasure change.
* One more fix.
2016-07-16 15:31:51 -07:00
Hannah Troisi
4baf9bdbfe
[Infer] Fix Infer errors/warnings ( #1938 )
...
* [Infer] Fix 11 Infer errors/warnings
* fix build error
2016-07-16 15:29:24 -07:00
Hannah Troisi
abf8d5b9aa
[Infer] change atomic properties to nonatomic ( #1932 )
2016-07-16 10:46:55 -07:00
Adlai Holler
dda7accd8e
[ASCollectionView] When resizing, invalidate after remeasuring all nodes ( #1931 )
2016-07-15 16:32:23 -07:00
Michael Schneider
3b09cbb845
Merge pull request #1929 from rcancro/textScaleFactors
...
[ASTextNode] use accessor for `pointSizeScaleFactors`
2016-07-15 16:01:02 -07:00
ricky
bd907dcffd
added comment
2016-07-15 15:39:30 -07:00
Michael Schneider
3237ccce60
Merge pull request #1930 from maicki/MSSmallCodeImprovement
...
[Followup] Small code improvements
2016-07-15 14:24:06 -07:00
Michael Schneider
9729b61dde
Add whitespace
2016-07-15 13:19:06 -07:00
Michael Schneider
fcfce5128d
Grab propertyLock to get supportsRangeManagedInterfaceState and for asking dirty layout status
2016-07-15 13:19:06 -07:00
Michael Schneider
20a49f037b
Comment adjustment for laying out nodes
2016-07-15 11:41:10 -07:00
Michael Schneider
4447ae4bd4
Move ASPerformBlockOnBackgroundThread as it already calls the method inline if it's on the main thread
2016-07-15 11:41:10 -07:00
Michael Schneider
eccd704668
Merge pull request #1928 from maicki/MSAddRelativeSizePercentage
...
[ASLayout] Add convenience functions to create relative sizes with percentage
2016-07-15 11:35:48 -07:00
Michael Schneider
729766a365
Add convenience functions to create relative sizes with percentage
2016-07-15 10:51:45 -07:00
Adlai Holler
cc8e0049c5
Merge pull request #1921 from facebook/AHRangeModeUpdatingIssues
...
[ASRangeController] Fix Major Range Mode Updating Issues
2016-07-15 10:22:36 -07:00
Adlai Holler
e7fc5a98f2
Merge pull request #1906 from facebook/AHReduceBlockInvocations
...
[Performance] Various Easy Performance Wins
2016-07-15 10:14:22 -07:00
Adlai Holler
013c1637a1
Merge pull request #1924 from maicki/MSFixASTextNodeTruncationAgain
...
[ASTextNode] Fix wrong truncation after constrained size changes
2016-07-15 10:07:06 -07:00
ricky
c403175b91
[ASTextNode] use accessor for pointSizeScaleFactors
...
I have a subclass of `ASTextNode` that uses `pointSizeScaleFactors`. Currently I have to recompute the scale factors any time the font size changes. If `_rendererAttributes` used the property accesor for the scale factors I would only have to create them when asked. I hope this little change can make it in :)
2016-07-15 08:47:25 -07:00
Michael Schneider
359785ac92
[ASDisplayNode] Add automatic measurement before layout ( #1725 )
...
* Add automatic measurement before layout
* Remove code not needed or addressed in a different PR
* Adjust comments and rename __layoutSublayouts to __layoutSubnodes
* Check before setting up a placeholder layer if the node should have a placeholder
2016-07-14 21:51:40 -07:00
Michael Schneider
a8c5ac138d
[ASDisplayNode] Always layout nodes on a background thread ( #1907 )
...
* Always layout nodes on a background thread
* Remove semaphore in ASDataController for allocating nodes and layout
* Fix variable not used error
* Remove overhead to create subarray of contexts of nodes while layout nodes
* Remove extra allocation of allocatedNodes and indexPaths array
2016-07-14 21:35:58 -07:00
Michael Schneider
705cc763fd
Fix failing ASTextNode tests
2016-07-14 19:30:44 -07:00
Adlai Holler
cac0cce0b0
[ASLayoutTransition] Make findNodesInLayoutAtIndexesWithFilteredNodes faster
2016-07-14 16:11:28 -07:00
Michael Schneider
bbc957bce5
Throw away all subcomponents of the text kit renderer if constraints are changing
...
Throw away the all subcomponents to create them with the new constrained size new as well as let the truncater do it's job again for the new constrained size. This is necessary as after a truncation did happen the context would use the truncated string and not the original string to truncate based on the new constrained size
2016-07-14 15:11:10 -07:00
Adlai Holler
fe63b7b65f
Use fast enumeration in a couple places
2016-07-14 15:10:49 -07:00
Michael Schneider
f95790f280
Merge pull request #1923 from garrettmoon/shareMemoryCache
...
Share ASDK's PINRemoteImage cache with default instance of PINRemoteI…
2016-07-14 15:00:16 -07:00
Garrett Moon
aaea4a4d85
Class was in wrong #ifdef, thank you @schneider!
2016-07-14 14:57:40 -07:00
Garrett Moon
92e16fb7a6
Share ASDK's PINRemoteImage cache with default instance of PINRemoteImage
2016-07-14 14:57:35 -07:00
Michael Schneider
fd856fc343
Merge pull request #1917 from maicki/MSFixLegacySizingASViewController
...
[ASViewController] Fix sizing of root node in ASViewController for modal presentation and root view controller
2016-07-14 14:52:10 -07:00
Michael Schneider
cd46791f9d
Move check for iOS 9 from an early return to an earlier check to prevent objc_msgSend
2016-07-14 14:50:54 -07:00
Michael Schneider
6e8772a68d
Fix sizing of root node in ASViewController for modal presentation and root view controller
2016-07-14 14:48:05 -07:00
Michael Schneider
09d1c06f68
Merge pull request #1755 from maicki/RefactorASCollectionViewLayoutInspectingUsage
...
[ASCollectionViewLayoutInspecting] Refactor usage of ASCollectionViewLayoutInspecting
2016-07-14 14:46:32 -07:00
Adlai Holler
787fd8b90b
[ASViewController] Defer range update conformance check until the actual range update
2016-07-14 11:32:50 -07:00
Adlai Holler
b0a2ba0f6d
[ASTableNode/ASCollectionNode] Make them conform directly to range updating protocol
2016-07-14 11:27:32 -07:00
