Commit Graph

3364 Commits

Author SHA1 Message Date
Adlai Holler
3446f39704 Merge pull request #1746 from maicki/FixFetchDataRangeModeMinimumDefault
Fix default tuning parameter for range mode ASLayoutRangeModeMinimum and range type ASLayoutRangeTypeFetchData
2016-06-17 11:45:43 -07:00
Hannah Troisi
46421f8684 [ASCollectionView] support UICollectionViewLayoutAttributes 2016-06-17 10:17:52 -07:00
Adlai Holler
42aa52b407 [ASDisplayNode] Put the thread affinity assertion back 2016-06-17 09:51:09 -07:00
Hannah Troisi
d96beb29de Merge remote-tracking branch 'facebook/master' 2016-06-16 22:23:35 -07:00
Vadim Spivak
e55037354c Round up editable text node to the next point (#1761)
Rounding up to the next device pixel was calculating a height smaller
than  UITextView's contentSize. This was causing the baseline to move as
the user was typing.
2016-06-16 21:59:29 -07:00
Michael Schneider
aa5d730eab Deallocate objects on a serial queue specific for deallocation (#1737)
[Performance] Prevent GCD thread explosion due to object deallocation workloads (serial deallocation queue).
2016-06-16 18:18:43 -07:00
Michael Schneider
efab1a4855 Move modifier to __weak for the highlighted layer in ASTextNode (#1756) 2016-06-16 18:12:57 -07:00
Adlai Holler
0002d333f0 [ASDisplayNodeTests] Add some removeFromSupernode tests 2016-06-16 17:59:50 -07:00
Adlai Holler
15b6f2e281 [ASLayoutTransition] Optimize add/remove subnode methods 2016-06-16 17:10:33 -07:00
Adlai Holler
f5460a44e0 [ASDisplayNode] Reduce locking in removeFromSupernode 2016-06-16 17:10:09 -07:00
Max Gu
c1275526dd Re-enabling HLS video constructed from URL
Apple claims in the AVFoundationProgramming Guide that HLS videos can be constructed only through URL, but later with iOS 4.3 release notes it claimed to bring updates to how the HLS videos should be initialized, which works with asset too. I’ve tested with both, and it looks like initializing with asset is buggy.
2016-06-14 10:15:57 -07:00
Michael Schneider
67055eecff Fix default tuning parameter for range mode ASLayoutRangeModeMinimum and range type ASLayoutRangeTypeFetchData 2016-06-13 17:03:36 -07:00
Hannah Troisi
c857e809f4 Clean up header comments (for consistent Facebook licensing info) (#1741)
[Licensing] Clean up header comments (for consistent Facebook licensing info)
2016-06-11 23:31:39 -07:00
appleguy
c211c76c64 Merge pull request #1735 from levi/betterFlatten3
[ASLayout] Clean up flattening process of ASLayout
2016-06-11 23:15:16 -07:00
appleguy
a7128cd213 Merge pull request #1605 from lappp9/override-callback-for-display-range
[ASDisplayNode] Added callbacks for entering and exiting fetch data and display ranges
2016-06-11 22:21:20 -07:00
Levi McCallum
7e8d519a9a Introduce type property to replace layout id check 2016-06-10 12:43:46 -07:00
Levi McCallum
a3e8f556a3 Clean up flattening process in ASLayout 2016-06-10 12:43:46 -07:00
Levi McCallum
4149c6b0f5 Move ASLayout frame to a computed property 2016-06-10 12:43:46 -07:00
Levi McCallum
f1f45c61a8 Copy dequeued context 2016-06-10 12:43:46 -07:00
Levi McCallum
af932e7596 Simplify ASLayout flatten BFS 2016-06-10 12:43:46 -07:00
appleguy
f72f39b445 Merge pull request #1726 from ejensen/local-animated-image
[ASNetworkImageNode] Support loading local animated images
2016-06-09 23:34:38 -07:00
appleguy
f4bc195b92 Merge pull request #1723 from ejensen/animated-image-runloop-mode
[ASImageNode] Allow configuration of animation runloop
2016-06-09 23:21:26 -07:00
appleguy
fed1fdb96c Merge pull request #1603 from maicki/ASPagerNodeRotationSupport
[ASPagerNode] Add ASPagerNode rotation support
2016-06-09 22:38:55 -07:00
Michael Schneider
389fd4b15d Further improvements for ASPagerNode rotation 2016-06-09 20:11:21 -07:00
Michael Schneider
3e8ea64a1b Update to latest state 2016-06-09 15:46:08 -07:00
Michael Schneider
1f55ef8945 Improve PagerNode sample project 2016-06-09 15:46:08 -07:00
Michael Schneider
1c6686e5d6 Improve rotation support for ASPagerNode 2016-06-09 15:46:08 -07:00
Eric Jensen
fdc57410ee Move the default animated image runloop mode to a constant, and fallback to the constant if the runloop mode is set to nil 2016-06-09 10:53:37 -07:00
Eric Jensen
91e6df0af9 Add a way to check if data is in a format supported by a class implementing ASAnimatedImageProtocol 2016-06-09 10:36:18 -07:00
Eric Jensen
1fb3ffc6f8 Replace usage of imageWithData: with imageWithContentsOfFile: 2016-06-09 10:01:59 -07:00
appleguy
1847b5e947 Merge pull request #1727 from ejensen/video-poster-fix
[ASVideoNode] Prevent setting old poster image if the asset was set to nil
2016-06-08 22:41:30 -07:00
appleguy
6632b4ec5f Merge pull request #1722 from rcancro/layoutSpecTraitObject
[ASLayoutSpec] Remove cached ASTraitCollection
2016-06-08 22:29:47 -07:00
appleguy
2cf9e62df6 Merge pull request #1692 from maicki/ASLayoutValidation
[ASLayout] Add basic infrastructure for layout validation
2016-06-08 19:32:20 -07:00
appleguy
bbffc86040 Merge pull request #1729 from levi/reverseFlatten
[Tests] Update FBSnapshotTestCase and generate @3x images
2016-06-08 19:21:18 -07:00
Michael Schneider
434102f988 Address comments from review
- Remove public NSMutableArray header for validators
- Add ASDISPLAYNODE_EXTERN_C_BEGIN/END
- Rename isRootLayout to isFinalLayoutable
2016-06-08 18:42:32 -07:00
Michael Schneider
9ff7223b77 Move validation code to ASLayoutValidation and add validation flag 2016-06-08 16:59:46 -07:00
Michael Schneider
f9e13545bf Improve layout validation
- Asserts if layout is invalid
- Add better help messages if layout is invalid
2016-06-08 16:39:03 -07:00
Levi McCallum
ca2fb0bc74 Update FBSnapshotTestCase and generate @3x images 2016-06-08 13:33:03 -07:00
Eric Jensen
5cc25686ff Correct documentation comment 2016-06-08 12:37:46 -07:00
Eric Jensen
001d3ea624 Use a strong reference to the current asset in order to prevent setting a placeholder image if the asset is set to nil while the placeholder image is generating 2016-06-08 12:37:32 -07:00
Eric Jensen
7de82b0b5b Support loading animated images from the local filesystem 2016-06-08 11:34:56 -07:00
Eric Jensen
370e5f1006 Allow configuration of ASImageNode's animation runloop 2016-06-08 10:38:43 -07:00
Michael Schneider
197950f39b Add basic infrastructure for layout validation 2016-06-08 10:35:28 -07:00
ricky
3c34d51a19 [ASLayoutSpec] Remove cached ASTraitCollection 2016-06-07 10:50:42 -07:00
appleguy
cb67671f1d Merge pull request #1719 from garrettmoon/fixParentManagesVisibilityDepth
Reset the parentManagesVisibilityDepth flag so it's checked again
2016-06-06 23:13:18 -07:00
Scott Goodson
1e3e5a56b9 [Cocoapods] Use 1.9.80 instead... 2016-06-06 14:56:40 -07:00
Garrett Moon
1e51569538 Reset the parentManagesVisibilityDepth flag so it's checked again 2016-06-06 14:38:03 -07:00
appleguy
e0abb706b7 Merge pull request #1718 from levi/fixFix
Fix boolean logic that prevents layout
2016-06-06 14:00:36 -07:00
Levi McCallum
e5d7d29eb6 Fix boolean logic that prevents layout 2016-06-06 13:57:17 -07:00
appleguy
1b07cab87b Merge pull request #1717 from levi/revertAutomaticMeasure
Revert "Merge pull request #1673 from maicki/AddAutomaticMeasureBeforeLayout"
2016-06-06 13:23:22 -07:00