Commit Graph

1800 Commits

Author SHA1 Message Date
Garrett Moon
5a4e4dcac4 Add default PINRemoteImageDownloader 2016-02-08 16:00:19 -08:00
appleguy
08017071bf Merge pull request #1198 from maicki/DisableAppTransportSecurity
Disable App Transport Security in AsyncDisplayKitTestsHost target
2016-02-08 12:23:11 -08:00
appleguy
5fc9cbe56f Merge pull request #1202 from nguyenhuy/remove_weird_file
Remove .ASVideoNode.mm.un~
2016-02-08 12:21:26 -08:00
Huy Nguyen
8dc576fed7 Remove .ASVideoNode.mm.un~ 2016-02-08 10:13:18 -08:00
Michael Schneider
e9d50ff3a1 Disable App Transport Security in AsyncDisplayKitTestsHost target
To be able to make http requests in tests we should disable the NSAppTransportSecurity of the AsyncDisplayKitTestsHost target. Otherwise tests like -[ASBasicImageDownloaderTests testAsynchronouslyDownloadTheSameURLTwice] will show an error.
2016-02-07 20:24:40 -08:00
appleguy
06bdcd0049 Merge pull request #1192 from garrettmoon/updateASTextNodeDocumentation
[ASTextNode] Indicate that truncation mode is overridden by attributes in attributedString
2016-02-06 17:43:36 -08:00
Scott Goodson
9e87813425 Micro-optimizations in ASDisplayNode that help reduce overhead when recursing large hierarchies. 2016-02-05 21:43:14 -08:00
appleguy
1d84fc4874 Merge pull request #1194 from rahul-malik/rmalik-pager-proxy-fix
Add node-block api to ASPagerNodeProxy
2016-02-05 16:02:30 -08:00
Rahul Malik
5c86eafe8f Add node-block api to ASPagerNodeProxy 2016-02-05 15:59:07 -08:00
appleguy
b974a994a9 Merge pull request #1193 from rahul-malik/rmalik-pager-fix
ASPagerNode's api was not updated while addressing comments
2016-02-05 15:13:05 -08:00
Rahul Malik
6c240a2fce ASPagerNode's api was not updated while addressing comments on the initial
ASCellNode background allocation PR. This change fixes that issue.
2016-02-05 15:09:08 -08:00
Garrett Moon
d6c06ab0bd Indicate that truncation mode is overridden by attributes in attributedString 2016-02-05 14:08:49 -08:00
appleguy
8abda67d1a Merge pull request #1185 from garrettmoon/addContentInsetToButtonNode
[ASButtonNode] Add support for contentInset and make it bit more threadsafe
2016-02-05 11:59:20 -08:00
appleguy
12647b76b3 Merge pull request #1189 from connor/revert_ascontrolnode_optimizations
Revert "Merge pull request #1162 from maicki/controlnode-init-optimization"
2016-02-05 11:33:51 -08:00
Connor Montgomery
800aa05c35 Revert "Merge pull request #1162 from maicki/controlnode-init-optimization"
This reverts commit 35a4b268d6, reversing
changes made to 4201df5f31.
2016-02-05 13:49:00 -05:00
Scott Goodson
454d68516b Remove overly-cautious thread affinity assertions for threadsafe properties. 2016-02-04 19:44:44 -08:00
Garrett Moon
64f36d4499 Add support for contentInset and make ASButtonNode a bit more threadsafe 2016-02-04 17:40:16 -08:00
appleguy
e2be6440c2 Merge pull request #1184 from nguyenhuy/fix_build_errors
Fix ASRangeControllerBeta causing build errors
2016-02-04 17:34:50 -08:00
Huy Nguyen
a9d91957b6 Fix ASRangeControllerBeta causing build errors 2016-02-04 17:29:36 -08:00
appleguy
1655d0a0c7 Merge pull request #1178 from nguyenhuy/range_tuning_params_follow_up
More on range mode and range controller
2016-02-04 16:59:42 -08:00
appleguy
cc5a5557a9 Merge pull request #1173 from rahul-malik/rmalik-async-node-alloc
[ASCellNode] Move allocation off the main thread
2016-02-04 16:57:49 -08:00
Rahul Malik
c4f489b074 Address comments. 2016-02-04 16:56:29 -08:00
Huy Nguyen
a7df20d120 Update range mode selection logic in ASRangeControllerBeta 2016-02-04 16:54:31 -08:00
Huy Nguyen
79f7450742 ASPagerNode less aggressively pre-renders 2016-02-04 16:53:53 -08:00
Huy Nguyen
e5e34313ed ASRangeController (stable) doesn't handle visible range now because the range is gone 2016-02-04 16:52:33 -08:00
Huy Nguyen
dc93192b87 Address Levi' comment: better method name in ASRangeControllerBeta 2016-02-04 16:52:33 -08:00
Huy Nguyen
8c83e1a78a Avoid asking for interface state multiple times in ASRangeControllerBeta 2016-02-04 16:52:33 -08:00
Huy Nguyen
f09024556b Switch to minimum mode when the node is no longer visible 2016-02-04 16:52:33 -08:00
Huy Nguyen
260879db7d Improve documentation of ASLayoutRangeMode 2016-02-04 16:52:33 -08:00
Huy Nguyen
b3b28b0df9 Reuse visible index paths of when tuning params of a certain range type is zero 2016-02-04 16:52:30 -08:00
Huy Nguyen
175b9da251 Remove visible range type 2016-02-04 15:44:47 -08:00
Huy Nguyen
4cf0e3e380 Update range tunining params for ASPagerNode 2016-02-04 15:44:47 -08:00
Huy Nguyen
fda9efafa6 Add timestamp to notifications of rendering engine and avoid race conditions in ASRangeControllerBeta
- Accurately remove notification observer
2016-02-04 15:44:44 -08:00
Huy Nguyen
3c135788cb Less work when RangeControllerLoggingEnabled is false 2016-02-04 14:15:07 -08:00
Rahul Malik
521c3fa1c1 Move ASCellNode allocation off the main thread by the addition of a node block
API in ASDataController. Move allocations and loaded node layouts to occur
during batch layout phase.
2016-02-04 10:38:59 -08:00
appleguy
35a4b268d6 Merge pull request #1162 from maicki/controlnode-init-optimization
[ASControlNode] Optimize init method - avoid creating ASPendingState if possible (subclassed by button, text, image nodes)
2016-02-03 22:38:23 -08:00
appleguy
4201df5f31 Merge pull request #1174 from levi/implicitHierarchyFix
Wrap implicit hierarchy management behind beta feature flag
2016-02-03 20:56:15 -08:00
Levi McCallum
cd94df1106 Wrap implicit hierarchy management behind beta feature flag 2016-02-03 20:08:30 -08:00
appleguy
6d11df735b Merge pull request #1163 from nguyenhuy/range_tuning_params
Range controller automatically extends to full mode
2016-02-03 19:09:32 -08:00
Michael Schneider
597aa02c8e Remove target added state and and instead check _controlEventDispatchTable if a target was added 2016-02-03 18:53:20 -08:00
appleguy
a9c60e37ea Merge pull request #1168 from garrettmoon/preventDownscaling
[ASImageNode] Allow prevention of downscaling
2016-02-02 19:11:42 -08:00
Garrett Moon
1b08114eca Allow prevention of downscaling 2016-02-02 19:10:12 -08:00
appleguy
f1e000906d Merge pull request #1160 from Adlai-Holler/AHUpdateSwiftExample
[Swift] Update Swift Example, resolve build issue with some Swift projects.
2016-02-02 15:57:40 -08:00
Huy Nguyen
19335d8c9e Add rangeMode APIs 2016-02-02 11:58:18 -08:00
Michael Schneider
12e2b535db Use instance variable for tracking if a target was added to ASControlNode 2016-02-02 08:30:52 -08:00
Huy Nguyen
69e674c1c8 Range controller registers to rendering engine and extern to full range if needed 2016-02-02 01:23:04 -08:00
Huy Nguyen
1145b6e40e Better decision on when to use full range 2016-02-01 23:43:55 -08:00
Adlai Holler
46b1f9fa8c Make ASTextNodeTypes.h public 2016-02-01 23:01:03 -08:00
Michael Schneider
ddf50b20bd Use is target added state additionally to the enabled state to check if touches should be tracked 2016-02-01 20:13:23 -08:00
Michael Schneider
d1c2da07e7 No need to set userInteractionEnabled in the ASTextNode init method
The userInteractionEnabled state will be set by ASControlNode in viewDidLoad to the fitting value.
2016-02-01 20:11:37 -08:00