Levi McCallum
5eb75d6bc7
Add support for sectionInset in ASCollectionView in property and delegate form
2015-08-03 14:36:29 -07:00
appleguy
16ed66c3a1
Merge pull request #550 from marmelroy/issue-549
...
Access to underlying UITextView for more configuration options.
2015-07-30 22:04:30 -07:00
appleguy
e76fa2794f
Merge pull request #589 from connor/returnKeyType
...
Add support for configuring `returnKeyType` on ASEditableTextNode.
2015-07-30 15:23:48 -07:00
Connor Montgomery
ca5e9e7dc3
Add support for configuring on ASEditableTextNode.
2015-07-30 15:19:00 -04:00
appleguy
5482213e2e
Merge pull request #584 from facebook/AssertionsAndTesting
...
Implement warning assertion for supplementary views in ASCollectionView.
2015-07-25 21:47:16 -07:00
Scott Goodson
46bbe479ae
Implement warning assertion for supplementary views in ASCollectionView.
...
Make sure ASTableViewStressTest passes. It was sometimes testing a scenario UITableView itself doesn't support.
2015-07-25 21:25:40 -07:00
appleguy
f3b8216a10
Merge pull request #582 from eanagel/fix-travis
...
Attempt to fix travis by specifying cocoapods 0.37.2 explicitly
2015-07-25 09:36:58 -07:00
Ethan Nagel
9b427576f2
Attempt to fix travis by specifying cocoapods 0.37.2 explicitly
2015-07-24 23:22:57 -07:00
Ethan Nagel
6e13c3ebab
Attempt to fix travis by specifying cocoapods 0.37.2 explicitly
2015-07-24 23:05:14 -07:00
Roy Marmelstein
6b38000941
A simpler, cleaner implementation
2015-07-22 11:05:27 +02:00
appleguy
5dae5dffb6
Merge pull request #578 from eanagel/update-podfile-lock
...
Update Podfile.lock to match earlier changes to Podfile.
2015-07-21 18:56:49 -07:00
Ethan Nagel
451beda238
Update Podfile.lock to match earlier changes to Podfile.
2015-07-21 09:38:40 -07:00
appleguy
2ddfbefaab
Merge pull request #575 from eanagel/new-auto-adjust-content
...
Take 2: Automatically adjust content offset for insertion/deletion
2015-07-20 22:21:41 -07:00
Ethan Nagel
bf0766169b
PR Feedback: Require main thread for all edit commands, various cleanup.
2015-07-20 22:08:19 -07:00
Ethan Nagel
f497639124
Add support automatically adjusting the content offset to UITableView as well as support for performing endUpdates with no animations. Additionally, there are critical bug fixes for ASDataController (begin/end updates delegates not called in correct order) and ASRangeController (failure to fully refresh internal state when inserts or delete are made.)
2015-07-20 14:05:56 -07:00
Roy Marmelstein
3c71289927
lazy creation of textview in accessor after assert
2015-07-18 16:31:13 +02:00
Roy Marmelstein
6b970e0e4a
Display node assert
2015-07-18 16:29:25 +02:00
Roy Marmelstein
36b92205ed
Brace style
2015-07-18 16:10:32 +02:00
appleguy
d5086bd64f
Merge pull request #568 from eanagel/update-astable-test
...
Update ASTableView test
2015-07-17 18:48:43 -07:00
appleguy
36884cc53e
Merge pull request #573 from eanagel/fix-endUpdates-async-when-invalid
...
Prevent making async updates to UITable|CollectionView when asycDataSource is cleared
2015-07-17 17:54:10 -07:00
Ethan Nagel
c14ecd7e99
short-circuit editing calls after the asyncDataSource has been set to nil (ASCollectionView)
2015-07-16 20:26:45 -07:00
Ethan Nagel
9762e7cfe6
short-circuit editing calls after the asyncDataSource has been set to nil (ASTableView)
2015-07-16 20:26:28 -07:00
Ethan Nagel
3da7305abb
Wait to begin thrashing until we have completed reloading the data so we aren't trying to do both operations concurrently.
2015-07-15 16:31:01 -07:00
Ethan Nagel
8c72118e69
Don't abuse the CI servers so much. Note - With this configuration we will often pass with a known race issue we currently have. Making ASTableViewStressTest more interesting so we can reliably reproduce the issue there.
2015-07-15 10:19:03 -07:00
appleguy
cfbf03f4e0
Merge pull request #567 from eanagel/FBSnapshotTestCase-version
...
Fb snapshot test case version
2015-07-14 13:56:04 -07:00
Ethan Nagel
98bdae8690
Merge branch 'master' into update-astable-test
2015-07-13 14:39:28 -07:00
Ethan Nagel
f1f124f8ac
Merge branch 'master' into FBSnapshotTestCase-version
2015-07-13 14:36:51 -07:00
Ethan Nagel
13f71d6672
update Podfile to require FBSnapshotCase 1.8.1 because v2.0+ requires frameworks and we haven't tried enabling them yet.
2015-07-13 14:35:54 -07:00
Ethan Nagel
f010b0f3e3
Update ASTableView test to be more random and more rigorous.
2015-07-13 14:34:10 -07:00
Roy Marmelstein
fd3eb94fcb
Add main thread warnings and setter/getter assert
2015-07-12 21:35:42 +02:00
appleguy
1bc972373a
Merge pull request #558 from nguyenhuy/553_fix_remaining_docblocks
...
Fix all remaining docblocks
2015-07-12 12:18:23 -07:00
Huy Nguyen
8f83e1ae8c
[appledoc] Should generate docs for layout headers.
2015-07-12 17:27:47 +07:00
Huy Nguyen
3992e9b09b
[appledoc] Fix all remaining warnings.
2015-07-12 17:27:44 +07:00
appleguy
652f2255d1
Merge pull request #555 from nguyenhuy/clean_up_layout_spec
...
Clean up #468
2015-07-11 20:39:11 -07:00
Huy Nguyen
75983ca3e5
Merge branch 'master' into clean_up_layout_spec
2015-07-12 08:17:36 +07:00
appleguy
979774f969
Merge pull request #551 from ryanfitz/multiplex-image-node-clear-contents
...
releasing downloaded image when multiplex image node exits render range
2015-07-11 14:57:49 -07:00
Ryan Fitzgerald
4383e9ab2b
releasing downloaded image when multiplex image node exits render range
2015-07-11 09:27:01 -04:00
appleguy
4aed9180d6
Merge pull request #554 from nguyenhuy/553_appledoc
...
Fix some appledoc warnings
2015-07-10 17:51:14 -07:00
Huy Nguyen
bbadc9a1e9
Update nodes in Kittens example to use new signature of layoutSpecThatFits:..
2015-07-10 19:46:32 +07:00
Huy Nguyen
e1fd58268c
Clean up #468 :
...
- -layoutSpecThatFits: must return an ASLayoutSpec.
- Move ASDisplayNode's -measureWithSizeRange: redeclaration to ASDisplayNode.h.
- Rename ASStackLayoutChild.h to ASStackLayoutDefines.h.
- Rename ASStaticLayoutSpecDimension.h to ASRelativeSize.h.
- Don't import ASLayout.h in other headers to prevent circular inclusions.
- Explain use cases of ASLayout's initializers.
- Clean up ASInternalHelpers.h.
2015-07-10 19:41:17 +07:00
Huy Nguyen
cfac6c992a
[appledoc] Fix appledoc warnings. ( #553 )
2015-07-10 19:02:04 +07:00
Roy Marmelstein
95016021b4
Access to underlying UITextView for more configuration options.
2015-07-09 16:09:20 +02:00
appleguy
6703c95aeb
Merge pull request #543 from victormayorov/master
...
Implemented test for crash in ASCollectionView on reloadData
2015-07-08 12:46:49 -07:00
appleguy
4272164db3
Merge pull request #545 from ryanfitz/display-node-memory-leak-fix
...
fixed retain cycle between display node and its stored layout
2015-07-08 12:42:59 -07:00
Ryan Fitzgerald
83ac5ad823
changing layoutableObject to be a weak reference to avoid retain cycle between ASDisplayNode and its Layout
2015-07-08 09:58:31 -04:00
Victor Mayorov
01771f7860
Implemented test for crash in ASCollectionView on reloadData
2015-07-07 23:14:54 -07:00
appleguy
b859fdf4eb
Merge pull request #542 from grigaci/fixDuplicateSymbols
...
Issue #541 Fix duplicate symbols on ASIndexPath with extern header and implementation file.
2015-07-07 10:15:38 -07:00
Bogdan Iusco
a0fcecc469
Fix duplicate symbols on ASIndexPath
2015-07-07 18:23:04 +03:00
appleguy
37b31a2917
Merge pull request #468 from nguyenhuy/layout_node
...
AsyncDisplayKit 2.0 Beta: Complete Flexbox layout system, with elimination of code duplication between sizing and layout for manual implementations! Check out ASLayoutSpec, ASLayout, and methods like -layoutSpecThatFits:.
2015-07-06 22:57:13 -07:00
Huy Nguyen
9678adaa93
Merge branch 'master' into layout_node
2015-07-06 22:21:32 +07:00
