Commit Graph

1520 Commits

Author SHA1 Message Date
appleguy
8a5f080fcc Merge pull request #1026 from 1nput0utput/ASControlNodeMutationCrash
[ASControlNode] Copy event table before calling action methods, as they may trigger action removal.
2016-01-03 20:18:30 -08:00
appleguy
005408bd2c Merge pull request #1030 from facebook/OthogonalEfficiency
[ASRangeController] Inspect delegate's ASInterfaceState to delay preloading beyond viewport until visible.
2016-01-03 20:17:25 -08:00
appleguy
5737f31a58 Merge pull request #1029 from rahul-malik/rmalik-asviewcontroller-generics
[ASViewController] Update interface to use lightweight generics (covariant node type).
2016-01-03 19:31:26 -08:00
Scott Goodson
984fe43997 [ASRangeController] Inspect delegate's ASInterfaceState to delay preloading beyond viewport until visible. 2016-01-03 19:14:07 -08:00
Rahul Malik
a509b7523f Update interface of ASViewController to use lightweight generics. This allows
subclasses of ASViewController to specify the type of ASDisplayNode it
contains which allows for stronger type-checking and auto-completion against
the specified type.

Example Subclass Declaration:
@interface MyASViewController : ASViewController<MyASDisplayNodeSubclass *>
@end
2016-01-03 18:56:09 -08:00
Rajinder Ramgarhia
688e8d27de Add comment explaning the change 2016-01-03 11:02:33 -05:00
appleguy
95bd2c264c Merge pull request #1027 from facebook/ASCollectionInternal
Introduce ASCollectionInternal file and create always-available ASCView -> ASCNode backpointer.
2016-01-02 00:05:04 -08:00
Scott Goodson
25b6f29584 Introduce ASCollectionInternal file and create always-available ASCView -> ASCNode backpointer. 2016-01-01 23:36:00 -08:00
Rajinder Ramgarhia
73373ee17b Fix ASControlNode mutation crash 2016-01-01 22:27:08 -05:00
Scott Goodson
1d1a248167 Bump podspec to 1.9.5 for upcoming development cycle, now that 1.9.4 is tagged and launched. 2016-01-01 01:35:11 -08:00
appleguy
c40c2d383b Merge pull request #1024 from facebook/RangeControllerBeta
[ASRangeController] Newly rewritten, functional-style range controller based on ASInterfaceState.
2016-01-01 01:33:33 -08:00
Scott Goodson
b273f358f5 [ASRangeController] Initial implementation of functional-style, ASInterfaceState-based range controller. 2016-01-01 00:48:44 -08:00
Scott Goodson
7a9cd1f930 [ASRangeController] Introduce totally rewritten range controller based on ASInterfaceState. 2015-12-31 17:59:59 -08:00
Scott Goodson
8f914f8430 Fix logic error in handling enablement of beta display range. 2015-12-31 15:38:32 -08:00
Scott Goodson
aee7b3b77a Remove padding workaround from old CoreText days.
This is a vestige from Paper.  Discussion: https://github.com/facebook/AsyncDisplayKit/issues/1013
2015-12-31 01:52:08 -08:00
appleguy
640568aff8 Merge pull request #1022 from facebook/UICVUnsupported
Prevent calling unsupported UICollectionViewDelegate methods (supplementary view appearance)
2015-12-31 01:03:33 -08:00
Scott Goodson
df9f433353 Prevent calling unsupported UICollectionViewDelegate methods (supplementary view appearance) 2015-12-31 00:21:20 -08:00
appleguy
0636ec44ed Merge pull request #1021 from facebook/revert-1008-bridge-uitableviewcell-pointinside
Revert "[ASCellNode] Forward pointInside to node implementation from UITableViewCell."
2015-12-30 23:45:15 -08:00
appleguy
50c97b2636 Revert "[ASCellNode] Forward pointInside to node implementation from UITableViewCell." 2015-12-30 23:42:18 -08:00
appleguy
5a7772a0ae Merge pull request #1020 from facebook/RangeDeletions
Ensure that ASRangeController immediately removes any deleted nodes from its range state.
2015-12-30 23:07:32 -08:00
Scott Goodson
ffcddf36e2 Ensure that ASRangeController immediately removes any deleted nodes from its range state. 2015-12-30 22:42:11 -08:00
appleguy
9b9d8bc9b6 Merge pull request #1016 from facebook/RasterizationUnloadingNodes
Ensure that the uncommon __unloadNode codepath does not unintentionally trigger node removal.
2015-12-30 00:23:06 -08:00
appleguy
cc15d74e67 Merge pull request #1008 from yury/bridge-uitableviewcell-pointinside
[ASCellNode] Forward pointInside to node implementation from UITableViewCell.
2015-12-29 23:25:48 -08:00
Scott Goodson
df3ce787f7 Ensure that the uncommon __unloadNode codepath does not unintentionally trigger node removal. 2015-12-29 23:11:33 -08:00
appleguy
95e28d6c11 Merge pull request #1015 from facebook/CollectionTableLayers
Use _ASDisplayLayer for both ASTableView and ASCollectionView.  zeroContentInsets to fix UIKit.
2015-12-29 23:10:43 -08:00
Scott Goodson
051f1f6cdd Use _ASDisplayLayer for both ASTableView and ASCollectionView. zeroContentInsets to fix UIKit. 2015-12-29 22:24:44 -08:00
appleguy
b1b9ad23d6 Merge pull request #1014 from facebook/PagerProxy
[ASPagerNode] Ensure delegate property can be set before the view is loaded.
2015-12-29 21:18:21 -08:00
Scott Goodson
1870208153 [ASPagerNode] Ensure delegate property can be set before the view is loaded and is not overwritten. 2015-12-29 20:46:42 -08:00
yury
83960065ed Code style fix 2015-12-29 12:10:08 +03:00
appleguy
0dc017918d Merge pull request #1012 from NatashaTheRobot/master
[Swift] Add Readme code snippet with example usage of an ASDisplayNode.
2015-12-28 23:06:10 -08:00
Natasha Murashev
90af0d393b Update README.md 2015-12-29 16:55:48 +13:00
Natasha Murashev
2ff683bc0b Added Swift example to README 2015-12-29 16:54:20 +13:00
yury
382326ea84 Bridge UITableViewCell pointInside to ASNodeCell
Allow ASNodeCell to specify pointInside of UITableViewCell.
This is very usefull, if ASNodeCell is presented as bubble aligned to
left or right (like Messages.app) and we need to be able to select row
only if user taps on bubble.
2015-12-28 16:11:50 +03:00
appleguy
4c4f0c8932 Merge pull request #1006 from facebook/ASNetworkImageFileURLs
[ASNetworkImageNode] Improve handling of file URLs for images.
2015-12-27 17:11:59 -08:00
appleguy
9264496939 Merge pull request #1005 from facebook/ASDisplayNodeContentsPreservation
[ASDisplayNode] Preserve contents after non-range-managed nodes are removed from superviews or windows.
2015-12-27 17:11:49 -08:00
Scott Goodson
b75b72c660 Improve handling of file URLs for ASNetworkImageNode.
Details discussed in https://github.com/facebook/AsyncDisplayKit/pull/1003.  This PR supercedes that one.
2015-12-27 16:38:34 -08:00
Scott Goodson
55861b3de1 Update the expectations of the tests now that the clearContents behavior is corrected. 2015-12-27 16:37:33 -08:00
appleguy
e56315dba9 Merge pull request #1004 from facebook/SupplementaryNodeSectionReloading
Supplementary nodes must be added to the completed nodes after their measurement completes.
2015-12-27 16:03:14 -08:00
Scott Goodson
93498d8240 [ASDisplayNode] Preserve contents after non-range-managed nodes are removed from superviews or windows.
This behavior changed in 1.9.3 and introduced flickering in some cases.  Preserving the contents is closer to UIKit behavior.
2015-12-27 15:35:43 -08:00
Scott Goodson
690f90a899 Supplementary nodes must be added to the completed nodes after their measurement completes following individual section reloads. 2015-12-27 15:34:26 -08:00
appleguy
f87b915162 Merge pull request #1002 from facebook/TableCollectionNodes
[ASTableView, ASCollectionView] Implement node-backing for ASTableView and ASCollectionView, with a strong back-pointer in these cases.
2015-12-26 23:29:31 -08:00
Scott Goodson
44feece701 Implement node-backing for ASTableView and ASCollectionView, with a strong back-pointer in these cases. 2015-12-26 23:05:34 -08:00
appleguy
02ab9e230f Merge pull request #1000 from facebook/EnsureDisplay
PR #1000 on GitHub!  Provide a Beta API to enable the new, high efficiency render-ahead mechanism.
2015-12-26 22:59:59 -08:00
Scott Goodson
4b560a703a PR #1000 on GitHub! Provide a Beta API to enable the new, high efficiency render-ahead mechanism. 2015-12-26 16:34:44 -08:00
appleguy
e5988138e9 Merge pull request #999 from facebook/BetaSwitchRangeController
Add ability to enable new rendering range with a class method in ASDisplayNode+Beta.h
2015-12-26 14:24:26 -08:00
Scott Goodson
a1429ea23b Add ability to enable new rendering range with a class method in ASDisplayNode+Beta.h 2015-12-26 14:22:24 -08:00
appleguy
830659b561 Merge pull request #998 from facebook/TestCoverageXcode7
Disable "intrument program flow" to fix error spew after running tests.  Enable Xcode 7 UI for code coverage.
2015-12-26 14:12:11 -08:00
Scott Goodson
ffeb514802 Disable "intrument program flow" to fix error spew after running tests. Enable Xcode 7 UI for code coverage. 2015-12-26 13:35:48 -08:00
appleguy
b50d7427f8 Merge pull request #996 from facebook/ReenableCodeCoverage
Re-enable program flow instrumentation for Coveralls.  More null-specifiers.
2015-12-25 22:41:51 -08:00
Scott Goodson
7dff6ffa14 Re-enable program flow instrumentation for Coveralls. More null-specifiers.
This does cause tests to crash at the end, which unfortunately seems like a known Xcode 7 bug.
2015-12-25 22:13:35 -08:00