Robin Chou
bdd4baf933
Re-enables HLS support (can't use AVAsset for HTTP live stream media).
2016-04-18 22:38:47 -04:00
Michael Schneider
8d20321d67
Fix ASTableNode / ASCollectionNode backgroundColor does not work
...
If the background color is applied via the pending state it's applied to the layer of the UICollectionView / UITableview. Unfortunately UITableView / UICollectionView does not consider using the layer backgroundColor property as it's background color, so it needs to be applied to the view after the ASCollectionNode / ASTableNode did load and the view is available
2016-04-18 15:52:22 -07:00
Michael Schneider
9d07336c75
Fix static analyzer issue with common indexes algorithm in _asdk_commonIndexesWithArray:
...
The issue was: The left operand of '>=' is a garbage value in else if check for lengths[i+1][j] ... I had to rewrite the algorithm to quiet the static analyzer.
2016-04-18 14:38:32 -07:00
Eric Jensen
c1c1358baf
Fix video stalling by pausing the video after backgrounding the application
2016-04-18 13:53:43 -07:00
Eric Jensen
983c2f1f49
Replacing ASVideoNode's playButton now cleans-up the previous button's state
2016-04-18 13:53:43 -07:00
Eric Jensen
cdb926c0a1
Correct mismatch between video gravity and placeholder image content mode
2016-04-18 13:53:43 -07:00
Eric Jensen
651a6bb3e4
Add nullability annotations and documentation comments to ASVideoNode
2016-04-18 13:53:43 -07:00
appleguy
103506beec
Merge pull request #1534 from hannahmbanana/mapSnapshotBug
...
[ASMapNode] Defer snapshots triggered before layout occurs to reduce unnecessary snapshots.
2016-04-18 13:34:56 -07:00
Hannah Troisi
1b3ca72877
Fix preexisting code - missing super call
2016-04-17 22:49:14 -07:00
appleguy
2a1617d80c
Merge pull request #1545 from facebook/Video
...
[ASVideoNode] Cleanup from recent diffs, standardizing on .asset rather than .url.
2016-04-17 22:08:17 -07:00
Hannah Troisi
1ff07b2233
Changed comment for clarity.
2016-04-17 21:53:01 -07:00
Scott Goodson
cd25facda5
[Build] Addressing some linker warnings in the test target.
2016-04-17 21:07:35 -07:00
Hannah Troisi
354b972e73
Renamed instance variable & improved comment per request
2016-04-17 20:45:50 -07:00
appleguy
322d85e738
Merge pull request #1511 from maicki/ASLayoutSpecOptimizations
...
[ASLayoutSpec] Improvements for ASLayoutSpec's internal implementation of child / children properties.
2016-04-17 20:26:54 -07:00
appleguy
9c26ebdec9
Merge pull request #1524 from ejensen/node-traversal-nullability
...
[ASDisplayNodeExtras] Include __kindof in nullability annotations for hierarchy traversal methods.
2016-04-17 20:20:17 -07:00
Scott Goodson
11744b7f31
[ASVideoNode] Cleanup from recent diffs, standardizing on .asset rather than .url.
2016-04-17 20:12:37 -07:00
appleguy
94d0d908dc
Merge pull request #1323 from gazreese/AVPlayerItem-construction
...
[ASVideoNode] Add support for HTTP Live Streaming Video
2016-04-17 19:30:23 -07:00
appleguy
30a0c471ca
Merge pull request #1528 from ejensen/instancetype
...
[Refactoring] Replace id with instancetype in initializers
2016-04-16 20:53:41 -07:00
appleguy
954ea7597f
Merge pull request #1538 from nguyenhuy/remove_ASDisplayNodeExtraIvars
...
[ASDisplayNode][Refactoring] Remove ASDisplayNodeExtraIvars
2016-04-16 16:54:49 -07:00
appleguy
46fbc6cc7c
Merge pull request #1539 from nguyenhuy/remove_ASDisplayNode_async_sizing
...
[ASDisplayNode][Refactoring] Remove internal and unused async sizing methods
2016-04-16 16:53:55 -07:00
Aaron Schubert
5897c1e1b4
[ASMapNode] Remove false assert. This handles #1534
2016-04-16 13:19:07 +01:00
appleguy
fcdc7966cc
Merge pull request #1536 from garrettmoon/upstream-renderer-lock
...
[ASTextNode] Add locking around NSTextContainer's constrainedSize
2016-04-15 20:57:32 -07:00
Huy Nguyen
5a677915ba
ASDisplayNode should bail early if a scheduled transition was invalidated before its block executes
...
- Idea borrowed from _enqueueAsyncSizingWithSentinel
2016-04-15 22:08:48 +03:00
Huy Nguyen
a35647b200
Remove unused _enqueueAsyncSizingWithSentinel and asyncSizingQueue methods of ASDisplayNode
2016-04-15 22:08:21 +03:00
Huy Nguyen
3dc2ceb0ad
Remove ASDisplayNodeExtraIvars
2016-04-15 21:48:11 +03:00
Garrett Moon
dd998b086f
I think this needs a lock.
...
Summary: Looks like this isn't being locked when it should be.
Reviewers: ricky, levi, scottg, schneider
Reviewed By: scottg, schneider
Subscribers: jenkins
Differential Revision: https://phabricator.pinadmin.com/D84952
2016-04-15 10:41:31 -07:00
Michael Schneider
c0927f8028
Create helper function to get text range rects without locking
...
Add helper function that should be called within performBlockWithLockedTextKitComponents: in
an already locked state to prevent a deadlock
2016-04-15 09:57:24 -07:00
Michael Schneider
9fdce828c1
Small improvements for ASLayoutSpec
...
- Add nullable for returning children
- Store default child and children as properties
- Use vector for creating final children
2016-04-15 07:11:24 -07:00
Michael Schneider
a9d0542d8f
If trailing rect was set early return
2016-04-15 07:10:22 -07:00
Michael Schneider
91b6995987
Fix deadlock calling trailingRect on a ASTextNode
2016-04-15 07:10:22 -07:00
Hannah Troisi
c981aeb09d
[ASMapNode] snapshot can be triggered before layout and cause exception (e.g. setAnnotations)
2016-04-14 23:05:35 -07:00
Garrett Moon
755c5feaf8
Levi's comments
2016-04-13 14:23:02 -07:00
Garrett Moon
24c26014a7
Fix example builds
2016-04-13 14:23:02 -07:00
Garrett Moon
b56e20853b
Prevent retain cycle, clear out animatedImage on _clearImage.
2016-04-13 14:23:02 -07:00
Garrett Moon
e9b57d9da4
Address comments and cleanup
2016-04-13 14:23:02 -07:00
Garrett Moon
f4b526a8db
Fix non example build
2016-04-13 14:23:02 -07:00
Garrett Moon
1b316217ef
Downstream ASAnimatedImage
2016-04-13 14:23:02 -07:00
Garrett Moon
beba9031ef
Expose public properties properly
...
Reviewers: rmalik
Reviewed By: rmalik
Differential Revision: https://phabricator.pinadmin.com/D82227
2016-04-13 14:23:02 -07:00
Garrett Moon
3bcbfb149d
Add support for animated GIFs
...
Summary:
Use NSData as key
Add chunking of files
Add support for Animated Images
This adds support for GIF playback in ASDK. It's not currently ready
for merging to public ASDK – for one the GIF decompression may make
more sense in PINRemoteImage.
Removed duration as it wasn't used
Make cover image lazily loaded
Differential Revision: https://phabricator.pinadmin.com/D82033
2016-04-13 14:23:02 -07:00
Eric Jensen
527397ba7e
Replace id with instancetype in initializers
2016-04-13 11:20:05 -07:00
Eric Jensen
fcab11ee8d
Use __kindof annotation for subside traversal methods that filter based on class
2016-04-12 17:24:28 -07:00
Eric Jensen
2d86dd8ead
Correct nullability annotations of node traversal helpers
2016-04-12 17:15:36 -07:00
Michael Schneider
d0023a97f7
Fix fetching will continually trigger in a loop after reaching end of content
...
Don't schedule a new check for a batch fetch if no data changed previous batch fetch
2016-04-12 17:14:43 -07:00
Scott Goodson
8ccef1e99f
[ASEnvironment] Fix incomplete gating of upward propagation of layout properties (disabled for now).
2016-04-11 20:34:24 -07:00
appleguy
74407d50c4
Merge pull request #1513 from maicki/NodesLayerInLayerAccessiblity
...
[ASDisplayNode] Add handling layer backed accessibility elements within layer backed nodes
2016-04-11 17:46:19 -07:00
Michael Schneider
45d50624d1
Fix disabled state propagation for final layoutable
2016-04-11 17:41:48 -07:00
Michael Schneider
2fade63f1b
Add handling layer backed accessibility elements within layer backed nodes
2016-04-11 12:59:04 -07:00
Scott Goodson
678c201dbc
[ASLayout] Add additional validation step to intercept incorrect values in production and safely zero them out.
...
These conditions already had assertions, but at runtime, an insufficiently tested and incorrect ASLayoutSpec could
generate values that cause UIKit to enter an infinite loop (e.g. inside of UICollectionView layout validation).
2016-04-10 16:42:22 -07:00
Michael Schneider
ed0ed74b72
Add switch to enable / disable layout option properties
2016-04-10 15:04:49 -07:00
Michael Schneider
3c66013088
Remove logging message
2016-04-10 14:23:33 -07:00