Scott Goodson
cd25facda5
[Build] Addressing some linker warnings in the test target.
2016-04-17 21:07:35 -07:00
Scott Goodson
11744b7f31
[ASVideoNode] Cleanup from recent diffs, standardizing on .asset rather than .url.
2016-04-17 20:12:37 -07:00
appleguy
94d0d908dc
Merge pull request #1323 from gazreese/AVPlayerItem-construction
...
[ASVideoNode] Add support for HTTP Live Streaming Video
2016-04-17 19:30:23 -07:00
appleguy
30a0c471ca
Merge pull request #1528 from ejensen/instancetype
...
[Refactoring] Replace id with instancetype in initializers
2016-04-16 20:53:41 -07:00
appleguy
954ea7597f
Merge pull request #1538 from nguyenhuy/remove_ASDisplayNodeExtraIvars
...
[ASDisplayNode][Refactoring] Remove ASDisplayNodeExtraIvars
2016-04-16 16:54:49 -07:00
appleguy
46fbc6cc7c
Merge pull request #1539 from nguyenhuy/remove_ASDisplayNode_async_sizing
...
[ASDisplayNode][Refactoring] Remove internal and unused async sizing methods
2016-04-16 16:53:55 -07:00
appleguy
fcdc7966cc
Merge pull request #1536 from garrettmoon/upstream-renderer-lock
...
[ASTextNode] Add locking around NSTextContainer's constrainedSize
2016-04-15 20:57:32 -07:00
Huy Nguyen
5a677915ba
ASDisplayNode should bail early if a scheduled transition was invalidated before its block executes
...
- Idea borrowed from _enqueueAsyncSizingWithSentinel
2016-04-15 22:08:48 +03:00
Huy Nguyen
a35647b200
Remove unused _enqueueAsyncSizingWithSentinel and asyncSizingQueue methods of ASDisplayNode
2016-04-15 22:08:21 +03:00
Huy Nguyen
3dc2ceb0ad
Remove ASDisplayNodeExtraIvars
2016-04-15 21:48:11 +03:00
Garrett Moon
dd998b086f
I think this needs a lock.
...
Summary: Looks like this isn't being locked when it should be.
Reviewers: ricky, levi, scottg, schneider
Reviewed By: scottg, schneider
Subscribers: jenkins
Differential Revision: https://phabricator.pinadmin.com/D84952
2016-04-15 10:41:31 -07:00
Michael Schneider
c0927f8028
Create helper function to get text range rects without locking
...
Add helper function that should be called within performBlockWithLockedTextKitComponents: in
an already locked state to prevent a deadlock
2016-04-15 09:57:24 -07:00
Michael Schneider
a9d0542d8f
If trailing rect was set early return
2016-04-15 07:10:22 -07:00
Michael Schneider
91b6995987
Fix deadlock calling trailingRect on a ASTextNode
2016-04-15 07:10:22 -07:00
Garrett Moon
755c5feaf8
Levi's comments
2016-04-13 14:23:02 -07:00
Garrett Moon
24c26014a7
Fix example builds
2016-04-13 14:23:02 -07:00
Garrett Moon
b56e20853b
Prevent retain cycle, clear out animatedImage on _clearImage.
2016-04-13 14:23:02 -07:00
Garrett Moon
e9b57d9da4
Address comments and cleanup
2016-04-13 14:23:02 -07:00
Garrett Moon
f4b526a8db
Fix non example build
2016-04-13 14:23:02 -07:00
Garrett Moon
1b316217ef
Downstream ASAnimatedImage
2016-04-13 14:23:02 -07:00
Garrett Moon
beba9031ef
Expose public properties properly
...
Reviewers: rmalik
Reviewed By: rmalik
Differential Revision: https://phabricator.pinadmin.com/D82227
2016-04-13 14:23:02 -07:00
Garrett Moon
3bcbfb149d
Add support for animated GIFs
...
Summary:
Use NSData as key
Add chunking of files
Add support for Animated Images
This adds support for GIF playback in ASDK. It's not currently ready
for merging to public ASDK – for one the GIF decompression may make
more sense in PINRemoteImage.
Removed duration as it wasn't used
Make cover image lazily loaded
Differential Revision: https://phabricator.pinadmin.com/D82033
2016-04-13 14:23:02 -07:00
Eric Jensen
527397ba7e
Replace id with instancetype in initializers
2016-04-13 11:20:05 -07:00
Michael Schneider
d0023a97f7
Fix fetching will continually trigger in a loop after reaching end of content
...
Don't schedule a new check for a batch fetch if no data changed previous batch fetch
2016-04-12 17:14:43 -07:00
Scott Goodson
8ccef1e99f
[ASEnvironment] Fix incomplete gating of upward propagation of layout properties (disabled for now).
2016-04-11 20:34:24 -07:00
appleguy
74407d50c4
Merge pull request #1513 from maicki/NodesLayerInLayerAccessiblity
...
[ASDisplayNode] Add handling layer backed accessibility elements within layer backed nodes
2016-04-11 17:46:19 -07:00
Michael Schneider
45d50624d1
Fix disabled state propagation for final layoutable
2016-04-11 17:41:48 -07:00
Michael Schneider
2fade63f1b
Add handling layer backed accessibility elements within layer backed nodes
2016-04-11 12:59:04 -07:00
Scott Goodson
678c201dbc
[ASLayout] Add additional validation step to intercept incorrect values in production and safely zero them out.
...
These conditions already had assertions, but at runtime, an insufficiently tested and incorrect ASLayoutSpec could
generate values that cause UIKit to enter an infinite loop (e.g. inside of UICollectionView layout validation).
2016-04-10 16:42:22 -07:00
Michael Schneider
ed0ed74b72
Add switch to enable / disable layout option properties
2016-04-10 15:04:49 -07:00
Michael Schneider
3c66013088
Remove logging message
2016-04-10 14:23:33 -07:00
appleguy
14fc30aab0
Merge pull request #1504 from hannahmbanana/hitTestDebug
...
[ASControlNode] Improved hitTestDebug to account for limiting display area by parent .clipsToBounds
2016-04-10 12:52:47 -07:00
Scott Goodson
974d8c8817
[ASEnvironmentState] Don't upward-propagate sizeRange or layoutPosition (this behavior, if ultimately desirable, requires additional limiting conditions).
2016-04-10 01:31:32 -07:00
Hannah Troisi
4bd48505af
[ASControlNode] hitTestDebug name refactoring
2016-04-10 01:15:15 -07:00
Hannah Troisi
a6f779a7fe
[ASControlNode] hitTestDebug tool refactoring + comments:wq
2016-04-10 00:51:36 -07:00
Hannah Troisi
7fa810c77f
[ASControlNode] modified hitTestDebug tool vizualize clipping of .clipsToBounds & fixed bug
...
- added orange overlay edge highlighting if tapable area clipped by .clipsToBounds of any parent in the hierarchy
- fixed bug in comparison of child / parent rect edges
2016-04-10 00:19:00 -07:00
Hannah Troisi
f633f6fff0
[ASControlNode] modify hitTestDebug tool to highlight edges clipped by one or more superviewsw
2016-04-09 21:36:57 -07:00
appleguy
7c4db3fbc1
Merge pull request #1477 from maicki/SmallContentBatchFetch
...
[ASBatchContext] Fix fetch call won't occur for content smaller than bounds unless user scrolls
2016-04-09 19:15:06 -07:00
Michael Schneider
6a147021bc
Move setting of accessibilityFrame into accessibleElements
...
- Calculate accessibilityFrame for accessibleElements already in accessibleElements method
- Remove asyncdisplaykit_node associated object as it's not needed anymore
2016-04-09 17:03:35 -07:00
Michael Schneider
1b7db082dd
Improve _ASDisplayViewAccessibility
...
- Add class method to create a UIAccessibilityElement from a ASDisplayNode
- Add function to iterate through a ASDisplayNode tree in bfs fashion
- Add assert for _accessibleElements in accessibilityElementAtIndex:
2016-04-09 16:07:30 -07:00
Michael Schneider
14ca529911
Moving accessibility related code to _ASDisplayViewAccessibility
2016-04-09 11:23:25 -07:00
Michael Schneider
a6f287a8fd
Address pull request comment regarding ASDisplayNode properties
2016-04-09 11:23:25 -07:00
Michael Schneider
3b91c22fdf
Recreate the accessibleElements if accessed
2016-04-09 11:23:25 -07:00
Michael Schneider
39950e74b2
Remove NS_AVAILABLE_IOS(8_0);
2016-04-09 11:23:25 -07:00
Michael Schneider
28c4fede57
Add support for newly added a11y properties in iOS 8 / 9 and tvOS
...
New a11y properties:
- accessibilityNavigationStyle
- accessibilityHeaderElements
- accessibilityActivationPoint
- accessibilityPath
2016-04-09 11:23:25 -07:00
Michael Schneider
34df512eeb
Remove ASNodeValidForAccessibility
2016-04-09 11:23:25 -07:00
Michael Schneider
f3303c1fb8
Add properties for accessibilty to ASDisplayNode to support layer backed nodes
2016-04-09 11:23:25 -07:00
Michael Schneider
ef31c3abf0
Copy accessibilityIdentifier to UIAccessibilityElement if a node is assigned
2016-04-09 11:23:25 -07:00
Michael Schneider
4056bf9ef3
Return NO if node i not valid for accessibility
2016-04-09 11:23:25 -07:00
Michael Schneider
03a7c55d59
Add accessibility support for shouldRasterizeDescendants and layerBacked nodese
2016-04-09 11:23:25 -07:00