Commit Graph

25012 Commits

Author SHA1 Message Date
Garrett Moon
04dc582a7a Rename didUpdateCurrentRangeMode to preserveCurrentRangeMode 2016-11-27 16:05:31 -08:00
Garrett Moon
62f378a9fd This patch enables memory warning support on ASRangeController by default
It also fixes a couple subtle bugs:
1. If a range controller update was in flight and you were manually setting the range
mode, you could actually clear out the range mode by calling updateCurrentRangeWithMode:
This is fixed by setting _didUpdateCurrentRange = YES if _needsRangeUpdate is YES.
2. Calling setNeedsUpdate after calling updateCurrentRangeWithMode: can cause the
current range mode to get cleared out. This is because updateCurrentRangeWithMode:
will not set _didUpdateCurrentRange if _currentRangeMode == rangeMode.
2016-11-27 15:42:07 -08:00
Rajeev Gupta
91734ea979 [Examples] CustomCollectionView in Swift3 (#2591)
* new Swift example

* removed asyncDataSource and asyncDelegate. Also using collectionNode methods instead of collectionView

* Fixing the folder structure

* Updated with @george-gw feedback. Thanks George.
2016-11-27 13:01:35 -08:00
appleguy
8d89f7074f Merge pull request #2662 from facebook/AHDrawMethodNoEscape
Add noescape Attribute to isCancelledBlock Parameters
2016-11-27 11:12:36 -08:00
Adlai Holler
c205edc1b1 Merge pull request #2656 from maicki/MSHandleRootNodeViewLoadingInASViewController
[ASViewController] Trigger load view in ASViewController if node did load but not the view of the view controller
2016-11-27 10:43:42 -08:00
Adlai Holler
aee2aaf40a Align the colons 2016-11-27 10:36:21 -08:00
Adlai Holler
b689a59b45 Mark isCancelled block as noescape to improve the Swift import 2016-11-27 10:31:35 -08:00
Michael Schneider
c178df0dbc Fix typo 2016-11-23 20:31:37 -08:00
Michael Schneider
64a316679c Trigger load view in ASViewController if node did load but not the view of the view controller 2016-11-23 20:31:37 -08:00
appleguy
aefff563bd Merge pull request #2651 from facebook/PlaceholderContents
[ASDisplayNode] Create placeholders off main when possible.
2016-11-23 16:33:44 -08:00
Adlai Holler
7b71861e1f Merge pull request #2652 from ay8s/master
Update AsyncDisplayKit.podspec for 2.0-beta.2
2016-11-23 16:24:40 -08:00
Scott Goodson
3bfb437f2b [Cocoapods] Update version to 2.0-beta.2 2016-11-23 16:15:51 -08:00
Adlai Holler
97a328b83d Merge pull request #2654 from maicki/MSKittensExampleAccessViewInInit
[Examples] Never access the view property of the node in init
2016-11-23 16:10:05 -08:00
Adlai Holler
479dd6740e Merge pull request #2655 from rahul-malik/rmalik-nsurlsessionfix
Re-add NSURLSessionConfiguration support and fix crashes
2016-11-23 16:09:57 -08:00
Adlai Holler
14765a55d2 Revert "Merge pull request #2649 from facebook/AHCollectionNodeInitializer"
This reverts commit 0f620f458d, reversing
changes made to 0c65d21f8d.
2016-11-23 15:56:24 -08:00
rmalik
15f8dc572a - Fix assignment of alternativeRepresentationProvider to be the singleton
instance of ASPINRemoteImageDownloader.
- Revert "Revert "Expose internal singleton method as a class method vs instance method.""
- Fix API bug in ASCollectionNode+Beta
2016-11-23 15:51:40 -08:00
Michael Schneider
4f1d7ec064 Never access the view property of the node in init 2016-11-23 15:50:26 -08:00
Michael Schneider
1f7b838d5e Not animated for end updates if animation is already going on within ASTableView
Fix strange artifacts in ASTableView are visible when changing the device orientation or other animations are going on while calling endUpdates
2016-11-23 14:31:37 -08:00
Adlai Holler
0f620f458d Merge pull request #2649 from facebook/AHCollectionNodeInitializer
[ASCollectionNode] Modify Initialization API
2016-11-23 13:35:59 -08:00
Andrew Yates
0d092528e6 Update AsyncDisplayKit.podspec 2016-11-23 10:31:27 -08:00
Scott Goodson
1c70412868 [ASDisplayNode] Create placeholders off main when possible.
This is a fix for https://github.com/facebook/AsyncDisplayKit/issues/2620,
which is a followup to https://github.com/facebook/AsyncDisplayKit/pull/2610

This will ensure thread affinity is respected for .contents but still run
placeholderImage off-main when possible (node isn't loaded).
2016-11-22 22:29:24 -08:00
Scott Goodson
0c65d21f8d Revert "Expose internal singleton method as a class method vs instance method."
Causing crash: +[ASPINRemoteImageDownloader alternateRepresentationWithData:options:]: unrecognized selector sent to class 0x198e3d8

This reverts commit 91c06272b1.
2016-11-22 21:59:58 -08:00
appleguy
b0644dba3b Merge pull request #2650 from rahul-malik/fix-nsurlsessionconfig
Expose internal singleton method as a class method vs instance method in ASPINRemoteImageDownloader
2016-11-22 18:04:58 -08:00
rmalik
91c06272b1 Expose internal singleton method as a class method vs instance method.
Currently setting an NSURLSessionConfiguration through ASPINRemoteImageManager
will crash.
2016-11-22 18:04:19 -08:00
Adlai Holler
94a0ba8635 Make the tests pass 2016-11-22 16:52:48 -08:00
Adlai Holler
04b93182cd Rejigger ASCollectionNode initializers 2016-11-22 16:49:52 -08:00
overtake
a8a87b3aec Merge branch 'master' of https://github.com/peter-iakovlev/TelegramCore 2016-11-22 21:41:48 +03:00
overtake
e0ca8e91c4 core 2016-11-22 21:41:40 +03:00
overtake
d16426d7d8 Merge branch 'master' of https://github.com/peter-iakovlev/Postbox 2016-11-22 21:41:13 +03:00
Peter
e89f708e6f no message 2016-11-22 21:33:06 +03:00
Peter
07bf615a90 no message 2016-11-22 21:31:10 +03:00
Peter
6ab5c9b3b0 no message 2016-11-22 21:30:16 +03:00
Peter
8bd45739ed no message 2016-11-22 21:29:45 +03:00
Peter
28457a2e16 no message 2016-11-22 21:29:16 +03:00
Peter
c9487b2d17 Merge commit '67cb789f862fa7572a06159c230612ef3ad414c4'
# Conflicts:
#	AsyncDisplayKit/Details/ASEventLog.h
2016-11-22 21:28:49 +03:00
Benjamin Scholtysik (Reimold)
3b750b4f05 Merge pull request #370 from bitstadium/fix/analyzer-warning-inBITChanneltests
Reset BITSafeJsonEventsString instead of assigning NULL
2016-11-21 22:38:10 -08:00
Brandon Withrow
f646effcb0 Setup for new animation state machine 2016-11-21 16:40:38 -08:00
Austin Louden
67cb789f86 Fix self capture in ASCollectionNode (#2646)
* fix capture in ASCollectionNode

* fix capture self in ASTableNode
2016-11-21 15:28:56 -08:00
Austin Louden
60756a1da5 Fix self capture in ASCollectionNode (#2646)
* fix capture in ASCollectionNode

* fix capture self in ASTableNode
2016-11-21 15:28:32 -08:00
Garrett Moon
f3fa83610f Undo addinng 📦 2016-11-21 14:52:45 -08:00
Garrett Moon
7d1a670b6c Do not assert when scrollableDirections is called in base class. 2016-11-21 14:52:37 -08:00
Garrett Moon
b3754942f1 Fix build for life without cocoapods 2016-11-21 14:52:26 -08:00
Garrett Moon
000dbc818e [ASCollectionView] Move ASCollectionViewLayoutInspector to its own file 2016-11-21 14:52:12 -08:00
Adlai Holler
d4191dc543 Merge pull request #2640 from facebook/AHRegisterDealloc2Main
Make a Public Function for Main Thread Deallocation
2016-11-21 11:56:10 +09:00
Adlai Holler
9a762f9832 Make a public function ASPerformMainThreadDeallocation 2016-11-21 11:17:24 +09:00
Adlai Holler
71872a298e Merge pull request #2223 from facebook/AHNaturalDealloc
[ASDisplayNode] Let Nodes Deallocate Naturally, Deallocate UIKit Components in Run Loop
2016-11-21 01:20:47 +09:00
Adlai Holler
10104f8ff0 Merge pull request #2638 from facebook/AHMediaTime
Use CACurrentMediaTime Instead of CFAbsoluteTime
2016-11-21 01:20:12 +09:00
Adlai Holler
e923943e8c Use CACurrentMediaTime instead of CFAbsoluteTime 2016-11-21 00:54:07 +09:00
Adlai Holler
887f48cbda Add support for run loop queues with no handler, optimize 2016-11-21 00:49:54 +09:00
Adlai Holler
6d01bbeb19 Let nodes deallocate naturally, manually trampoline UIKit ivars
Be more aggressive with main thread punting

Trampoline setting the dataSource/delegate onto the main thread

Short-circuit the supplementary nodes method if no data source

Don't rely on assertions

Mark variable unused to fix release builds

Handle ASCollectionNode/ASTableNode deallocation better

Add some comments about new macro
2016-11-21 00:46:57 +09:00