Michael Schneider
5226879291
Some commit
2016-11-19 06:43:45 -08:00
Adlai Holler
307a1a0ab6
Merge pull request #2625 from MarvinNazari/master
...
[ASCellNode] implement a .viewController property
2016-11-19 15:49:32 +09:00
Garrett Moon
654b520b6d
If you override the property, you need to specify __weak ( #2630 )
2016-11-18 14:44:47 -08:00
Garrett Moon
22c629648f
If you override the property, you need to specify __weak ( #2631 )
2016-11-18 14:44:39 -08:00
Garrett Moon
2284914c36
If you override the property, you need to specify __weak ( #2631 )
2016-11-19 07:42:44 +09:00
Garrett Moon
fb48a27160
If you override the property, you need to specify __weak ( #2630 )
2016-11-19 06:20:25 +09:00
Benjamin Scholtysik (Reimold)
9440422f2e
Reset BITSafeJsonEventsString instead of assigning NULL
2016-11-18 12:47:43 -08:00
Benjamin Scholtysik (Reimold)
eca744a767
Made changes as suggested by Mehrdad
2016-11-18 12:36:40 -08:00
Benjamin Scholtysik (Reimold)
4ee11d9426
Add persian language file
2016-11-18 12:23:31 -08:00
Benjamin Scholtysik (Reimold)
99558c4992
Merge pull request #260 from msulland/feature/norwegian-translation
...
Added Norwegian translation
2016-11-18 11:56:59 -08:00
Marvin Nazari
b578eb7490
[ASCellNode] Force the view to load if we haven't already
2016-11-18 12:38:59 +01:00
overtake
30d9f51737
Merge branch 'master' of https://github.com/peter-iakovlev/TelegramCore
...
Conflicts:
TelegramCore.xcodeproj/project.pbxproj
2016-11-18 12:18:24 +03:00
overtake
929ddbf7cb
Merge branches 'master' and 'master' of https://github.com/peter-iakovlev/Postbox
...
Conflicts:
Postbox.xcodeproj/project.pbxproj
2016-11-18 12:17:46 +03:00
overtake
a82e5f148a
😔
2016-11-18 12:16:53 +03:00
overtake
bcad06a38f
😔
2016-11-18 12:16:52 +03:00
Adlai Holler
198ea7a99d
Merge pull request #2627 from maicki/MSFixStackLayoutSpaceRounding
...
[ASStackLayoutSpec] Don’t floor space between items for ASStackLayoutJustifyContentSpaceBetween and ASStackLayoutJustifyContentSpaceAround
2016-11-18 14:48:59 +09:00
Michael Schneider
bc0443db02
Don’t floor space between items for ASStackLayoutJustifyContentSpaceBetween and ASStackLayoutJustifyContentSpaceAround
2016-11-17 18:05:22 -08:00
Peter
46882a10dc
no message
2016-11-17 22:17:44 +03:00
Peter
3b147df197
no message
2016-11-17 22:17:16 +03:00
Peter
55ea86d5d5
no message
2016-11-17 22:17:05 +03:00
Peter
45f81135c2
no message
2016-11-17 22:16:50 +03:00
Peter
962940aae9
no message
2016-11-17 22:16:33 +03:00
David Robles
db45b5d814
Update sample video project to allow for testing video’s placeholder image isn’t prematurely cleared.
2016-11-17 10:35:47 -08:00
David Robles
4ad8361eea
Prevent premature placeholder image clearing when setting the video asset at a later point in time.
2016-11-17 10:35:26 -08:00
Marvin Nazari
31ffea40c2
[ASCellNode] implement a .viewController property
2016-11-17 11:26:55 +01:00
Adlai Holler
da465bf812
Merge pull request #2624 from facebook/HTDeprecateTableViewDelegates
...
[ASCollectionNode, ASTableNode] Deprecate asyncDelegate & asyncDataSource Properties
2016-11-17 18:41:41 +09:00
Peter
8dbf1529ec
Merge commit 'c3ac8f773a435fcbea83a43d425cd5c2294cef0e'
2016-11-17 11:52:07 +03:00
Peter
11db9b6a7b
Merge commit 'a568d02c333ac1ffef5dae971964363afec20cd3'
...
# Conflicts:
# AsyncDisplayKit/ASDisplayNode.h
# AsyncDisplayKit/ASDisplayNode.mm
# AsyncDisplayKit/Private/ASInternalHelpers.m
# AsyncDisplayKitTests/ASDisplayNodeTests.m
2016-11-17 11:51:43 +03:00
Hannah Trosi
6565b8348d
collectionView
2016-11-17 16:46:07 +09:00
Adlai Holler
c3ac8f773a
Don't rely on assertions
2016-11-17 15:26:16 +09:00
Hannah Trosi
c9143fb5df
tableView only
2016-11-17 15:18:55 +09:00
Adlai Holler
00f448d534
Merge pull request #2623 from facebook/AssertLog
...
[ASDisplayNode] Convert assertion to log so developer can see layout issues onscreen.
2016-11-17 14:55:44 +09:00
Adlai Holler
b0ead608d9
Merge pull request #2622 from facebook/AHEventLoggingInProduction
...
[ASTraceEvent, Debugging] Greatly Improve Event Logging.
2016-11-17 14:53:56 +09:00
Scott Goodson
8c01fccfca
[ASDisplayNode] Convert assertion to log so developer can see layout issues onscreen.
...
In this case, the user hasn't specified enough about the layout of a node. We default to
0, 0 - but ideally the case should not occur at all. So it's important to help developers
detect these cases and fix them quickly.
An assertion causes developers several problems:
- They can't see important information unless an exception breakpoint is manually added.
- They can't see their layout onscreen and so visually understanding the problem is impossible.
- They can't proceed with testing to trigger other faults in the layout and are blocked fixing one at a time.
A log fixes every one of those problems:
- They can set a breakpoint on the log line very easily if desired.
- They can see their layout display and recognize the 0,0 node even more quickly than the log text information.
- They can see if multiple logs print out, or if the log only occurs for one item in a feed, or certain types --
This helps them debug faster by knowing if the layout is always broken or certain conditions break it.
Since developing with ASLayoutSpecs is an iterative process, it's crucial that we let developers have the
freedom to experiment and test without hitting too many assertions. Fortunately it will be impossible to ignore
these huge logs (full recursive description) and their nodes will be 0, 0 size, so they will get fixed.
2016-11-16 21:14:15 -08:00
Adlai Holler
4a48ba8be2
Improve our event logging greatly
2016-11-17 12:04:30 +09:00
Adlai Holler
df7c2b6d96
Merge pull request #2619 from craighowarth/allow-decoration-views
...
[ASCollectionView] Allow Decoration Views
2016-11-17 09:43:03 +09:00
Craig Howarth
e8688d645a
[ASCollectionView] Allow Decoration Views
2016-11-16 17:16:15 -05:00
Doug Tabuchi
e67bfb941d
Don't store token after first message
2016-11-16 11:07:36 -05:00
overtake
7c7e40b0a9
Merge branch 'master' of https://github.com/peter-iakovlev/TelegramCore
2016-11-16 13:53:21 +03:00
overtake
606b442ed4
Merge branch 'master' of https://github.com/peter-iakovlev/Postbox
2016-11-16 13:53:03 +03:00
Adlai Holler
a568d02c33
Let nodes deallocate naturally, manually trampoline UIKit ivars
...
Be more aggressive with main thread punting
Trampoline setting the dataSource/delegate onto the main thread
Short-circuit the supplementary nodes method if no data source
2016-11-16 16:46:39 +09:00
Adlai Holler
14fa50d42f
Merge pull request #2613 from facebook/AHFixCarthage
...
Fix the Carthage Build
2016-11-16 11:51:09 +09:00
Adlai Holler
9e04088b65
Merge pull request #2610 from garrettmoon/fixCallingContentsOffMainThread
...
[ASDisplayNode] Placeholder contents configuration needs to check self.contents on main.
2016-11-16 11:09:26 +09:00
Adlai Holler
244ff00152
Fix carthage?
2016-11-16 11:03:55 +09:00
Peter
efe13e4130
no message
2016-11-15 19:02:08 +03:00
Peter
93827a3dda
no message
2016-11-15 19:01:52 +03:00
appleguy
4d16d58407
Add method to specify the default NSURLSessionConfiguration for ( #2609 )
...
ASPINRemoteImageDownloader. This will allow callers to supply their own custom
logic whether that is background downloads, custom http headers, cookie
storage, etc.
2016-11-14 19:53:30 -08:00
Adlai Holler
a080773532
Remove legacy ASVideoNode flags ( #2608 )
2016-11-15 11:56:56 +09:00
Garrett Moon
b1f0bbf514
self.contents isn't safe to access on the main thread.
2016-11-14 16:21:14 -08:00
rmalik
7769883dc8
Add method to specify the default NSURLSessionConfiguration for
...
ASPINRemoteImageDownloader. This will allow callers to supply their own custom
logic whether that is background downloads, custom http headers, cookie
storage, etc.
2016-11-14 16:19:48 -08:00
