Michael Schneider
e84f9f27c2
Fix measurement of ASEditableTextNode
...
- Add ability to measure the ASEditableTextNode based on the content now by calling measure:
- ASEditableTextNode considers preferredFrameSize now
- Fix crash if ASEditableTextNode is included in a horizontal stack
- Add tests for ASEditableTextNode
2016-05-31 16:29:40 -07:00
Erekle
100d2b4f26
moved spinner to ASVIdeoPlayerNode
2016-05-19 15:07:39 +04:00
Erekle
98c451118b
removed play button
...
* Removed play button from ASVideoNode
* Removed play button tests
* added some checks in ASVideoPlayerNode
* added new delegate method for time formats
2016-05-13 00:46:55 +04:00
appleguy
495f32f0ef
Merge pull request #1570 from maicki/FixASTextNodeAttributedStringInconsitency
...
[ASTextNode] Fix API ASTextNode API inconsistencies
2016-05-10 13:44:56 -07:00
rcancro
22e026a5e1
fix truncater method to only return the truncater.
2016-05-09 16:36:27 -07:00
Michael Schneider
29ab87a1e4
Fix API ASTextNode API inconsistencies
...
- Deprecate attributedString in ASTextNode in favor of attributedText to be aligned with UILabel
- Deprecate truncationAttributedString in ASTextNode in favor of truncationAttributedText to be aligned with attributedText
2016-05-04 21:03:31 -07:00
Robin Chou
39ee33f21a
Update remaining tests.
2016-04-28 21:13:34 -04:00
Robin Chou
9c2909a968
Updating tests.
2016-04-28 21:04:04 -04:00
Michael Schneider
5cfc16733a
Add node as parameter in ASLayoutSpecBlock
2016-04-22 11:22:20 -07:00
Michael Schneider
87a37a283e
Add a block API to provide an ASLayoutSpec without having to subclass ASDisplayNode
2016-04-20 19:16:54 -07:00
Eric Jensen
6a4bc3fd5b
Rename setPlaceholderImage to setVideoPlaceholderImage in order to prevent super class setter conflict
2016-04-18 22:30:32 -07:00
Eric Jensen
b5c3b15069
Observe playbackLikelyToKeepUp in order to handle player buffer filling and emptying
2016-04-18 22:13:49 -07:00
Eric Jensen
e65d63a502
Simplified and improved video node's handling of state changes:
...
- Simplified visibility state change handling.
- Placeholder image is now updated after switching assets.
- Improves memory usage by clearing the placeholder image in clearFetchedData.
2016-04-18 22:13:49 -07:00
appleguy
f9d00eea93
Merge pull request #1550 from maicki/FixArrayDiffStaticAnalyzer
...
[NSArray+Diffing] Static analyzer issue with common indexes algorithm in _asdk_commonIndexesWithArray:
2016-04-18 22:01:29 -07:00
Michael Schneider
9d07336c75
Fix static analyzer issue with common indexes algorithm in _asdk_commonIndexesWithArray:
...
The issue was: The left operand of '>=' is a garbage value in else if check for lengths[i+1][j] ... I had to rewrite the algorithm to quiet the static analyzer.
2016-04-18 14:38:32 -07:00
Eric Jensen
c1c1358baf
Fix video stalling by pausing the video after backgrounding the application
2016-04-18 13:53:43 -07:00
Eric Jensen
983c2f1f49
Replacing ASVideoNode's playButton now cleans-up the previous button's state
2016-04-18 13:53:43 -07:00
Eric Jensen
cdb926c0a1
Correct mismatch between video gravity and placeholder image content mode
2016-04-18 13:53:43 -07:00
Scott Goodson
11744b7f31
[ASVideoNode] Cleanup from recent diffs, standardizing on .asset rather than .url.
2016-04-17 20:12:37 -07:00
appleguy
94d0d908dc
Merge pull request #1323 from gazreese/AVPlayerItem-construction
...
[ASVideoNode] Add support for HTTP Live Streaming Video
2016-04-17 19:30:23 -07:00
Huy Nguyen
a35647b200
Remove unused _enqueueAsyncSizingWithSentinel and asyncSizingQueue methods of ASDisplayNode
2016-04-15 22:08:21 +03:00
Garrett Moon
f4b526a8db
Fix non example build
2016-04-13 14:23:02 -07:00
Michael Schneider
28c4fede57
Add support for newly added a11y properties in iOS 8 / 9 and tvOS
...
New a11y properties:
- accessibilityNavigationStyle
- accessibilityHeaderElements
- accessibilityActivationPoint
- accessibilityPath
2016-04-09 11:23:25 -07:00
Michael Schneider
b284d3f606
Enable tests for accessibility properties for layer backed nodes
2016-04-09 11:23:25 -07:00
Gareth Reese
9e28e07925
ASVideoNode updates based on review comments in https://github.com/facebook/AsyncDisplayKit/pull/1323
2016-04-07 14:08:45 +01:00
Gareth Reese
c8a414be9b
Merged branch 'master' into AVPlayerItem-construction
2016-04-06 15:22:10 +01:00
appleguy
b3d6b545f8
Merge pull request #1478 from lappp9/muting-video-nodes
...
[ASVideoNode] Ensure mute property is passed onto the internal player
2016-04-05 22:10:43 -07:00
Adlai Holler
9e56cb553f
[ASControlNode] Squash duplicated target-action-event tuples, fix assertion failure removing nil target
2016-04-05 15:51:53 -07:00
Luke Parham
be463c0a17
muting the video node mutes the player
2016-04-05 02:37:07 -05:00
appleguy
6d1c52b042
Merge pull request #1456 from maicki/ASEnvironment
...
[ASEnvironment] Add support for ASEnvironment, supporting generalized state propagation both up and down node and layout spec trees.
2016-03-31 21:05:38 -07:00
Michael Schneider
96df35e41a
Initial commit for ASEnvironment
2016-03-31 20:43:20 -07:00
Eric Jensen
387abbff5d
Rename ASTextKitHelpers to ASTextKitComponents and make the header public
2016-03-26 15:31:53 -07:00
Eric Jensen
12da9ac6a9
Improve Swift compatibility of ASHorizontalAlignment & ASVerticalAlignment by using consistent naming
2016-03-21 11:16:28 -07:00
Sam Stow
086bd8a52b
[ASRelativeLayoutSpec] New core layout spec type: Relative Position, now powers Center as well.
...
This spec allows positioning a child at any 9-part box position (corners, edges, or center).
2016-03-19 22:37:02 -07:00
Scott Goodson
8308a4ce49
[AsyncDisplayKit] Adopt #pragma once, remove last remaining dispatch_sync (UIScreen scale).
2016-03-19 19:56:41 -07:00
Hannah Troisi
f9a92366d3
[AsyncDisplayKit] Fix build so we can weak link AVFoundation
...
Unclear why the framework target required these seemingly unrelated changes to Collection
classes, but I modeled them after related files and it seems cleaner now (passes tests & framework target)
2016-03-19 17:54:02 -07:00
Scott Goodson
abd148ae2e
[Testing] ASVideoNodeTests should not pass in an invalid combination of ASInterfaceState flags.
2016-03-15 17:25:47 -07:00
Gareth Reese
a95300e145
Merged master into AVPlayerItem-construction
2016-03-14 13:21:42 +00:00
appleguy
fe8cc9328c
Merge pull request #1358 from ejensen/asynchronous-test
...
[Tests] Replace sleep() with XCTest asynchronous expectations
2016-03-11 22:38:07 -08:00
Scott Goodson
cdd1bd1e39
[ASRangeController] Ensure that visibilityDidChange: is always called on app launch for all initial cells.
2016-03-11 17:18:32 -08:00
Eric Jensen
a3331b42ae
Replace sleep() in ASBasicImageDownloaderTests with XCTest asynchronous expectations
2016-03-09 18:57:31 -08:00
appleguy
de4e4db671
Merge pull request #1340 from ejensen/documentation-corrections
...
[Documentation] Various header documentation corrections and refinements.
2016-03-09 02:52:48 -08:00
Scott Goodson
8703920d55
[Xcode Project] Add new file to the framework target. Update to recommended build settings to resolve 1 of 1 warnings.
2016-03-08 22:58:27 -08:00
Scott Goodson
06ea9461cb
[ASScrollDirection] Fix tests to use the more intuitive naming for scroll directions.
2016-03-08 22:48:02 -08:00
Eric Jensen
c2f85397ce
Mark depreciated protocols with deprivation attribute
2016-03-08 11:56:58 -08:00
Gareth Reese
f7ff8b4173
Updated tests to cover the new API and repeated all of the test logic for URL initialisation to ensure that the functionality is the same
2016-03-08 08:30:13 +00:00
Eric Jensen
cb1579e8af
Check the AVAsset's type before casting to an AVURLAsset
2016-02-26 11:00:27 -08:00
appleguy
3abde9348d
Merge pull request #1256 from Adlai-Holler/AHAffinityRevisions
...
[ASDisplayNode] Post-Review Refinements of Recent No-Affinity UIKit/CA Property Bridging
2016-02-22 20:41:59 -08:00
rcancro
00b0968bf7
Add ability to customize NSLayoutManager and NSTextStorage when created in the ASTextKitContext
2016-02-22 13:00:02 -08:00
Adlai Holler
648dc817ad
[ASDisplayNode] Use a C function to lazily create pending view state
2016-02-21 10:03:06 -08:00