Hannah Trosi
3994f2089c
[ASCellNode] Final revisions to behavior of setSelected: & setHighlighted:
2016-07-05 17:47:00 -07:00
Hannah Trosi
61d7c093a1
Merge branch 'master' into selectionBug
2016-07-02 11:50:19 -07:00
Hannah Trosi
3080ee33cf
Revert "update from master/"
...
This reverts commit d7fde61e16 .
2016-07-02 11:45:40 -07:00
Adlai Holler
5d7f3b4293
Merge pull request #1819 from kielgillard/master
...
[ASDisplayNodeExtras] Collect subnodes passing the test
2016-07-02 08:55:51 -07:00
Hannah Trosi
d7fde61e16
update from master/
2016-07-01 16:25:48 -07:00
Adlai Holler
a77a6eaaf5
Merge pull request #1820 from gazreese/ASCollectionView-tuning-parameters
...
[ASCollectionView] Tuning parameters not set
2016-07-01 15:09:01 -07:00
Adlai Holler
d82e1ce95b
Merge pull request #1812 from facebook/AHUpdateIntegrity
...
[ASDataController] Improve Update Handling, Esp. Reloading Sections
2016-06-27 18:11:11 -07:00
Gareth Reese
d55621c285
[ASCollectionView] Tuning parameters not set
2016-06-27 14:07:00 +01:00
Hannah Troisi
db04f4b851
[ASTableView] Add constrainedSizeForRowAtIndexPath: to control row heights from delegate ( #1769 )
...
* [ASTableView] constrainedSizeForRowAtIndexPath
* Quick fix to header file
* Switch to Delegate from DataSource.
* Update testing variables to reflect switch to delegate
2016-06-26 23:09:53 -07:00
Kiel Gillard
cc74fb0cdc
Prove the change gets the correct nodes with a pair of tests.
2016-06-27 12:53:33 +10:00
Hannah Trosi
2e4b1ea053
[ASCellNode] Fix selection / highlight implementation
2016-06-25 00:22:28 -07:00
Hannah Troisi
e4abe898d5
[ASEditableTextNode] Support UITextInputTraits pass-through methods (threadsafe for use before view creation) ( #1809 )
...
* [ASEditableTextNode] Support UITextInputTraits
* consistent property attributes
* remove logging, fix tests to account for UIKit weirdness
* address @appleguy's comments
2016-06-24 16:53:10 -07:00
Adlai Holler
5d72f2f2cc
Enable the thrash testing
2016-06-24 11:12:37 -07:00
Adlai Holler
681876bd59
Fix more issues with data integrity
2016-06-24 11:12:37 -07:00
Adlai Holler
35056f708b
[ASDataController] Improve update handling
2016-06-24 11:12:37 -07:00
Adlai Holler
71d9f64535
Carry over first-pass change set improvements
2016-06-24 11:12:37 -07:00
Adlai Holler
457e08005f
[ASDataController] Remove asyncDataFetching Option, Cleanup ( #1794 )
...
* [ASDataController] Add some assertions to clarify what queues things happen on
* [ASCollectionDataController] Optimize willReloadData
* [ASDataController] Minor optimizations, no functional changes
* [ASDataController] Always reload data on _editingTransactionQueue
* [ASDataController] Remove async data fetching option, deprecate callbacks
* [ASDataController] Not mutable
* [ASMultidimensionalArrayUtils] Use fast enumeration
* Optimize ASMultidimensionalArrayUtils
2016-06-23 21:08:44 -07:00
Adlai Holler
57310a6fe4
Merge pull request #1802 from facebook/AHThrashTesting
...
[Unit Tests] Add Table View Data Thrash Testing
2016-06-22 21:35:58 -07:00
Michael Schneider
7175afba59
Merge pull request #1790 from gazreese/ASVideoNode-delegate-superclass
...
[ASVideoNode] Ensure that both ASVideoNode and ASNetworkImageNode delegate methods are called
2016-06-22 20:43:49 -07:00
Adlai Holler
12336de325
[ASThrashTesting] Array is immutable
2016-06-22 17:25:09 -07:00
Adlai Holler
9fc3ec9096
[ASThrashTesting] Numbers so magic
2016-06-22 17:19:36 -07:00
Adlai Holler
bd7f90f7ee
[ASThrashTesting] Remove unneeded clang diagnostics
2016-06-22 17:14:01 -07:00
Adlai Holler
3ca95778df
[ASThrashTesting] Some cleanup
2016-06-22 17:11:21 -07:00
Adlai Holler
383667f2c3
[ASThrashTesting] Rocking and rolling!
2016-06-22 17:02:46 -07:00
John Engelhart
ea64d7d09b
Pr/fix unit tests memory leaks ( #1795 )
...
* Fix some concurrency problems detected by Xcode 8's new Thread Sanitizer.
Some of these changes are arguably just to silence the warnings from Thread Sanitizer.
* Fix several memory leaks in the unit tests.
A number of the unit test source files are compield with `-fno-objc-arc`. This was clearly overlooked when writing several of the unit tests.
Fixed by (mostly) switching to use of `-autorelease` for the problem code.
NOTE: This commit doesn't fix all the memory leaks found. There's still at least one leak in `-[ASDisplayNodeTests testSetNeedsDataFetchImmediateState]`, and several leaks in `ASBasicImageDownloader.mm`. I wasn't able to find a trivial cause to these, unfortunately.
2016-06-22 16:56:53 -07:00
Adlai Holler
4184c21c0c
[ASThrashTesting] Continue setting up replay feature
2016-06-22 15:46:47 -07:00
Adlai Holler
15e03d85cf
[ASThrashTesting] Move update into an archivable object so we can replay tests
2016-06-22 14:19:59 -07:00
Adlai Holler
290897cb56
[ASThrashTesting] Little more cleanup
2016-06-22 13:06:16 -07:00
Adlai Holler
64835c0db7
[ASThrashTesting] It's working! + Cleanup
2016-06-22 13:04:47 -07:00
Adlai Holler
fcf2db79f8
[ASTableViewThrashTests] Initial commit
2016-06-21 18:46:08 -07:00
Gareth Reese
3fee0810d5
[ASVideoNode] Ensure that both ASVideoNode and ASNetworkImageNode delegate methods are called for ASVideoNode observers
2016-06-21 11:36:54 +01:00
Adlai Holler
0002d333f0
[ASDisplayNodeTests] Add some removeFromSupernode tests
2016-06-16 17:59:50 -07:00
Hannah Troisi
c857e809f4
Clean up header comments (for consistent Facebook licensing info) ( #1741 )
...
[Licensing] Clean up header comments (for consistent Facebook licensing info)
2016-06-11 23:31:39 -07:00
appleguy
c211c76c64
Merge pull request #1735 from levi/betterFlatten3
...
[ASLayout] Clean up flattening process of ASLayout
2016-06-11 23:15:16 -07:00
appleguy
a7128cd213
Merge pull request #1605 from lappp9/override-callback-for-display-range
...
[ASDisplayNode] Added callbacks for entering and exiting fetch data and display ranges
2016-06-11 22:21:20 -07:00
Levi McCallum
a3e8f556a3
Clean up flattening process in ASLayout
2016-06-10 12:43:46 -07:00
Levi McCallum
ca2fb0bc74
Update FBSnapshotTestCase and generate @3x images
2016-06-08 13:33:03 -07:00
Luke Parham
fc5467b110
fixed typo and added backwards compatibility for 'visibilityDidChange'
2016-06-06 02:02:23 -05:00
Luke Parham
e510120031
changed '-visibilityDidChange:' to '-visiblieStateDidChange:' to match the others
2016-06-06 00:56:21 -05:00
Luke Parham
d47059dffe
updated load and display did change methods
2016-06-06 00:56:21 -05:00
Luke Parham
8526171b30
reenabled new tests
2016-06-06 00:56:21 -05:00
Luke Parham
449a2cc517
added callbacks for entering and exiting fetch data and display ranges
2016-06-06 00:56:21 -05:00
appleguy
3725e53fe9
Merge pull request #1687 from levi/constrainedSize
...
[ASDisplayNode] Move constrained size to ASLayout
2016-06-05 18:26:03 -07:00
Hannah Troisi
52d58992da
[ASVideoNode] Change superclass to ASNetworkImageNode so that it can be its own placeholder ( #1710 )
...
* [ASVideoNode] Change superclass to ASNetworkImageNode so that ASVideoNode can be its own placeholder
- remove _placeholderImageNode property of ASVideoNode (use self.image now instead)
- move layoutSpecThatFits: code to calculateSizeThatFits: & layout: methods as ASImageNode uses calculateSizeThatFits:
* [ASVideoNode] Tweaks to the definition of the delegate protocols to integrate with ASNetworkImageNode (superclass)
2016-06-05 18:18:52 -07:00
Levi McCallum
c469ad273b
[ASLayout] Cache constrained size range
2016-06-05 09:22:46 -07:00
appleguy
4804f429b9
Revert "[ASCollectionView] Add a "Null Object" for a layout inspector if custom layout is given but no layout inspector" ( #1713 )
2016-06-04 22:49:10 -07:00
appleguy
c9b448bc95
Merge pull request #1674 from maicki/RefactorASCollectionViewLayoutInspectingUsage
...
[ASCollectionView] Add a "Null Object" for a layout inspector if custom layout is given but no layout inspector
2016-06-04 21:30:48 -07:00
Michael Schneider
750d57d964
Disable _ASDisplayLayer test
2016-06-04 20:05:41 -07:00
Michael Schneider
a914e3c428
Change visibleSizeRange to return a range with 0 location and length
2016-06-04 15:40:07 -07:00
Michael Schneider
00d9372ee4
Add a "Null Object" for a layout inspector if no no flow layout is given
...
The purpose of the ASCollectionViewCustomLayoutInspector is to provide a default implementation if given a custom layout, but no layout inspector.
2016-06-04 13:58:23 -07:00