appleguy
f7f468e5d1
Merge pull request #1093 from nguyenhuy/improve_reload_data
...
[ASDataController] Optimize reloadData to avoid performing deletions or insertions.
2016-01-22 13:34:37 -08:00
appleguy
bde37ac3b8
Merge pull request #1089 from Adlai-Holler/TextNodeIgnoreEmptyStringReplace
...
[ASTextNode] Ignore Setting Text to Nil When Text Is Already Empty
2016-01-22 11:09:11 -08:00
appleguy
e5b2b566e4
Merge pull request #1084 from lkzhao/master
...
Update comments for ASPanningOverriddenUITextView
2016-01-21 23:17:17 -08:00
Bin Liu
b2db6cce4d
remove public interface for ASCV with facilitator
2016-01-21 22:39:27 -08:00
Bin Liu
1965018c46
attempt to fix build
2016-01-21 15:20:47 -08:00
Bin Liu
8d3c32727e
fix build
2016-01-21 12:05:28 -08:00
Huy Nguyen
2e4d716e0b
ASDataController now handles reloadData more efficiently and notify its delegate once instead of a series of deletes and inserts
2016-01-21 11:21:21 -08:00
Bin Liu
726bc7d668
addressed comments
2016-01-21 11:14:00 -08:00
Luke Zhao
882379a820
Update comments for ASPanningOverriddenUITextView
2016-01-20 16:33:45 -08:00
Adlai Holler
db18724d5b
If they set attributedString to nil twice, ignore the second one.
2016-01-20 14:00:46 -08:00
Bin Liu
bc92c64e8c
Proposed version 1
2016-01-20 02:34:32 -08:00
Bin Liu
da2cbf4644
initial design
2016-01-20 02:34:32 -08:00
appleguy
3aceabbbf9
Merge pull request #1069 from lkzhao/master
...
[ASEditableTextNode] Support scrolling while maintaining workaround for Apple bug when disabling it.
2016-01-19 19:24:24 -08:00
appleguy
44aae77ef4
Merge pull request #1079 from aaronschubert0/ASTextNode-Fix-for-layout-bug
...
[ASTextKitRenderer] Potential fix headIndent attribute not being accounted for by the shadower.
2016-01-19 19:23:19 -08:00
appleguy
5be14e41fd
Merge pull request #1078 from aaronschubert0/ASTableView-Layout-bug-fix
...
[ASTableView] Ensure -[super layoutSubviews] is called before messaging delegate.
2016-01-19 19:21:19 -08:00
appleguy
1e8c70726c
Merge pull request #1083 from facebook/ASTableCollectionVisibility
...
Restore full functionality of the display / data ranges when not using the Node variants of Table / Collection.
2016-01-19 18:53:06 -08:00
Scott Goodson
b989be6499
Restore full functionality of the display / data ranges when not using the Node variants of Table / Collection.
2016-01-19 18:30:01 -08:00
Luke Zhao
995f437e12
Allow ASEditableTextNode to scroll
2016-01-19 10:32:19 -08:00
Adlai Holler
e972059f23
Remove SpinLock because it's illegal in iOS
2016-01-19 10:28:04 -08:00
Aaron Schubert
10a2984d8c
Potential fix for #1076
2016-01-19 12:25:30 +00:00
Aaron Schubert
7821a0aa19
Fixes bug #1077
2016-01-19 11:43:03 +00:00
Matej Knopp
a6da3d185a
[ASCollectionView] prevent data controller from removing/adding sections during reloadDataImmediately
...
Signed-off-by: Matej Knopp <matej.knopp@gmail.com >
2016-01-17 19:25:03 +01:00
Scott Goodson
6741ae658e
[ASCellNode] Ensure we don't trigger the UIViewController to be created early if we are wrapping one.
2016-01-14 23:28:15 -08:00
Scott Goodson
affb786a14
[ASButtonNode] Pass through setDisplaysAsynchronously: to subnodes (image and title).
2016-01-14 23:12:01 -08:00
Scott Goodson
e92a1360e7
Ensure new ASPagerNode has a weak reference to the data source.
2016-01-14 21:43:46 -08:00
Scott Goodson
df10f8f19a
Check array size before accessing section - rare crash for improper data source use, de-escalated to messaging nil.
2016-01-14 00:25:53 -08:00
appleguy
9afb77f7bc
Merge pull request #1058 from Adlai-Holler/DidEndDisplayingNodeProvideNode
...
Add New didEndDisplayingNode:forItemAtIndexPath: delegate methods to provide removed node
2016-01-13 23:55:34 -08:00
appleguy
a0c7b0a7b5
Merge pull request #1061 from dinhviethoa/ascontrolnode-touchesended-twice
...
Fixed behavior of ASControlNode when -touchesEnded:withEvent: sometimes firing twice.
2016-01-13 23:26:53 -08:00
Viet Hoa Dinh
dbe068c970
Fixed behavior of ASControlNode when -touchesEnded:withEvent: sometimes firing twice.
2016-01-13 19:06:01 -08:00
Adlai Holler
a19ba586f7
Revert change that seems to have caused internal inconsistency in range controller
2016-01-13 13:34:20 -07:00
Adlai Holler
d19e56d802
Beef up documentation around new delegate methods
2016-01-12 23:27:30 -07:00
Adlai Holler
5e72daa2e3
Pass node along in didEndDisplayingNode method
2016-01-12 15:42:37 -07:00
Scott Goodson
90a1bb2346
Ruthlessly improve efficiency in ASRangeControllerBeta.
...
- Use completedNodes directly, caching inner arrays and counts between loop iterations.
- Merge codepaths between the "entire self - table / collection" visible or invisible cases
- Ensure we do not trigger an assertion if a previous iteration's node is nil by the time
we try to reset its interfaceState.
2016-01-10 02:58:48 -08:00
Scott Goodson
0feaa2a368
Improvements to the efficiency of recursivelySetInterfaceState: and the beta range controller.
2016-01-10 02:40:47 -08:00
Scott Goodson
d45db5ac32
Disable creation of backing ASTable/CollectionNode for the *View varients (retain cycle).
2016-01-09 20:44:24 -08:00
appleguy
c3ef2efe0c
Merge pull request #1040 from facebook/ASRangeControllerBetaScrollJump
...
[ASRangeControllerBeta] Support disjoint ranges between updates (scroll jumps, etc)
2016-01-09 15:54:05 -08:00
Bin Liu
a36a955eb0
fix indentation
2016-01-06 13:09:59 -08:00
Bin Liu
4435405cbb
Make ASControlState imitate UIControlState
...
- selected state isn't implicitly controlled by ASControlNode anymore
- highlighted state can be overriden by users
- Decouple ASButtonNode's state from control events
2016-01-06 12:17:52 -08:00
Scott Goodson
bbfd08829f
Switch Tests to use ASRangeControllerBeta. Use NSSet instead of NSMutableSet.
2016-01-05 23:29:11 -08:00
Scott Goodson
d1c3894dbb
[ASRangeControllerBeta] Add tracking of all index paths that have .interfaceState set, ensure updating.
2016-01-05 23:17:54 -08:00
Bin Liu
4f67050b9b
Fix another typo, fix build failure
2016-01-05 18:04:26 -08:00
Bin Liu
82c098b39d
Fixed typo
2016-01-05 17:35:30 -08:00
Bin Liu
6bb51063f9
Replace ASButtonState with ASControlState
2016-01-05 17:07:44 -08:00
appleguy
8a5f080fcc
Merge pull request #1026 from 1nput0utput/ASControlNodeMutationCrash
...
[ASControlNode] Copy event table before calling action methods, as they may trigger action removal.
2016-01-03 20:18:30 -08:00
appleguy
005408bd2c
Merge pull request #1030 from facebook/OthogonalEfficiency
...
[ASRangeController] Inspect delegate's ASInterfaceState to delay preloading beyond viewport until visible.
2016-01-03 20:17:25 -08:00
Scott Goodson
984fe43997
[ASRangeController] Inspect delegate's ASInterfaceState to delay preloading beyond viewport until visible.
2016-01-03 19:14:07 -08:00
Rahul Malik
a509b7523f
Update interface of ASViewController to use lightweight generics. This allows
...
subclasses of ASViewController to specify the type of ASDisplayNode it
contains which allows for stronger type-checking and auto-completion against
the specified type.
Example Subclass Declaration:
@interface MyASViewController : ASViewController<MyASDisplayNodeSubclass *>
@end
2016-01-03 18:56:09 -08:00
Rajinder Ramgarhia
688e8d27de
Add comment explaning the change
2016-01-03 11:02:33 -05:00
Scott Goodson
25b6f29584
Introduce ASCollectionInternal file and create always-available ASCView -> ASCNode backpointer.
2016-01-01 23:36:00 -08:00
Rajinder Ramgarhia
73373ee17b
Fix ASControlNode mutation crash
2016-01-01 22:27:08 -05:00